Commit graph

36901 commits

Author SHA1 Message Date
Alan Knight 1f9395fb30 Add back CssCharsetRule for Safari support
BUG=

Review URL: https://codereview.chromium.org/1777683002 .
2016-03-08 14:40:57 -08:00
Paul Berry 1fa1b388c1 Fix incremental build of analyzer snapshot when pkg/analyzer changes.
Previously, changing a file in pkg/analyzer would not force a rebuild of
the analyzer snapshot, causing confusion during anayzer development.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1781473002 .
2016-03-08 14:04:21 -08:00
Konstantin Shcheglov 5b117e9e18 Use the fact that some index lists are sorted.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1776143002 .
2016-03-08 13:43:43 -08:00
Konstantin Shcheglov 3af20476d1 Add AnalysisContext.onResultInvalidated(descriptor).
This method will be used to remove index entries corresponding to
invalidated resolved units.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1776023002 .
2016-03-08 12:55:06 -08:00
Konstantin Shcheglov 15bfead120 Sort strings in the index.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1774253002 .
2016-03-08 12:45:29 -08:00
Paul Berry c497c026fe Fix summary generation in "package-summary-only" mode.
If we aren't doing full analysis, then we can't use
`context.librarySources` to find out the set of library sources (because
it doesn't include sources that haven't been examined yet).  Instead, we
have to query each source to find out its type.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1770323003 .
2016-03-08 12:14:11 -08:00
Ryan Macnak a0e3bfdd68 Qualify the precompiled shared library name with the snapshot directory instead of using LD_LIBRARY_PATH.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1771423002 .
2016-03-08 12:01:53 -08:00
Bob Nystrom cb7aa02116 Type check for-in statements.
This does nominal checking on the iterable expression used in a for-in
statement:

1. It must implement Iterable.
2. The type argument to Iterable must be assignable to the variable's
   type.

R=brianwilkerson@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/1771153002 .
2016-03-08 11:25:49 -08:00
Stephen Adams ea480cdf0f Fix typo in TypeInformationSystem.joinTypeMasks
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1771253002 .
2016-03-08 10:55:15 -08:00
Matthias Hausner ab7eb43013 Make LineSplitter much faster for common case
Avoiding the sync* function in the common case makes LineSplitter
50-100 times faster.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1775683002 .
2016-03-08 10:49:18 -08:00
Paul Berry 1f8ea5448e Add an analyzer_cli option to disable analysis (for faster summary generation)
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1772923002 .
2016-03-08 09:25:20 -08:00
William Hesse 301e527e6e Update status for html/websql_test
BUG=https://github.com/dart-lang/sdk/issues/25927
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1775883002 .
2016-03-08 17:55:28 +01:00
Brian Wilkerson d8786ac278 Change when enum constant elements are created to fix bug in re-creating ASTs from existing element models
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1771243002 .
2016-03-08 08:45:44 -08:00
Terry Lucas af562187bc Chrome moved clipboardData from Event to ClipboardEvent for security clipboard can only be accessed during a onCut/onCopy/onPaste event.
The polyfill class KeyEvent can no longer access clipboardData without listening for the cut, copy or paste event.

TBR=alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1775923002 .
2016-03-08 05:24:02 -08:00
Asger Feldthaus 7772152fa1 dart2js cps: Keep interceptors in a separate field.
Previously, the "receiver" of an InvokeMethod would be either be the
"Dart receiver" or an interceptor, depending on the calling convention.
Likewise, the argument list was possibly prefixed by the Dart receiver.

Now, the receiver is always the Dart receiver, and the arguments are
the Dart arguments and the interceptor is in a field specific for the
interceptor.

The old way was very inconvenient in the CPS, it has led to several
bugs already, and it's just unintuitive that "receiver" can mean two
very different things.

FunctionDefinition no longer has a thisParameter, but
instead a receiverParameter and an interceptorParameter.  These are
named to correspond exactly with the names used in InvokeMethod.

The concept of 'this' has been removed from the CPS IR to hopefully
avoid confusion between 'Dart this' and 'JS this'.  There is now only
receiver and interceptor, and which one corresponds to the JS 'this'
is irrelevant.

The Tree IR has not changed.  The Tree IR builder is thus responsible
for translating the calling convention into the JS receiver and
argument list.  The Tree needs to know the order in which the operands
are evaluated, so it makes sense to keep this form in the Tree.

R=sra@google.com

Review URL: https://codereview.chromium.org/1761903002 .
2016-03-08 13:43:20 +01:00
Johnni Winther 5719bc4ff3 Add white-listing to sourcemap tests.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1769013002 .
2016-03-08 10:49:01 +01:00
Johnni Winther 7cbfcd69ca Updates from comments.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1683063002 .
2016-03-08 10:36:58 +01:00
Johnni Winther 583fd470d8 Add source location to function declarations.
Temporarily adds source location to function declarations in the new source info system.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1773553002 .
2016-03-08 10:30:13 +01:00
Johnni Winther 7254451244 Add source mappings and inlined Dart code to diff_view.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1752393002 .
2016-03-08 10:02:28 +01:00
Ryan Macnak c6d3ff0098 More MIPS status cleanup.
R=regis@google.com

Review URL: https://codereview.chromium.org/1774693002 .
2016-03-07 16:37:48 -08:00
Terry Lucas 5d77c0e83c More UIEvent attribute movement in 45 roll.
TBR=alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1771113002 .
2016-03-07 16:12:28 -08:00
Ryan Macnak 865b8eedfc Reset limit of map_insert_remove_oom_test and skip on noopt/precompilation.
Increasing the heap limit to allow for the compiled core libraries in noopt/precompilation requires increasing the iteration count to make the test meaningful, but this also makes it too slow on simarm64, etc.

Cf. baf4d84f34

BUG=http://dartbug.com/24678
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1772963002 .
2016-03-07 14:23:19 -08:00
pq 24ac0d4e2d Fix cycle in override check.
BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1769253002 .
2016-03-07 14:09:58 -08:00
Konstantin Shcheglov b9ee5c20eb Implement SearchEngine.searchMemberReferences().
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1768353002 .
2016-03-07 13:41:12 -08:00
pq 4528052e98 Validation of @mustCallSuper overrides.
Carried over and refined from https://codereview.chromium.org/1767843002/.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1773803002 .
2016-03-07 13:37:35 -08:00
Alan Knight 16cbd86998 websql_test/functional shouldn't be suppressed on ie11
BUG=

Review URL: https://codereview.chromium.org/1770143002 .
2016-03-07 13:07:36 -08:00
Sigmund Cherem 43f943245e Update status files: websql_test seems to pass in ie10, many failures seem to be
timeouts in windows, a couple new runtime-error failures in safari.

BUG=

Review URL: https://codereview.chromium.org/1775593002 .
2016-03-07 12:41:14 -08:00
Ryan Macnak 46fea6cfb2 Update status file for some passing tests on MIPS and ARM.
R=regis@google.com

Review URL: https://codereview.chromium.org/1774613002 .
2016-03-07 12:17:27 -08:00
Regis Crelier cb0f9e98ea Fix typo in newly introduced mips assembly tests.
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1767133002 .
2016-03-07 11:34:46 -08:00
Konstantin Shcheglov f2111c2497 Search for direct and indirect subclasses.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1770083002 .
2016-03-07 11:30:44 -08:00
Ryan Macnak baf4d84f34 Increase max heap size in map_insert_remove_oom_test to handle compiled core libraries in --noopt and -cprecompiler -rdart_precompiled.
BUG=http://dartbug.com/24678
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1773593006 .
2016-03-07 11:29:32 -08:00
Konstantin Shcheglov 2293a22b7f Implement searchMemberDeclarations() / searchTopLevelDeclarations().
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1770953002 .
2016-03-07 11:14:05 -08:00
Brian Wilkerson 687119c56d Prepare to publish a new alpha version for DDC
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1768303002 .
2016-03-07 11:01:25 -08:00
Konstantin Shcheglov 5f62cca534 Record IS_ANCESTOR_OF relations.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1772823002 .
2016-03-07 11:00:49 -08:00
Leaf Petersen 6a9af860d0 Fix method inference crasher.
During class member inference, only instantiate the type formals of
an overridden method when there are type formals to instantiate.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1763013003 .
2016-03-07 10:49:57 -08:00
Konstantin Shcheglov 8dbbb55a2e Implement search for names defined in index.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1771903002 .
2016-03-07 10:40:01 -08:00
Brian Wilkerson 508492d048 Fixes to associating existing elements with an AST
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1768713002 .
2016-03-07 10:36:36 -08:00
Sigmund Cherem 385f3350c5 Update status of cpsir tests in checked mode: skipping for now, since more than
75% fail for one reason, once we fix that we can triage in more detail.

Review URL: https://codereview.chromium.org/1771893002 .
2016-03-07 10:20:41 -08:00
Alan Knight 28980c19fc WebSQL functional test should be suppressed everywhere on dart2js, not just chrome
BUG=

Review URL: https://codereview.chromium.org/1769113002 .
2016-03-07 10:06:04 -08:00
Konstantin Shcheglov 28f8a64210 Remove SearchEngine.searchElementDeclarations().
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1769063002 .
2016-03-07 09:57:15 -08:00
Terry Lucas b1faa37d2a Removed whitelisted failures now fixed
TBR=whesse@google.com

Review URL: https://codereview.chromium.org/1771863003 .
2016-03-07 09:39:37 -08:00
pq f506639391 Back out ignore quick-fix.
As per, https://github.com/dart-lang/sdk/issues/25926, we'll migrate this behavior to the IDE side.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1770733002 .
2016-03-07 09:25:28 -08:00
Ryan Macnak e880063e88 Include the canonical static closure when serializing ClosureData.
BUG=http://dartbug.com/25892
R=asiva@google.com

Review URL: https://codereview.chromium.org/1771483002 .
2016-03-07 09:06:26 -08:00
William Hesse f5d284ca9c Update status for a slow test and a crashing test.
BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/1768193002 .
2016-03-07 17:59:16 +01:00
Florian Schneider 2148815673 Add fast path smi comparison operators.
Only rudimentary support for now, gives around 15% speedup on richards, precompiled.

Branch-merging is not yet supported in this CL.

BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/1773633002 .
2016-03-07 08:55:43 -08:00
Florian Loitsch d41bce8cda Don't assume that we always have a HowToFix and remove failing test.
Also fix a typo.

Review URL: https://codereview.chromium.org/1769043002 .
2016-03-07 17:36:34 +01:00
Konstantin Shcheglov 9f448d00fe Support for searching of libraries, import prefixes and import elements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1767113002 .
2016-03-07 08:34:34 -08:00
Terry Lucas 5c3728b067 Fix for KeyEvent,KeyboardEvent and UIEvent changes in roll 45
TBR=jacobr@google.com,alanknight@google.com,sigmund@google.com

Review URL: https://codereview.chromium.org/1754523006 .
2016-03-07 07:51:50 -08:00
Florian Loitsch dd326beee1 Move more messages.
Migrates some of the 'undefined' messages to the shared file.

R=brianwilkerson@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org/1750143005 .
2016-03-07 16:39:12 +01:00
Florian Loitsch 65b4256b9e Support multiple categories per message.
Also move more messages to use this feature.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1763373002 .
2016-03-07 16:37:57 +01:00