It seems safe to assume that <math.h> works on all supported platforms
now.
Change-Id: Iffb6618f6035c8cc10657c55ccc3ca7cd5d9525c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107825
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Matthew Dempsky <mdempsky@google.com>
This is a reland of b71d2d9996
Original change's description:
> [llvm] Add initial scaffolding
>
> This change adds the gclient and GN changes needed to build
> an executable using LLVM in the Dart tree as well as a basic
> testing framework based on llvm-lit.
>
> Change-Id: I9009a98ff95043cc3754966f31697ba7f1712310
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106434
> Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Change-Id: Ib3cd3299ed463133616c666285f9a58fa387b5bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107829
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Jake Ehrlich <jakehehrlich@google.com>
In observatory, "Break <function name>" will add a breakpoint at the beginning of function. But it will reject if <function name> is an async function, as it is not debuggable.
Add checks for async function will allow breakpoint to set. Once async_op is compiled, breakpoint will be resolved correctly.
Bug: https://github.com/dart-lang/sdk/issues/28561
Change-Id: I37cf6a05c54b6a0062845926f4f3b85557dcc52a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107522
Commit-Queue: Zichang Guo <zichangguo@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
This updates NodeBuilder so that when it visits a method declaration,
it does not count any parameters defined in body statements
as part of the parameters defined in the method signature.
Change-Id: I4da3989eb2bc65c422d94fa264885910850b0ed2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107921
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
A number of corner cases still need to be addressed, and I need to
generalize the logic to work for `??` expressions.
Change-Id: I6998058698c8b293f7d7b99f3c231a9173b9ff58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107901
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
verified_memory.{cc,h} were removed in 2016 (commit 006bab2c), but
this file was accidentally left behind.
Change-Id: I7aca921ab402bc3ca8ee621be088f9a852d09eb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107828
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Matthew Dempsky <mdempsky@google.com>
Google has required MSVC 2013 since Q2 2015, and Chromium has required
MSVC 2015 since Dec 2016. It seems safe for Dart to assume MSVC 2013.
Change-Id: I2ad2549d70b0a96085aa96e90ef15ad4c7b7acb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107062
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Matthew Dempsky <mdempsky@google.com>
This CL takes https://dart-review.googlesource.com/c/sdk/+/107740
and add the following condition so that all the current tests pass.
if (positionalParameters.length <= positionalParameterCount) {
// TODO(danrubel): Track down why this happens
// and remove this if statement
} else {
...
My next task is to track down and fix the underlying issue
then remove the temporary code above from the asserts.
Change-Id: I683beac46835ed7b8c1a7b856804db84a74142f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107860
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
This CL updates creation of DecoratedType to ensure that the return type
is set if the DecoratedType's type is FunctionType.
Change-Id: I9fd031693f5fd07ea5f0e6e16723b7c9659410ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107702
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
It will not happen strictly before, it happens together, because we
set _FunctionElementForLink_Initializer for fields, which will perform
field type inference when requested.
Found this while running over google3.
R=brianwilkerson@google.com, paulberry@google.com
Change-Id: I360dff7e815ba997680c4a719a3e82827368db42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107780
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
We now wrap named argument types in `{}` and optional positional
argument types in `[]`.
A few unit tests have been added to verify this functionality; I
didn't exhaustively test the implementation of DecoratedType though.
Change-Id: I1e3135adc3abc966f8a41d90c1c6e95e9c7c1eda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107747
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Correspondingly, I moved tests for definite assigned from unit-like
tests to the corresponding error reporting tests suite.
R=brianwilkerson@google.com, paulberry@google.com
Change-Id: I6d286a8b5335e88fe9f7376ed3c829a1e5c39019
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107561
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Two methods had names beginning with "visit", to reflect the name of
the visitor method they tested. But this was inconsistent with the
rest of the methods in EdgeBuilderTest, which are simply named after
the structure whose visitor method they test.
Change-Id: I4616eeff959f4ef84fc8a5da3263ab9c88d8fba2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107742
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
We can tell whether a decorated type needs to be created based on
whether the library is being migrated.
Change-Id: I440c9a310ad103c800de6409d717492bc539b838
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107660
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
