Commit graph

47132 commits

Author SHA1 Message Date
Ryan Macnak 14ec8fa979 Use assembly instead of C array literals to link the core snapshot into the VM.
Allows for including instructions.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2901163002 .
2017-05-24 14:38:15 -07:00
Dan Rubel 136698a734 remove fasta <--> analyzer token translation
R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2902813005 .
2017-05-24 17:34:08 -04:00
Zachary Anderson 58c0cacefb Remove unused <sys/syscall.h> inclusion on Fuchsia
Fuchsia doesn't specify its syscall interface in this header. In fact,
the header is empty, and we will soon remove it. So don't include it.

R=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2904963002 .
2017-05-24 14:23:16 -07:00
Dan Rubel dff793d05f update lazy assignment operators
and remove scanLazyAssignmentOperators flag

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2903063003 .
2017-05-24 17:05:02 -04:00
Sigmund Cherem 80942f15cf add _CompileTimeError error to dart2js patch
See https://github.com/dart-lang/sdk/issues/29661 for context

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2901323002 .
2017-05-24 13:52:32 -07:00
Vijay Menon 2187f5232d DDC cleanup
R=jacobr@google.com, jakemac@google.com

Review-Url: https://codereview.chromium.org/2902103005 .
2017-05-24 13:01:10 -07:00
Alan Knight b4b02daade Include DDC fixes to dart:html in the main version
BUG=
R=jacobr@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2899173002 .
2017-05-24 12:49:13 -07:00
Alan Knight d60efa87fe Remove obsolete test in svgelement_test
BUG=

Review-Url: https://codereview.chromium.org/2902973004 .
2017-05-24 12:29:15 -07:00
Zachary Anderson f6ca2fc63a [Fuchsia] Fix arm64 build
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2897173006 .
2017-05-24 12:12:49 -07:00
Vijay Menon 5919a12038 Library root fix for win
R=jakemac@google.com

Jacob: do we need a fix in jsDebuggingLibraryName too?  could that code be refactored - it looks like it duplicates a lot of logic.
Review-Url: https://codereview.chromium.org/2899363002 .
2017-05-24 12:10:47 -07:00
Ryan Macnak 93864c0db9 Revert "Shuffle around deopt id allocation to give the flow graph builder a chance to record other data as they are allocated."
This reverts commit c94bebf289.

Review-Url: https://codereview.chromium.org/2904733003 .
2017-05-24 11:55:56 -07:00
Paul Berry a21b9e5638 Remove AstFactory from the front end.
R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2904673003 .
2017-05-24 11:28:12 -07:00
Sigmund Cherem 9fd47a08d1 Address follow up comments
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2902643002 .
2017-05-24 11:20:40 -07:00
Paul Berry 11fbbea7a7 Create language test that exercises bug #29709.
R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2903033002 .
2017-05-24 11:20:07 -07:00
Sigmund Cherem 5f8bc4feb2 fasta: revert check for null fileUri in the error reporting of the verifier.
(as discussed in https://codereview.chromium.org/2894283002, we are reverting
this because we don't know how to reproduce this issue anymore. When it comes up
again we can either fix the issue or re-revert and include an explanation).

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2902153003 .
2017-05-24 11:17:15 -07:00
Dan Rubel 6e981d0cbf enable analyzer scanner adapter generic method support
This turns on generic method support in the scanner adapter layer
and updates the token.offset when the analyzer scanner
is being used to parse generic method comments.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2900963009 .
2017-05-24 13:37:52 -04:00
Zachary Anderson 61300d19c6 [dart:io] Re-limit the number of IO Service ports per Isolate
Previous change removed the limit, but this causes too many
threads to be spawned at the same time on Windows, which
crashes the VM. This change restores the limit, but continues
use of the free-list approach, which still avoids the blocking
problem fixed by the previous change.

fixes #29702

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2903013002 .
2017-05-24 10:22:26 -07:00
Jacob Richman a0414390f9 Properly link building dev compiler tools to create_full_sdk.
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2900833002 .
2017-05-24 10:00:00 -07:00
Paul Berry 6b100c007b Use declared return type for inference of return and yield statements.
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2899073004 .
2017-05-24 09:28:26 -07:00
Florian Loitsch e9e9835afc Add a changelog entry for the function-type syntax.
Fixes #27527
BUG= http://dartbug.com/27527
R=leafp@google.com

Review-Url: https://codereview.chromium.org/2906453002 .
2017-05-24 18:23:06 +02:00
Terry Lucas 03688818fa Need to regen cached_patches; new class exposed.
TBR=alanknight@google.com,keerti@google.com

Review-Url: https://codereview.chromium.org/2899233004 .
2017-05-24 09:22:52 -07:00
Vijay Menon 991315ae87 Reapply convert fixes for dart2js
BUG=
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2906443002 .
2017-05-24 08:34:19 -07:00
Paul Berry b9b949f436 Use FutureOr as the return context in async closures.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2898373004 .
2017-05-24 08:24:13 -07:00
Vijay Menon 6402ad477d Use the dart2js patch for dart:convert to get latest type fixes
BUG=
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2896253003 .
2017-05-24 07:33:19 -07:00
Florian Loitsch 46a6fab347 Reformat generated tests files.
Review-Url: https://codereview.chromium.org/2904563005 .
2017-05-24 16:29:32 +02:00
Peter von der Ahé ddf5fc23f1 Improve analysis coverage.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2904483002 .
2017-05-24 15:52:42 +02:00
Paul Berry e642722f42 Implement subtyping rules for FutureOr in kernel.
These rules are only enabled when in strong mode, so existing Dart 1.0
functionality should be unaffected.

R=kmillikin@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2900113002 .
2017-05-24 06:14:22 -07:00
Peter von der Ahé 61d855bb47 Prepare for development branch by updating externally-used API.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2898183002 .
2017-05-24 14:32:45 +02:00
William Hesse 2a0dd9d43c Update status for passing analyzer test.
This test started passing with
1cfb242321
https://codereview.chromium.org/2901853002

Also removed comments in status file, and placed issue number comments
on the test status lines.

BUG=dartbug.com/14879
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2902943003 .
2017-05-24 13:52:41 +02:00
Peter von der Ahé 7065a8dfd4 Update kernel status file.
Review-Url: https://codereview.chromium.org/2898173003 .
2017-05-24 13:42:05 +02:00
William Hesse b2e445c13a Add missing comma to DEPS file
This fixes an error in commit
0fa3c6e179
https://codereview.chromium.org/2901773005

TBR=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2897173004 .
2017-05-24 12:18:41 +02:00
Peter von der Ahé 9ed1ba2c12 Temporarily uncomment logEvent to make build bot green.
Review-Url: https://codereview.chromium.org/2901273002 .
2017-05-24 12:04:19 +02:00
Johnni Winther 99538b2c13 Pull the member context from the current target
- the variable might be erroneous.

Review-Url: https://codereview.chromium.org/2901103003 .
2017-05-24 11:55:37 +02:00
Peter von der Ahé f5012090f9 New parser event needed to check case expressions.
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2900993002 .
2017-05-24 11:48:42 +02:00
Peter von der Ahé 1cfb242321 Improve various old tests.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2901853002 .
2017-05-24 11:46:08 +02:00
Peter von der Ahé b6a78795e4 Fix various semantic nits that Fasta will detect.
R=johnniwinther@google.com, paulberry@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2897003003 .
2017-05-24 11:43:18 +02:00
Johnni Winther 7eec91c3bf Pass context class directly to KernelSsaBuilder
Review-Url: https://codereview.chromium.org/2899273002 .
2017-05-24 11:41:54 +02:00
William Hesse 0fa3c6e179 Update Dartium source with build fix for MacOS
BUG=

Review-Url: https://codereview.chromium.org/2901773005 .
2017-05-24 11:20:59 +02:00
Peter von der Ahé 9eb265439f Ensure DART_CONFIGURATION is exported and don't run code in checked mode.
R=paulberry@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2903593002 .
2017-05-24 11:20:45 +02:00
Peter von der Ahé e6a7a38022 Support being called as absolute path.
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2896033002 .
2017-05-24 11:07:53 +02:00
Johnni Winther ac07b3ce03 Type .targetElement as MemberEntity
+ decouple LocalsHandler from ExecutableElement

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2901823002 .
2017-05-24 10:23:33 +02:00
Johnni Winther a932d7fd51 Use KernelToElementMap (more) directly in KernelSsaBuilder
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2904493002 .
2017-05-24 10:18:48 +02:00
Johnni Winther ccc6c484b3 Create KernelSsaBuilder from KernelSsaBuilderTask
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2899983003 .
2017-05-24 10:12:20 +02:00
Johnni Winther b767ebaa71 Create SsaBuilderTask stub for KernelBackendStrategy
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2896853002 .
2017-05-24 10:04:32 +02:00
Johnni Winther f8dc775b44 Share more logic between the Ssa(Ast)Builder and SsaKernelBuilder
This is a preparational step towards generating SSA from kernel based elements.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2893293002 .
2017-05-24 09:59:20 +02:00
Erik Ernst 8aef60a78f Included setters in testing of the void => return-any-type feature.
The older issue https://github.com/dart-lang/sdk/issues/28939 did not
mention setters. They were already covered in the implementation, so
this CL just adds testing for it.

Addresses issue https://github.com/dart-lang/sdk/issues/29680.

R=floitsch@google.com, johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2899683003 .
2017-05-24 09:36:48 +02:00
Zachary Anderson 3310e0cebd [dart:io] Remove collisions from IO Service port dispatch
This change prevents IO Service requests from colliding on the same
IO Service port. If requests can collide, a request that could otherwise
be serviced immediately can become blocked on a request that is blocked.

To avoid collisions, this change maintains a free list of IO Service
ports. If the free list is empty, we allocate a new IO Service port.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2903593004 .
2017-05-23 23:58:07 -07:00
Zachary Anderson 935df723f0 [Fuchsia] Really remove dead GN flag
Missed this in previous commit.

Review-Url: https://codereview.chromium.org/2902083002 .
2017-05-23 22:18:39 -07:00
Zachary Anderson 7f16342577 [Fuchsia] Fix test image creation
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2897123002 .
2017-05-23 22:14:57 -07:00
Stephen Adams a545c5c31f Use failedAt in more places (constants, universe)
TBR=sigmund@google.com

BUG=

Review-Url: https://codereview.chromium.org/2900263002 .
2017-05-23 19:23:32 -07:00