languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-16 01:13:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
41851 commits 11 branches 6011 tags 1.4 GiB
Commit graph

41851 commits

This branch
This branch
All branches
Author SHA1 Message Date
Paul Berry 148af481ff Fix DeclarationResolver handling of annotations containing closures. 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2436733004 .
 2016-10-19 13:23:11 -07:00
Paul Berry d631a142a4 Create a README and pubspec for the front_end package. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2436733003 .
 2016-10-19 12:14:38 -07:00
Paul Berry 4054d93fc9 Handle default formal parameters in LocalElementBuilder 
Fixes #27615.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/2437793002 .
 2016-10-19 11:17:43 -07:00
Konstantin Shcheglov 38e2b55fff Implement 'local' mode in TypeResolverVisitor. 
If we start resolution not from CompilationUnit, we need to put type
parameters into scopes. This is not implemented yet.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2432273003 .
 2016-10-19 09:47:40 -07:00
Ryan Macnak 5ee94eb837 Generate an app snapshot even if the training run does a hard exit. 
(As the analyzer and pub do.)

R=asiva@google.com

Review URL: https://codereview.chromium.org/2426843002 .
 2016-10-19 09:37:47 -07:00
Zachary Anderson 8a909671e6 Fix Double.pow() for arm and mips 
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2433933003 .
 2016-10-19 09:01:55 -07:00
William Hesse cdfe272b37 Update status for chrome on macos co19 tests. 
BUG=

Review URL: https://codereview.chromium.org/2434773002 .
 2016-10-19 14:27:27 +02:00
Zachary Anderson 088347fd9d Reland "Add DoubleTestOp instruction" 
Fixes DoubteTestOpInstr::AttributesEqual()

Review URL: https://codereview.chromium.org/2433813002 .
 2016-10-18 22:46:36 -07:00
Zachary Anderson f6296cc91b Revert "Add DoubleTestOp instruction" 
Review URL: https://codereview.chromium.org/2432903002 .
 2016-10-18 21:57:05 -07:00
Zachary Anderson fa855cf1c2 Add DoubleTestOp instruction 
This gives a ~5% bump to the Flutter layout benchmark
in checked mode.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2423843002 .
 2016-10-18 21:24:12 -07:00
Stephen Adams 5a646b7827 Property extraction getters (tear-offs) are effect-free 
This mostly allows better scheduling of the surrounding instructions.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2430683003 .
 2016-10-18 20:13:26 -07:00
Konstantin Shcheglov b64e116422 Add TypeResolverMode and implement 'api' in TypeResolverVisitor. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2428233002 .
 2016-10-18 19:31:14 -07:00
Brian Wilkerson d378dfcff8 Fix error codes (issue 27608) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2430873002 .
 2016-10-18 17:30:04 -07:00
Florian Schneider 197d56d853 VM: Fix another dead-lock in background compiler. 
Grabbing the lock must always take safepoints into account.

Observed as a flaky timeout on standalone/http_launch_test.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2426213002 .
 2016-10-18 16:53:10 -07:00
Jacob Richman 4f6ce11bc8 Emulate compiling a source file in the context of an existing library. Add --debugger-compile flag that performs permissive dynamic calls on private members. Polish web_command.dart adding the ability to evaluate code in the context of an existing library. 
BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org/2423313002 .
 2016-10-18 16:34:48 -07:00
Nicholas Shahan 3f67c24cb8 Revert "Fix library name insert and access inconsistency on windows" 
This reverts commit d8505ee264.

It was found to cause issues in the web file system when one file
was found to be within a root path.

R=jacobr@google.com

Review URL: https://codereview.chromium.org/2432603002 .
 2016-10-18 16:25:03 -07:00
Jennifer Messerly 7b5e6be4a8 fix #27284, allow FutureUnionType to be preserved during generic inference 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2425143002 .
 2016-10-18 15:55:27 -07:00
Konstantin Shcheglov 412cceb7d0 Add tests showing using LocalElementBuilder separately, for variable or body. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2428773004 .
 2016-10-18 14:38:06 -07:00
Paul Berry 8fca9ba968 First cut at a file system abstraction for the front end. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2426773004 .
 2016-10-18 14:10:14 -07:00
Konstantin Shcheglov 19702989a8 Get rid of _inFunction in ApiElementBuilder. 
This visitor does not enter into function bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2430513004 .
 2016-10-18 14:03:42 -07:00
Florian Schneider 7e6d8f5b66 VM: Remove unnecesary load of isolate in some stubs. 
The fast-path allocation can always load the current heap
from the thread object instead.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2427043002 .
 2016-10-18 13:45:53 -07:00
Paul Berry 8c42e56964 Add "not intended to be implemented/extended" warnings to pkg/front_end. 
This ensures that we may safely add methods to the classes in this
package without causing a breaking change.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2431733002 .
 2016-10-18 13:31:40 -07:00
Zachary Anderson aa79ee775e DBC: Fix intrinsics bug 
Fall-through when allocation fails.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2429723003 .
 2016-10-18 13:07:19 -07:00
Sigmund Cherem 3cdcaeda96 Fix browser test status. 
This is to match the state of the bots, it appears that chrome was recently upgraded.

BUG=

Review URL: https://chromiumcodereview-hr.appspot.com/2426093002 .

Committed: 940e498e17
 2016-10-18 12:50:58 -07:00
Sigmund Cherem 2200ee77f7 Revert "Fix browser test status." 
This reverts commit 940e498e17.
 2016-10-18 12:48:15 -07:00
Sigmund Cherem 940e498e17 Fix browser test status. 
This is to match the state of the bots, it appears that chrome was recently upgraded.

BUG=

Review URL: https://chromiumcodereview-hr.appspot.com/2426093002 .
 2016-10-18 12:38:45 -07:00
Konstantin Shcheglov 529ebf7be2 Add (shared) tests for ApiElementBuilder and ElementBuilder. 
Also copy API-only tests from the old CL.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2431783002 .
 2016-10-18 12:28:09 -07:00
Brian Wilkerson 0464279ec1 More correction messages 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2428733005 .
 2016-10-18 12:22:17 -07:00
Konstantin Shcheglov 13d2420a3d Extract ElementBuilder tests into a separate file. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2430723002 .
 2016-10-18 10:22:45 -07:00
Zach Anderson df260e5fe7 Fix crashes on debug windows 
Review URL: https://codereview.chromium.org/2426053002 .
 2016-10-18 09:37:04 -07:00
Konstantin Shcheglov e1f8a0a103 Begin separating API and local element builders. 
I will write separate tests for them and do some more clean up in
separate CLs.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2425853003 .
 2016-10-18 08:22:30 -07:00
Johnni Winther b262be749e Optimize needNoSuchMethodHandling computation 
This greatly improves the number of lookups needed to establish the relation.
For the two most prolific tests we have:

html/element_test: 44939 -> 6557
html/mirrors_js_typed_interop_test (mirrors+jsinterop!): 1638455 -> 171326

R=sigmund@google.com

Committed: a8b2bfb5eb

Review URL: https://codereview.chromium.org/2428543002 .

Reverted: 5397c5427e
 2016-10-18 16:06:03 +02:00
Johnni Winther 37afcd5197 Change TypeInference to handle super calls as direct invocations. 
This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Committed: 70159b7418

Review URL: https://codereview.chromium.org/2423953002 .

Reverted: 5397c5427e
 2016-10-18 14:02:55 +02:00
Erik Ernst b5d2b38aa3 Relaxes treatment of method type parameter in as expressions. 
This CL changes the semantics of `dart2js --generic-method-syntax`
generated code for `e as T` where `T` is a method type parameter.

The old behavior was to raise a `TypeError` at runtime when such an
expression was evaluated. The new behavior is to consider `T` as an
alias for `dynamic`, i.e., `e as T` will then always succeed.

Addresses part of issue 27460, omits a part that is not yet agreed upon.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2388843002 .
 2016-10-18 11:11:44 +02:00
Johnni Winther 5397c5427e Revert "Change TypeInference to handle super calls as direct invocations." and "Optimize needNoSuchMethodHandling computation" 
This reverts commit 70159b7418.
This reverts commit a8b2bfb5eb.

Review URL: https://codereview.chromium.org/2425933002 .
 2016-10-18 11:00:42 +02:00
Johnni Winther a8b2bfb5eb Optimize needNoSuchMethodHandling computation 
This greatly improves the number of lookups needed to establish the relation.
For the two most prolific tests we have:

html/element_test: 44939 -> 6557
html/mirrors_js_typed_interop_test (mirrors+jsinterop!): 1638455 -> 171326

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2428543002 .
 2016-10-18 10:52:12 +02:00
Johnni Winther 70159b7418 Change TypeInference to handle super calls as direct invocations. 
This also makes calls of known target registered as static uses and thus
removes the need for misusing type masks to select super methods.

Closes #25716

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2423953002 .
 2016-10-18 09:46:28 +02:00
Siva Annamalai bcea09162a Land https://codereview.chromium.org/2423893003/ for viettrungluu 
TBR=zra

Review URL: https://codereview.chromium.org/2426833002 .
 2016-10-17 16:57:02 -07:00
Vijay Menon a032a4c952 Revert "Fix file name handling on windows" 
This appears to break on bazel.

BUG=
R=nshahan@google.com

Review URL: https://codereview.chromium.org/2422403002 .
 2016-10-17 15:27:48 -07:00
Konstantin Shcheglov fabb9dbf18 Remove _functionTypesToFix from ElementBuilder. 
We might have needed it in the past, but now
'new FunctionTypeImpl(element)' does not use the enclosing element, at
least until we start calling its methods, which happens after we finish
building the element model.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2422333002 .
 2016-10-17 14:26:38 -07:00
Stephen Adams c9c3c203c1 Minor tweaks to dart:html for better dart2js codegen 
- Allow 'document' to be reused (GVN-ed).
- Allow inlining of 'new Comment'.
- 'new Text' and 'new Comment' have no effects.

BUG=
R=alanknight@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/2422293002 .
 2016-10-17 13:35:17 -07:00
Zach Anderson 71a84cfed6 GN: Fix Debug flags. Fix Windows build. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2425043002 .
 2016-10-17 12:58:24 -07:00
Brian Wilkerson 99ce88f8bc (TBR) Fix more failing tests 
Review URL: https://codereview.chromium.org/2426723002 .
 2016-10-17 12:57:56 -07:00
Paul Berry 0753607dea Initial API for the Dart front_end package. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2417043003 .
 2016-10-17 12:36:08 -07:00
Brian Wilkerson 3121296942 (TBR) Fix failing tests 
Review URL: https://codereview.chromium.org/2426703002 .
 2016-10-17 11:55:31 -07:00
John McCutchan 8061bd5a8a Add local variable declaration token position to service protocol 
- [x] Add three public fields to the "BoundVariable" service type: declarationTokenPos, visibleStartTokenPos, and visibleEndTokenPos. (naming suggestions welcome!)
- [x] Extend LocalVarDescriptors to hold the declaration token position (it already had the scope visibility boundaries).
- [x] Extend ContextScope to hold the declaration token position.
- [x] Add a unit test which verifies this works for local variables, function parameters, and closure captured variables.

Fixes https://github.com/dart-lang/sdk/issues/25569

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2419013004 .
 2016-10-17 11:18:24 -07:00
Brian Wilkerson 724ac40b8d Improve error messages and add many corrections 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2426583003 .
 2016-10-17 10:40:43 -07:00
Zachary Anderson c8970d0524 DBC: Fix CheckClass bug. Add some intrinsics 
Flutter layout benchmark 8.5k us -> 6k us.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2418073002 .
 2016-10-17 10:20:56 -07:00
Brian Wilkerson cbd7a2908e Fixes for tests on windows 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2420413004 .
 2016-10-17 09:39:25 -07:00
Florian Loitsch 8fbd651c49 Emphasize that durations are context independent. 
Fixes #27597
BUG= http://dartbug.com/27597
R=lrn@google.com

Review URL: https://codereview.chromium.org/2423993002 .
 2016-10-17 14:51:00 +02:00