Previously, this behavior was custom-wired into the Dart analyzer, but
now it is specified with TargetKinds.
In the analyzer we remove special annotation-target-verification for
`mustCallSuper`.
Change-Id: Ibd3ada0a612069c5286facffaad557671c7a85b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
By removing unnecessary references to higher level libraries we
can extract a separate 19 libraries cycle, related to errors. Maybe
later we can break it further.
This reduces the mono-cycle from 295 to 270 libraries.
Change-Id: Id9db12002dba10788b65262d3d7325ad6079ceff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This mixes layers, which I believe one of the ways that cause large
library cycles.
Change-Id: Ie1cf991bcd40b19127a6ade7efc5ad5fd69d0018
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368942
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This mixes layers, which I believe one of the ways that cause large
library cycles.
Change-Id: Id7124b9f4e4bf81838f637255fe04fd28f5fda01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
- Don't convert the result to list: we don't need the result as list so
conversion is not necessary.
- Return empty set instead of null when empty: `null` and empty set
represents the same thing, using just one value is simpler for the
downstream as we don't need to check both the null case and whether
the set is empty.
Change-Id: I925e9bd8962eeb91a4a20ab5b7218a27d263bece
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369021
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Ömer Ağacan <omersa@google.com>
This mixes layers, which I believe one of the ways that cause large
library cycles.
Change-Id: Ic21292f2d831229a3ba444abf3131c66ec9968d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
It exports some libraries, but this is for a specific client.
Not to import everywhere in the analyzer :-)
Change-Id: If87435b07e76cc252d3a821e28a7c38d5533fa87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368922
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Original change: https://dart-review.googlesource.com/c/sdk/+/366963
This reverts commit 72b2883c6f.
[js_runtime, js_dev_runtime] Implement `microsecond` field of `DataTime`
- Move DateTime implementation for dart2js and DDC into a shared place to reduce duplication.
- Add a _microsecond field to the web DateTime to track microseconds outside of the JavaScript Date.
- The cute dart2js optimization whereby `DateTime.now().millisecondsSinceEpoch` is compiled to `Date.now()` still works.
- Both implementations report better errors.
- Fixed VM bug with in-range sentinel.
Issue: https://github.com/dart-lang/sdk/issues/44876
Issue: https://github.com/firebase/flutterfire/issues/12102
Issue: b/342552853
CoreLibraryReviewExempt: Reapply of unchanged code
Change-Id: I7f14b69e412a052ef3fe6b43cc9cf9d96319adb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368380
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
`flutter build web --wasm`
* uses the `--(no-)strip-wasm` flag for stripping
* by default it strips the wasm file in `--release` mode
=> We align `dart compile wasm` to use the same flag and have the same
default.
After this CL rolled into flutter, we can make flutter pass the new flag
down and remove the old `--name-section` flag.
Change-Id: I6dc6be86a3a90f14617bc795843b0e54f54fa761
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369062
Reviewed-by: Ömer Ağacan <omersa@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Change-Id: Ib61fea3bec110c0a2c560c965912c51a1c4e22cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368569
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
These were used for lazily computed ClassInfo.repr struct representation. But this is now eagerly computed so implementedBy is no longer used.
Change-Id: Ie8d28b110a1a7d109cc6e759b9cbe69c646829b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368763
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Nate Biggs <natebiggs@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>
We do this by passing a CorrectionProducerContext up each of the
constructors. We can then remove all `configure` methods. This
requires a few changes and allows a few changes:
* Remove ParsedCorrectionProducer. It does not seem to have served a
purpose.
* CorrectionProducerContext no longer needs to be generic.
* Add a public getter for `MultiCorrectionProducer._context`, so that
a multi correction producer can pass along its context to child
correction producers.
* Introduce a `CorrectionProducerContext.instance` dummy variable,
used when we need to check if a correction producer can be applied
in bulk.
* Make `CorrectionProducerContext._node` public, so that it can be
used in factory constructors.
* `BulkFixProcesor.correctionContext()` return type is non-nullable.
* Add a factory constructor for AddMissingParameter, and move the
`configure` logic there.
* Add a factory constructor for ConvertAddAllToSpread, and move the
`configure` logic there. Then make `_isInlineInvocation` and
`_invocation` final.
* Add a factory constructor for ReplaceFinalWithVar, and move the
`configure` logic there. Then make `_removeFinal` and
`_finalKeyword` final.
* Add a factory constructor for ReplaceWithIsEmpty, and move the
`configure` logic there. Then make `fixKind`, `multiFixKind`,
`_binary`, and `_replacement` final.
* Rename `_AddMissingParameter.context` to `_executableParameters`,
and make it final.
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: If0e9bc1cbf5c8e656938bc6cd4eb32a9d4f06b38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Make ARM64 disassembly closer to the standard form.
TEST=ci
Change-Id: I459093abe049835c6597b80c8020566054a12b48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368824
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This allows TypeAnalyzerOperations.getNullabilitySuffix to be removed,
and allows shared code to access nullability suffixes directly as
properties of a type, in the same way that the analyzer does.
Change-Id: I33ab90798b779534b5b0b111ec5137845b32f23b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368443
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
There is no functional change, because all callers were passing `true`.
Change-Id: I59a70e16b543023ee84657cf4e0d7ef3e0d4de8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367420
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This reverts commit 9c5085ec5b.
Reason for revert: b/343654390
Original change's description:
> [deps] rev args, async, benchmark_harness, boolean_selector, collection, dartdoc, markdown, shelf, web, web_socket_channel, webdev
>
> Revisions updated by `dart tools/rev_sdk_deps.dart`.
>
> args (cf90551..b3608bd):
> b3608bd 2024-05-28 Kevin Moore bump lints dep and fix (dart-lang/args#275)
>
> async (77a25d7..f933ddf):
> f933ddf 2024-05-28 Kevin Moore bump lints dep and fix (dart-lang/async#275)
>
> benchmark_harness (accc755..6fa42b0):
> 6fa42b0 2024-05-28 Kevin Moore bump lints dep and fix (dart-lang/benchmark_harness#106)
>
> boolean_selector (2cbd4a6..84467e5):
> 84467e5 2024-05-28 Kevin Moore bump lints dep and fix (dart-lang/boolean_selector#61)
>
> collection (4718398..fe2e800):
> fe2e800 2024-05-28 Kevin Moore bump lints dep and fix (dart-lang/collection#344)
>
> dartdoc (1e1a004..ed97585):
> ed975850 2024-05-28 Sam Rawlins Fix flutter CI with re-internalized snippets tool (dart-lang/dartdoc#3776)
>
> markdown (340c76f..c1013dc):
> c1013dc 2024-05-28 Kevin Moore update lints dependency (dart-lang/markdown#613)
> 7a3b8d6 2024-05-28 Sam Rawlins Bump to 7.2.3 (dart-lang/markdown#612)
>
> shelf (d9f82bf..338962c):
> 338962c 2024-05-28 Kevin Moore update lints dependency (dart-lang/shelf#433)
>
> web (d776645..f6f778b):
> f6f778b 2024-05-28 Kenzie Davisson Expose `onUnload` event stream and `ElementStream` as a public class (dart-lang/web#246)
> e1d5148 2024-05-23 Kevin Moore Update MDN source and doc comments (dart-lang/web#244)
> 53862f1 2024-05-22 Kevin Moore update lints dependency (dart-lang/web#243)
> 7604578 2024-05-21 Srujan Gaddam Only emit APIs that are standards track and not experimental (dart-lang/web#239)
>
> web_socket_channel (45b8ce9..afd1e3c):
> afd1e3c 2024-05-23 Brian Quinlan Remove `--fatal-infos` from `dart pub downgrade` analysis (dart-lang/web_socket_channel#367)
> cb20b71 2024-05-23 Sarah Zakarias Add `topics` to `pubspec.yaml` (dart-lang/web_socket_channel#362)
> 8514229 2024-05-22 Kevin Moore Bump and fix lints (dart-lang/web_socket_channel#366)
>
> webdev (fc32eb6..1bed26a):
> 1bed26ab 2024-05-28 Elliott Brooks Add a reload handler along with a restart handler (dart-lang/webdev#2439)
> 15028c4f 2024-05-24 Elliott Brooks Register a restart handler directly over the VM service connection (dart-lang/webdev#2437)
>
> Change-Id: I4e80ae77b6e74b9cd0b5524b1ba66e0f3de0a14e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368445
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Auto-Submit: Devon Carew <devoncarew@google.com>
Change-Id: Ief02507626fe2ef4e8a92e20872a0fec37ae3b71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368800
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
local_library_contributor is used only in the cider completions and should be alongside the rest of the cider completion code.
Change-Id: Id11ffaf50c59437a58284c6deb8ac406faf7cada
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Unrelated to anything. Done when I was trying something else that didn't
pan out.
Change-Id: Idd8e03fa142d3ec9d373956d3cc6163d828d4314
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368801
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
There is no functional change, because all callers were passing `true`.
Change-Id: I304b0694946565bd765d3fd10fc2a77bda201117
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368501
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
