languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-14 15:57:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove isNonNullableByDefault parameter from isTypeWithoutNullabilityMarker.

Browse source 
There is no functional change, because all callers were passing `true`.

Change-Id: I59a70e16b543023ee84657cf4e0d7ef3e0d4de8e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367420
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This commit is contained in:
Paul Berry 2024-05-30 16:37:47 +00:00 committed by Commit Queue
parent be24c7942e
commit b4a4075d5d
3 changed files with 8 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
View file

@ -505,7 +505,7 @@ class OperationsCfe
@override
NullabilitySuffix getNullabilitySuffix(DartType type) {
if (isTypeWithoutNullabilityMarker(type, isNonNullableByDefault: true)) {
if (isTypeWithoutNullabilityMarker(type)) {
return NullabilitySuffix.none;
} else if (isNullableTypeConstructorApplication(type)) {
return NullabilitySuffix.question;

6
pkg/kernel/lib/src/standard_bounds.dart
View file

@ -355,10 +355,8 @@ mixin StandardBounds {
// DOWN(T1?, T2) = S where S is DOWN(T1, T2)
// DOWN(T1, T2?) = S where S is DOWN(T1, T2)
{
bool type1HasNullabilityMarker =
!isTypeWithoutNullabilityMarker(type1, isNonNullableByDefault: true);
bool type2HasNullabilityMarker =
!isTypeWithoutNullabilityMarker(type2, isNonNullableByDefault: true);
bool type1HasNullabilityMarker = !isTypeWithoutNullabilityMarker(type1);
bool type2HasNullabilityMarker = !isTypeWithoutNullabilityMarker(type2);
if (type1HasNullabilityMarker && !type2HasNullabilityMarker) {
return _getNullabilityAwareStandardLowerBound(
computeTypeWithoutNullabilityMarker(type1,

13
pkg/kernel/lib/type_algebra.dart
View file

@ -2152,15 +2152,12 @@ bool isStructuralParameterTypeWithoutNullabilityMarker(
isNonNullableByDefault: isNonNullableByDefault);
}
bool isTypeWithoutNullabilityMarker(DartType type,
{required bool isNonNullableByDefault}) {
return !type.accept(new _NullabilityMarkerDetector(isNonNullableByDefault));
bool isTypeWithoutNullabilityMarker(DartType type) {
return !type.accept(const _NullabilityMarkerDetector());
}
class _NullabilityMarkerDetector implements DartTypeVisitor<bool> {
final bool isNonNullableByDefault;
const _NullabilityMarkerDetector(this.isNonNullableByDefault);
const _NullabilityMarkerDetector();
@override
bool visitAuxiliaryType(AuxiliaryType node) {
@ -2223,13 +2220,13 @@ class _NullabilityMarkerDetector implements DartTypeVisitor<bool> {
@override
bool visitTypeParameterType(TypeParameterType node) {
return !isTypeParameterTypeWithoutNullabilityMarker(node,
isNonNullableByDefault: isNonNullableByDefault);
isNonNullableByDefault: true);
}
@override
bool visitStructuralParameterType(StructuralParameterType node) {
return !isStructuralParameterTypeWithoutNullabilityMarker(node,
isNonNullableByDefault: isNonNullableByDefault);
isNonNullableByDefault: true);
}
@override