languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:49:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

Revert "[vm/dart2js] Fix language/string/overflow_test.dart"

Browse source 
This reverts commit 6ad3aaf57c.

Reason for revert: Causing timeouts on bots (e.g., https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8846893706998473952/+/u/test_results/new_test_failures__logs_)

Original change's description:
> [vm/dart2js] Fix language/string/overflow_test.dart
>
> Changes the test to concatenate strings indefinitely. This way the test
> makes no assumptions about the amount of available memory, and the
> concatenation result always stays alive.
>
> Closes: https://github.com/dart-lang/sdk/issues/46055
>
> Change-Id: I1a0da68b2ab5cfc00cfe834f0666f6f797a69ec4
> Fixed: 46055
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200460
> Commit-Queue: Daco Harkes <dacoharkes@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,dacoharkes@google.com

Change-Id: I2108723b5f2c746c858cf5d3f9fded09118ce6c5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200532
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
This commit is contained in:
Ben Konyi 2021-05-18 21:24:44 +00:00 committed by commit-bot@chromium.org
parent 8aa6e3fbb5
commit dd18a07c75
2 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/language/string/overflow_test.dart
View file

@ -9,15 +9,13 @@ import "package:expect/expect.dart";
main() {
String a = "a";
for (; a.length < 256 * 1024 * 1024;) a = a + a;
var exception_thrown = false;
try {
while (true) {
a = "$a$a";
}
var concat = "$a$a$a$a$a$a$a$a";
} on OutOfMemoryError catch (exc) {
exception_thrown = true;
}
Expect.isTrue(exception_thrown);
Expect.isTrue(a.startsWith('aaaaa') && a.length > 1024);
}

6
tests/language_2/string/overflow_test.dart
View file

@ -11,15 +11,13 @@ import "package:expect/expect.dart";
main() {
String a = "a";
for (; a.length < 256 * 1024 * 1024;) a = a + a;
var exception_thrown = false;
try {
while (true) {
a = "$a$a";
}
var concat = "$a$a$a$a$a$a$a$a";
} on OutOfMemoryError catch (exc) {
exception_thrown = true;
}
Expect.isTrue(exception_thrown);
Expect.isTrue(a.startsWith('aaaaa') && a.length > 1024);
}