languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 12:24:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[vm/dart2js] Fix language/string/overflow_test.dart

Browse source 
Changes the test to concatenate strings indefinitely. This way the test
makes no assumptions about the amount of available memory, and the
concatenation result always stays alive.

Closes: https://github.com/dart-lang/sdk/issues/46055

Change-Id: I1a0da68b2ab5cfc00cfe834f0666f6f797a69ec4
Fixed: 46055
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200460
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Daco Harkes 2021-05-18 12:41:43 +00:00 committed by commit-bot@chromium.org
parent a0865fad28
commit 6ad3aaf57c
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/language/string/overflow_test.dart
View file

@ -9,13 +9,15 @@ import "package:expect/expect.dart";
main() {
String a = "a";
for (; a.length < 256 * 1024 * 1024;) a = a + a;
var exception_thrown = false;
try {
var concat = "$a$a$a$a$a$a$a$a";
while (true) {
a = "$a$a";
}
} on OutOfMemoryError catch (exc) {
exception_thrown = true;
}
Expect.isTrue(exception_thrown);
Expect.isTrue(a.startsWith('aaaaa') && a.length > 1024);
}

6
tests/language_2/string/overflow_test.dart
View file

@ -11,13 +11,15 @@ import "package:expect/expect.dart";
main() {
String a = "a";
for (; a.length < 256 * 1024 * 1024;) a = a + a;
var exception_thrown = false;
try {
var concat = "$a$a$a$a$a$a$a$a";
while (true) {
a = "$a$a";
}
} on OutOfMemoryError catch (exc) {
exception_thrown = true;
}
Expect.isTrue(exception_thrown);
Expect.isTrue(a.startsWith('aaaaa') && a.length > 1024);
}