mirror of
https://github.com/dart-lang/sdk
synced 2024-09-15 22:51:29 +00:00
[vm] Remove warnings about non-standard stack traces.
The language team has clarified in https://github.com/dart-lang/language/issues/1212 that the content of stack traces is not specified in a way that is violated by either obfuscation or non-symbolic stack traces. Thus, we remove the warnings about supposedly standard-violating stack traces. TEST=No change in actual functionality, so tested manually. Bug: https://github.com/dart-lang/sdk/issues/43388 Change-Id: I2c7ac44cf2f9afafa85d902b2783e1173e727264 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249185 Commit-Queue: Tess Strickland <sstrickl@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
This commit is contained in:
parent
707ade91c9
commit
cc9d14d822
|
@ -1739,13 +1739,6 @@ Isolate::Isolate(IsolateGroup* isolate_group,
|
||||||
// how the vm_tag (kEmbedderTagId) can be set, these tags need to
|
// how the vm_tag (kEmbedderTagId) can be set, these tags need to
|
||||||
// move to the OSThread structure.
|
// move to the OSThread structure.
|
||||||
set_user_tag(UserTags::kDefaultUserTag);
|
set_user_tag(UserTags::kDefaultUserTag);
|
||||||
|
|
||||||
if (group()->obfuscate()) {
|
|
||||||
OS::PrintErr(
|
|
||||||
"Warning: This VM has been configured to obfuscate symbol information "
|
|
||||||
"which violates the Dart standard.\n"
|
|
||||||
" See dartbug.com/30524 for more information.\n");
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#undef REUSABLE_HANDLE_SCOPE_INIT
|
#undef REUSABLE_HANDLE_SCOPE_INIT
|
||||||
|
|
|
@ -25878,12 +25878,6 @@ const char* StackTrace::ToCString() const {
|
||||||
isolate_instructions_image.instructions_relocated_address();
|
isolate_instructions_image.instructions_relocated_address();
|
||||||
auto const vm_relocated_address =
|
auto const vm_relocated_address =
|
||||||
vm_instructions_image.instructions_relocated_address();
|
vm_instructions_image.instructions_relocated_address();
|
||||||
// The Dart standard requires the output of StackTrace.toString to include
|
|
||||||
// all pending activations with precise source locations (i.e., to expand
|
|
||||||
// inlined frames and provide line and column numbers).
|
|
||||||
buffer.Printf(
|
|
||||||
"Warning: This VM has been configured to produce stack traces "
|
|
||||||
"that violate the Dart standard.\n");
|
|
||||||
// This prologue imitates Android's debuggerd to make it possible to paste
|
// This prologue imitates Android's debuggerd to make it possible to paste
|
||||||
// the stack trace into ndk-stack.
|
// the stack trace into ndk-stack.
|
||||||
buffer.Printf(
|
buffer.Printf(
|
||||||
|
|
Loading…
Reference in a new issue