From cc9d14d822222e27828318f5b13080c54a241479 Mon Sep 17 00:00:00 2001 From: Tess Strickland Date: Tue, 21 Jun 2022 08:00:33 +0000 Subject: [PATCH] [vm] Remove warnings about non-standard stack traces. The language team has clarified in https://github.com/dart-lang/language/issues/1212 that the content of stack traces is not specified in a way that is violated by either obfuscation or non-symbolic stack traces. Thus, we remove the warnings about supposedly standard-violating stack traces. TEST=No change in actual functionality, so tested manually. Bug: https://github.com/dart-lang/sdk/issues/43388 Change-Id: I2c7ac44cf2f9afafa85d902b2783e1173e727264 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249185 Commit-Queue: Tess Strickland Reviewed-by: Daco Harkes Reviewed-by: Martin Kustermann --- runtime/vm/isolate.cc | 7 ------- runtime/vm/object.cc | 6 ------ 2 files changed, 13 deletions(-) diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc index d20cf5468a6..84694a600ba 100644 --- a/runtime/vm/isolate.cc +++ b/runtime/vm/isolate.cc @@ -1739,13 +1739,6 @@ Isolate::Isolate(IsolateGroup* isolate_group, // how the vm_tag (kEmbedderTagId) can be set, these tags need to // move to the OSThread structure. set_user_tag(UserTags::kDefaultUserTag); - - if (group()->obfuscate()) { - OS::PrintErr( - "Warning: This VM has been configured to obfuscate symbol information " - "which violates the Dart standard.\n" - " See dartbug.com/30524 for more information.\n"); - } } #undef REUSABLE_HANDLE_SCOPE_INIT diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc index 47633fef274..88143201c6b 100644 --- a/runtime/vm/object.cc +++ b/runtime/vm/object.cc @@ -25878,12 +25878,6 @@ const char* StackTrace::ToCString() const { isolate_instructions_image.instructions_relocated_address(); auto const vm_relocated_address = vm_instructions_image.instructions_relocated_address(); - // The Dart standard requires the output of StackTrace.toString to include - // all pending activations with precise source locations (i.e., to expand - // inlined frames and provide line and column numbers). - buffer.Printf( - "Warning: This VM has been configured to produce stack traces " - "that violate the Dart standard.\n"); // This prologue imitates Android's debuggerd to make it possible to paste // the stack trace into ndk-stack. buffer.Printf(