languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[test/ffi] Disable handles test on msan

Browse source 
Properly running msan on this test would require us to emit
msan_unpoison and msan_poison calls in the ffi trampolines to mark
explicitly what we are doing with the stack during ffi calls.

Issue: https://github.com/dart-lang/sdk/issues/42314

Also, this CL unifies the two status files a bit more.

Change-Id: I3a234b9c6dc430883a2d224b9ed3d7d48f4f678a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151399
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
This commit is contained in:
Daco Harkes 2020-06-17 08:26:39 +00:00 committed by commit-bot@chromium.org
parent aa3f7dc4e9
commit 8e2fa30e6c
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tests/ffi/ffi.status
View file

@ -2,8 +2,8 @@
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
[ $builder_tag == asan ]
data_not_asan_test: SkipByDesign # This test tries to allocate too much memory on purpose.
[ $builder_tag == msan ]
vmspecific_handle_test: Skip # https://dartbug.com/42314
[ $system == android ]
*: Pass, Slow # https://github.com/dart-lang/sdk/issues/38489
@ -20,6 +20,9 @@ vmspecific_handle_test: SkipByDesign # Symbols are not exposed on purpose and ar
[ $arch == simarm || $arch == simarm64 ]
*: Skip # FFI not yet supported on the arm simulator.
[ $builder_tag == asan || $builder_tag == msan || $builder_tag == tsan ]
data_not_asan_test: SkipByDesign # This test tries to allocate too much memory on purpose.
# These tests trigger and catch an abort (intentionally) and terminate the VM.
# They're incompatible with ASAN because not all memory is freed when aborting and
# with AppJit because the abort the VM before it can generate a snapshot.

3
tests/ffi_2/ffi_2.status
View file

@ -2,6 +2,9 @@
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
[ $builder_tag == msan ]
vmspecific_handle_test: Skip # https://dartbug.com/42314
[ $system == android ]
*: Pass, Slow # https://github.com/dart-lang/sdk/issues/38489