From 8e2fa30e6c5747108642a1b6ba87f7e7202ad6e9 Mon Sep 17 00:00:00 2001 From: Daco Harkes Date: Wed, 17 Jun 2020 08:26:39 +0000 Subject: [PATCH] [test/ffi] Disable handles test on msan Properly running msan on this test would require us to emit msan_unpoison and msan_poison calls in the ffi trampolines to mark explicitly what we are doing with the stack during ffi calls. Issue: https://github.com/dart-lang/sdk/issues/42314 Also, this CL unifies the two status files a bit more. Change-Id: I3a234b9c6dc430883a2d224b9ed3d7d48f4f678a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151399 Reviewed-by: Tess Strickland Commit-Queue: Daco Harkes --- tests/ffi/ffi.status | 7 +++++-- tests/ffi_2/ffi_2.status | 3 +++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/ffi/ffi.status b/tests/ffi/ffi.status index 9946ac7e89f..37ab3e99352 100644 --- a/tests/ffi/ffi.status +++ b/tests/ffi/ffi.status @@ -2,8 +2,8 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. -[ $builder_tag == asan ] -data_not_asan_test: SkipByDesign # This test tries to allocate too much memory on purpose. +[ $builder_tag == msan ] +vmspecific_handle_test: Skip # https://dartbug.com/42314 [ $system == android ] *: Pass, Slow # https://github.com/dart-lang/sdk/issues/38489 @@ -20,6 +20,9 @@ vmspecific_handle_test: SkipByDesign # Symbols are not exposed on purpose and ar [ $arch == simarm || $arch == simarm64 ] *: Skip # FFI not yet supported on the arm simulator. +[ $builder_tag == asan || $builder_tag == msan || $builder_tag == tsan ] +data_not_asan_test: SkipByDesign # This test tries to allocate too much memory on purpose. + # These tests trigger and catch an abort (intentionally) and terminate the VM. # They're incompatible with ASAN because not all memory is freed when aborting and # with AppJit because the abort the VM before it can generate a snapshot. diff --git a/tests/ffi_2/ffi_2.status b/tests/ffi_2/ffi_2.status index 0991082ad30..37ab3e99352 100644 --- a/tests/ffi_2/ffi_2.status +++ b/tests/ffi_2/ffi_2.status @@ -2,6 +2,9 @@ # for details. All rights reserved. Use of this source code is governed by a # BSD-style license that can be found in the LICENSE file. +[ $builder_tag == msan ] +vmspecific_handle_test: Skip # https://dartbug.com/42314 + [ $system == android ] *: Pass, Slow # https://github.com/dart-lang/sdk/issues/38489