mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 08:24:39 +00:00
Remove some unnecessary ignore comments in test_runner
Change-Id: Ic4dd24a689d6832e4bfe6f1f42abd0c81bcd42e9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274731 Reviewed-by: William Hesse <whesse@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This commit is contained in:
parent
c58297b756
commit
8e03a148ae
|
@ -1456,7 +1456,6 @@ mixin _StaticErrorOutput on CommandOutput {
|
|||
/// Same as `int.parse`, but allows nulls to simply pass through.
|
||||
static int? _parseNullableInt(String? s) {
|
||||
if (s == null) {
|
||||
// ignore: avoid_returning_null
|
||||
return null;
|
||||
}
|
||||
return int.parse(s);
|
||||
|
|
|
@ -1005,7 +1005,6 @@ void listConfigurations(Map<String, dynamic> options) {
|
|||
}
|
||||
|
||||
/// Throws an [OptionParseException] with [message].
|
||||
// ignore: sdk_version_never
|
||||
Never _fail(String message) {
|
||||
throw OptionParseException(message);
|
||||
}
|
||||
|
|
|
@ -702,8 +702,6 @@ class _ErrorExpectationParser {
|
|||
return line;
|
||||
}
|
||||
|
||||
// TODO(athom): remove when migrated to null safety.
|
||||
// ignore: sdk_version_never
|
||||
Never _fail(String message) {
|
||||
throw FormatException("Test error on line ${_currentLine + 1}: $message");
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue