From 8e03a148ae6e68817d362d10849d3a013e08f43c Mon Sep 17 00:00:00 2001 From: Brian Wilkerson Date: Mon, 12 Dec 2022 18:21:00 +0000 Subject: [PATCH] Remove some unnecessary ignore comments in test_runner Change-Id: Ic4dd24a689d6832e4bfe6f1f42abd0c81bcd42e9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274731 Reviewed-by: William Hesse Commit-Queue: Brian Wilkerson --- pkg/test_runner/lib/src/command_output.dart | 1 - pkg/test_runner/lib/src/options.dart | 1 - pkg/test_runner/lib/src/static_error.dart | 2 -- 3 files changed, 4 deletions(-) diff --git a/pkg/test_runner/lib/src/command_output.dart b/pkg/test_runner/lib/src/command_output.dart index 72e6a2abf02..3432347a0e8 100644 --- a/pkg/test_runner/lib/src/command_output.dart +++ b/pkg/test_runner/lib/src/command_output.dart @@ -1456,7 +1456,6 @@ mixin _StaticErrorOutput on CommandOutput { /// Same as `int.parse`, but allows nulls to simply pass through. static int? _parseNullableInt(String? s) { if (s == null) { - // ignore: avoid_returning_null return null; } return int.parse(s); diff --git a/pkg/test_runner/lib/src/options.dart b/pkg/test_runner/lib/src/options.dart index 073675836f6..3f8451a12c9 100644 --- a/pkg/test_runner/lib/src/options.dart +++ b/pkg/test_runner/lib/src/options.dart @@ -1005,7 +1005,6 @@ void listConfigurations(Map options) { } /// Throws an [OptionParseException] with [message]. -// ignore: sdk_version_never Never _fail(String message) { throw OptionParseException(message); } diff --git a/pkg/test_runner/lib/src/static_error.dart b/pkg/test_runner/lib/src/static_error.dart index 1c019406c75..9002e564f0c 100644 --- a/pkg/test_runner/lib/src/static_error.dart +++ b/pkg/test_runner/lib/src/static_error.dart @@ -702,8 +702,6 @@ class _ErrorExpectationParser { return line; } - // TODO(athom): remove when migrated to null safety. - // ignore: sdk_version_never Never _fail(String message) { throw FormatException("Test error on line ${_currentLine + 1}: $message"); }