languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-10-06 14:07:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

use dartdev for analysis on the bots; fix two analysis issues

Browse source 
Change-Id: I83beb65396e31b58bb0ffd25984ec322f01e9b99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159641
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This commit is contained in:
Devon Carew 2020-08-21 17:24:10 +00:00 committed by commit-bot@chromium.org
parent e8577913eb
commit 3ce72bb994
3 changed files with 30 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/status_file/lib/status_file_linter.dart
View file

@ -98,7 +98,7 @@ Iterable<LintingError> lintDisjunctionsInHeader(StatusSection section) {
Iterable<LintingError> lintAlphabeticalOrderingOfPaths(StatusSection section) {
var entries = section.entries
.whereType<StatusEntry>()
.map((entry) => (entry as StatusEntry).path)
.map((entry) => entry.path)
.toList();
var sortedList = entries.toList()..sort((a, b) => a.compareTo(b));
var witness = _findNotEqualWitness<String>(sortedList, entries);
@ -132,9 +132,8 @@ Iterable<LintingError> lintNormalizedSection(StatusSection section) {
/// Checks for duplicate section entries in the body of a section.
Iterable<LintingError> lintSectionEntryDuplicates(StatusSection section) {
var errors = <LintingError>[];
List<StatusEntry> statusEntries = section.entries
.whereType<StatusEntry>()
.toList();
List<StatusEntry> statusEntries =
section.entries.whereType<StatusEntry>().toList();
for (var i = 0; i < statusEntries.length; i++) {
var entry = statusEntries[i];
for (var j = i + 1; j < statusEntries.length; j++) {

2
pkg/vm_snapshot_analysis/test/instruction_sizes_test.dart
View file

@ -2,11 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
import 'dart:convert';
import 'dart:io';
import 'package:test/test.dart';
import 'package:vm_snapshot_analysis/instruction_sizes.dart'
as instruction_sizes;
import 'package:vm_snapshot_analysis/program_info.dart';

45
tools/bots/test_matrix.json
View file

@ -2971,41 +2971,41 @@
},
{
"name": "analyze pkg/analysis_server",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"arguments": [
"--fatal-warnings",
"analyze",
"pkg/analysis_server"
]
},
{
"name": "analyze pkg/analysis_server_client",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"arguments": [
"--fatal-warnings",
"analyze",
"pkg/analysis_server_client"
]
},
{
"name": "analyze pkg/analyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"arguments": [
"--fatal-warnings",
"analyze",
"pkg/analyzer"
]
},
{
"name": "analyze pkg/analyzer_cli",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"arguments": [
"--fatal-warnings",
"analyze",
"pkg/analyzer_cli"
]
},
{
"name": "analyze pkg/analyzer_plugin",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"arguments": [
"--fatal-warnings",
"analyze",
"pkg/analyzer_plugin"
]
},
@ -3035,9 +3035,10 @@
},
{
"name": "analyze pkg/dartdev",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"arguments": [
"--fatal-warnings",
"analyze",
"--fatal-infos",
"pkg/dartdev"
]
},
@ -3140,25 +3141,25 @@
},
{
"name": "analyze pkg/status_file",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"arguments": [
"--fatal-warnings",
"analyze",
"pkg/status_file"
]
},
{
"name": "analyze pkg/telemetry",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"arguments": [
"--fatal-warnings",
"analyze",
"pkg/telemetry"
]
},
{
"name": "analyze pkg/test_runner",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"arguments": [
"--fatal-warnings",
"analyze",
"pkg/test_runner"
]
},
@ -3186,6 +3187,14 @@
"pkg/vm_service"
]
},
{
"name": "analyze pkg/vm_snapshot_analysis",
"script": "out/ReleaseX64/dart-sdk/bin/dart",
"arguments": [
"analyze",
"pkg/vm_snapshot_analysis"
]
},
{
"name": "analyze pkg/dds",
"script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",