diff --git a/pkg/status_file/lib/status_file_linter.dart b/pkg/status_file/lib/status_file_linter.dart index c8e08c6e5f8..d1282ab09ee 100644 --- a/pkg/status_file/lib/status_file_linter.dart +++ b/pkg/status_file/lib/status_file_linter.dart @@ -98,7 +98,7 @@ Iterable lintDisjunctionsInHeader(StatusSection section) { Iterable lintAlphabeticalOrderingOfPaths(StatusSection section) { var entries = section.entries .whereType() - .map((entry) => (entry as StatusEntry).path) + .map((entry) => entry.path) .toList(); var sortedList = entries.toList()..sort((a, b) => a.compareTo(b)); var witness = _findNotEqualWitness(sortedList, entries); @@ -132,9 +132,8 @@ Iterable lintNormalizedSection(StatusSection section) { /// Checks for duplicate section entries in the body of a section. Iterable lintSectionEntryDuplicates(StatusSection section) { var errors = []; - List statusEntries = section.entries - .whereType() - .toList(); + List statusEntries = + section.entries.whereType().toList(); for (var i = 0; i < statusEntries.length; i++) { var entry = statusEntries[i]; for (var j = i + 1; j < statusEntries.length; j++) { diff --git a/pkg/vm_snapshot_analysis/test/instruction_sizes_test.dart b/pkg/vm_snapshot_analysis/test/instruction_sizes_test.dart index a63524fcbb9..78a1ac673e3 100644 --- a/pkg/vm_snapshot_analysis/test/instruction_sizes_test.dart +++ b/pkg/vm_snapshot_analysis/test/instruction_sizes_test.dart @@ -2,11 +2,9 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. -import 'dart:convert'; import 'dart:io'; import 'package:test/test.dart'; - import 'package:vm_snapshot_analysis/instruction_sizes.dart' as instruction_sizes; import 'package:vm_snapshot_analysis/program_info.dart'; diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json index 0ae5512cf3b..41dbd25f37f 100644 --- a/tools/bots/test_matrix.json +++ b/tools/bots/test_matrix.json @@ -2971,41 +2971,41 @@ }, { "name": "analyze pkg/analysis_server", - "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer", + "script": "out/ReleaseX64/dart-sdk/bin/dart", "arguments": [ - "--fatal-warnings", + "analyze", "pkg/analysis_server" ] }, { "name": "analyze pkg/analysis_server_client", - "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer", + "script": "out/ReleaseX64/dart-sdk/bin/dart", "arguments": [ - "--fatal-warnings", + "analyze", "pkg/analysis_server_client" ] }, { "name": "analyze pkg/analyzer", - "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer", + "script": "out/ReleaseX64/dart-sdk/bin/dart", "arguments": [ - "--fatal-warnings", + "analyze", "pkg/analyzer" ] }, { "name": "analyze pkg/analyzer_cli", - "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer", + "script": "out/ReleaseX64/dart-sdk/bin/dart", "arguments": [ - "--fatal-warnings", + "analyze", "pkg/analyzer_cli" ] }, { "name": "analyze pkg/analyzer_plugin", - "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer", + "script": "out/ReleaseX64/dart-sdk/bin/dart", "arguments": [ - "--fatal-warnings", + "analyze", "pkg/analyzer_plugin" ] }, @@ -3035,9 +3035,10 @@ }, { "name": "analyze pkg/dartdev", - "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer", + "script": "out/ReleaseX64/dart-sdk/bin/dart", "arguments": [ - "--fatal-warnings", + "analyze", + "--fatal-infos", "pkg/dartdev" ] }, @@ -3140,25 +3141,25 @@ }, { "name": "analyze pkg/status_file", - "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer", + "script": "out/ReleaseX64/dart-sdk/bin/dart", "arguments": [ - "--fatal-warnings", + "analyze", "pkg/status_file" ] }, { "name": "analyze pkg/telemetry", - "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer", + "script": "out/ReleaseX64/dart-sdk/bin/dart", "arguments": [ - "--fatal-warnings", + "analyze", "pkg/telemetry" ] }, { "name": "analyze pkg/test_runner", - "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer", + "script": "out/ReleaseX64/dart-sdk/bin/dart", "arguments": [ - "--fatal-warnings", + "analyze", "pkg/test_runner" ] }, @@ -3186,6 +3187,14 @@ "pkg/vm_service" ] }, + { + "name": "analyze pkg/vm_snapshot_analysis", + "script": "out/ReleaseX64/dart-sdk/bin/dart", + "arguments": [ + "analyze", + "pkg/vm_snapshot_analysis" + ] + }, { "name": "analyze pkg/dds", "script": "out/ReleaseX64/dart-sdk/bin/dartanalyzer",