mirror of
https://github.com/dart-lang/sdk
synced 2024-09-05 08:24:39 +00:00
[tests] Skip multiple html and co19/html tests.
All tests skipped here are flaking or timing out. Most of them fail for a common reason tracked in https://github.com/dart-lang/sdk/issues/53985: Chrome inactive tabs do not run behave the same as active tabs. This means that interactions like css transitions, requestAnimationFrame, and video play don't work as expected. This CL skips the tests only on Chrome, but continues to run them in other browsers where the expectation is met. If we can in the future ensure tests are run on an active tab, we can consider reneabling these tests. That said, the value of this tests was higher when we mantained Dartium, but these days we may consider deleting them instead. Change-Id: I9c0ea230fecca16fa008b64c2cf316ccdd0f53e4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335030 Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com>
This commit is contained in:
parent
40a5f6f756
commit
1cba9f344c
|
@ -92,6 +92,9 @@ LibTest/typed_data/ByteData/setUint64_A02_t02: SkipByDesign # 64-bit int not sup
|
|||
LibTest/typed_data/Int64List/*: SkipByDesign # Int64List not supported on the web
|
||||
LibTest/typed_data/Uint64List/*: SkipByDesign # Uint64List not supported on the web
|
||||
|
||||
[ $compiler == dart2js && $runtime == chrome ]
|
||||
LibTest/html/Window/animationFrame_A01_t01: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
|
||||
|
||||
[ $compiler == dart2js && $runtime == d8 ]
|
||||
LibTest/html/*: SkipByDesign # d8 is not a browser
|
||||
|
||||
|
@ -117,5 +120,6 @@ LibTest/core/List/List_class_A01_t05: SkipSlow # slow babeljs transformation
|
|||
LibTest/core/List/List_class_A01_t06: SkipSlow # slow babeljs transformation
|
||||
|
||||
[ $compiler == dart2js && $runtime == safari ]
|
||||
LibTest/html/Element/isContentEditable_A01_t01: Skip # 98% fails in Safari, evades flake detection https://github.com/dart-lang/sdk/issues/50718
|
||||
LibTest/html/Element/isContentEditable_A02_t01: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718
|
||||
LibTest/html/IFrameElement/isContentEditable_A01_t01: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718
|
||||
|
|
|
@ -89,3 +89,6 @@ LibTest/typed_data/ByteData/setUint64_A02_t01: SkipByDesign # 64-bit int not sup
|
|||
LibTest/typed_data/ByteData/setUint64_A02_t02: SkipByDesign # 64-bit int not supported on the web
|
||||
LibTest/typed_data/Int64List/*: SkipByDesign # Int64List not supported on the web
|
||||
LibTest/typed_data/Uint64List/*: SkipByDesign # Uint64List not supported on the web
|
||||
|
||||
[ $compiler == ddc && $runtime == chrome ]
|
||||
LibTest/html/Window/animationFrame_A01_t01: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
|
||||
|
|
|
@ -56,6 +56,11 @@ LibTest/typed_data/ByteData/setUint64_A02_t02: SkipByDesign # 64-bit int not sup
|
|||
LibTest/typed_data/Int64List/*: SkipByDesign # Int64List not supported on the web
|
||||
LibTest/typed_data/Uint64List/*: SkipByDesign # Uint64List not supported on the web
|
||||
|
||||
[ $compiler == dart2js && $runtime == chrome ]
|
||||
LibTest/html/Window/animationFrame_A01_t01: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
|
||||
co19_2/LibTest/html/IFrameElement/blur_A01_t01: SkipByDesign # 62% flaky, unexplained, passes consistently in co19 suite (just flakes in co19_2)
|
||||
co19_2/LibTest/html/IFrameElement/focus_A01_t01: SkipByDesign # 80% flaky, unexplained, passes consistently in co19 suite (just flakes in co19_2)
|
||||
|
||||
[ $compiler == dart2js && $runtime == d8 ]
|
||||
LibTest/html/*: SkipByDesign # d8 is not a browser
|
||||
|
||||
|
|
|
@ -124,3 +124,6 @@ LibTest/typed_data/ByteData/setUint64_A02_t01: SkipByDesign # 64-bit int not sup
|
|||
LibTest/typed_data/ByteData/setUint64_A02_t02: SkipByDesign # 64-bit int not supported on the web
|
||||
LibTest/typed_data/Int64List/*: SkipByDesign # Int64List not supported on the web
|
||||
LibTest/typed_data/Uint64List/*: SkipByDesign # Uint64List not supported on the web
|
||||
|
||||
[ $compiler == ddc && $runtime == chrome ]
|
||||
LibTest/html/Window/animationFrame_A01_t01: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
|
||||
|
|
|
@ -35,6 +35,9 @@ async/slow_consumer2_test: SkipSlow # Times out. Issue 22050
|
|||
convert/streamed_conversion_json_utf8_decode_test: SkipSlow # Times out. Issue 22050
|
||||
convert/streamed_conversion_json_utf8_encode_test: SkipSlow # Times out. Issue 22050
|
||||
convert/streamed_conversion_utf8_decode_test: SkipSlow # Times out. Issue 22050
|
||||
html/canvasrendering/draw_image_video_element_test: SkipByDesign # Issue #53985: video is not played on Chrome inactive tabs
|
||||
html/request_animation_frame_test: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
|
||||
html/transition_event_test: SkipByDesign # Issue #53985: css transitions are not executed on Chrome inactive tabs
|
||||
|
||||
[ $compiler == dart2js && $runtime == chromeOnAndroid ]
|
||||
html/input_element_datetime_test: Slow, Pass # TODO(dart2js-team): Please triage this failure.
|
||||
|
|
|
@ -29,7 +29,10 @@ typed_data/int64_list_load_store_test: SkipByDesign # ddc does not support Int64
|
|||
typed_data/typed_data_hierarchy_int64_test: SkipByDesign # ddc does not support Int64List
|
||||
|
||||
[ $compiler == ddc && $runtime == chrome ]
|
||||
html/canvasrendering/draw_image_video_element_test: SkipByDesign # Issue #53985: video is not played on Chrome inactive tabs
|
||||
html/js_dispatch_property_test: Skip # Timeout Issue 31030
|
||||
html/request_animation_frame_test: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
|
||||
html/transition_event_test: SkipByDesign # Issue #53985: css transitions are not executed on Chrome inactive tabs
|
||||
|
||||
[ $compiler == ddc && $runtime == ff ]
|
||||
html/mediadevices_test: SkipByDesign # Not supported on FF, likely requires user-interaction that causes timeout
|
||||
|
|
|
@ -33,6 +33,9 @@ async/slow_consumer2_test: SkipSlow # Times out. Issue 22050
|
|||
convert/streamed_conversion_json_utf8_decode_test: SkipSlow # Times out. Issue 22050
|
||||
convert/streamed_conversion_json_utf8_encode_test: SkipSlow # Times out. Issue 22050
|
||||
convert/streamed_conversion_utf8_decode_test: SkipSlow # Times out. Issue 22050
|
||||
html/canvasrendering/draw_image_video_element_test: SkipByDesign # Issue #53985: video is not played on Chrome inactive tabs
|
||||
html/request_animation_frame_test: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
|
||||
html/transition_event_test: SkipByDesign # Issue #53985: css transitions are not executed on Chrome inactive tabs
|
||||
|
||||
[ $compiler == dart2js && $runtime == chromeOnAndroid ]
|
||||
html/input_element_datetime_test: Slow, Pass # TODO(dart2js-team): Please triage this failure.
|
||||
|
@ -70,7 +73,6 @@ html/interactive_media_test: SkipSlow
|
|||
html/mediasource_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718
|
||||
js/js_util/bigint_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718
|
||||
|
||||
|
||||
[ $compiler == dart2js && $checked ]
|
||||
convert/utf85_test: Slow, Pass # Issue 12029.
|
||||
html/js_function_getter_trust_types/function_test: Skip # --trust-type-annotations incompatible with --checked
|
||||
|
|
|
@ -27,7 +27,10 @@ js/js_util/js_prefix_test: SkipByDesign # JS$ prefix not implemented on ddc.
|
|||
mirrors/*: SkipByDesign # Mirrors not supported on web in Dart 2.0.
|
||||
|
||||
[ $compiler == ddc && $runtime == chrome ]
|
||||
html/canvasrendering/draw_image_video_element_test: SkipByDesign # Issue #53985: video is not played on Chrome inactive tabs
|
||||
html/js_dispatch_property_test: Skip # Timeout Issue 31030
|
||||
html/request_animation_frame_test: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
|
||||
html/transition_event_test: SkipByDesign # Issue #53985: css transitions are not executed on Chrome inactive tabs
|
||||
|
||||
[ $compiler == ddc && $runtime == ff ]
|
||||
html/mediadevices_test: SkipByDesign # Not supported on FF, likely requires user-interaction that causes timeout
|
||||
|
|
Loading…
Reference in a new issue