languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dart:html] Expose scrollIntoViewIfNeeded

Browse source 
`scrollIntoViewIfNeeded` is nested within `scrollIntoView`. The latter
method is outdated and the way to access the different ways to call
`scrollIntoViewIfNeeded`. Instead of using that method, this CL
directly exposes `scrollIntoViewIfNeeded`.

Change-Id: I38d7876a7923768ae165c29a98e514e90182b77e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231047
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Riley Porter <rileyporter@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
This commit is contained in:
Srujan Gaddam 2022-02-02 20:46:59 +00:00 committed by Commit Bot
parent 33b3c1d6c6
commit 0ec4c3a1b5
4 changed files with 37 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
sdk/lib/html/dart2js/html_dart2js.dart
View file

@ -13389,10 +13389,14 @@ class Element extends Node
} else if (alignment == ScrollAlignment.BOTTOM) {
this._scrollIntoView(false);
} else if (hasScrollIntoViewIfNeeded) {
// TODO(srujzs): This method shouldn't be calling out to
// `scrollIntoViewIfNeeded`. Remove this and make `scrollIntoView` match
// the browser definition. If you intend to use `scrollIntoViewIfNeeded`,
// use the `Element.scrollIntoViewIfNeeded` method.
if (alignment == ScrollAlignment.CENTER) {
this._scrollIntoViewIfNeeded(true);
this.scrollIntoViewIfNeeded(true);
} else {
this._scrollIntoViewIfNeeded();
this.scrollIntoViewIfNeeded();
}
} else {
this._scrollIntoView();
@ -14896,8 +14900,18 @@ class Element extends Node
@JSName('scrollIntoView')
void _scrollIntoView([Object? arg]) native;
@JSName('scrollIntoViewIfNeeded')
void _scrollIntoViewIfNeeded([bool? centerIfNeeded]) native;
/**
* Nonstandard version of `scrollIntoView` that scrolls the current element
* into the visible area of the browser window if it's not already within the
* visible area of the browser window. If the element is already within the
* visible area of the browser window, then no scrolling takes place.
*
* ## Other resources
*
* * [Element.scrollIntoViewIfNeeded](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoViewIfNeeded)
* from MDN.
*/
void scrollIntoViewIfNeeded([bool? centerIfNeeded]) native;
void scrollTo([options_OR_x, num? y]) {
if (options_OR_x == null && y == null) {

13
tools/dom/docs.json
View file

@ -1270,6 +1270,19 @@
" * See [EventStreamProvider] for usage information.",
" */"
],
"scrollIntoViewIfNeeded": [
"/**",
" * Nonstandard version of `scrollIntoView` that scrolls the current element",
" * into the visible area of the browser window if it's not already within the",
" * visible area of the browser window. If the element is already within the",
" * visible area of the browser window, then no scrolling takes place.",
" *",
" * ## Other resources",
" *",
" * * [Element.scrollIntoViewIfNeeded](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoViewIfNeeded)",
" * from MDN.",
" */"
],
"searchEvent": [
"/**",
" * Static factory designed to expose `search` events to event",

1
tools/dom/scripts/htmlrenamer.py
View file

@ -403,7 +403,6 @@ private_html_members = monitored.Set(
'Element.getElementsByTagName',
'Element.insertAdjacentHTML',
'Element.scrollIntoView',
'Element.scrollIntoViewIfNeeded',
'Element.getAttribute',
'Element.getAttributeNS',
'Element.hasAttribute',

8
tools/dom/templates/html/impl/impl_Element.darttemplate
View file

@ -1007,10 +1007,14 @@ $endif
} else if (alignment == ScrollAlignment.BOTTOM) {
this._scrollIntoView(false);
} else if (hasScrollIntoViewIfNeeded) {
// TODO(srujzs): This method shouldn't be calling out to
// `scrollIntoViewIfNeeded`. Remove this and make `scrollIntoView` match
// the browser definition. If you intend to use `scrollIntoViewIfNeeded`,
// use the `Element.scrollIntoViewIfNeeded` method.
if (alignment == ScrollAlignment.CENTER) {
this._scrollIntoViewIfNeeded(true);
this.scrollIntoViewIfNeeded(true);
} else {
this._scrollIntoViewIfNeeded();
this.scrollIntoViewIfNeeded();
}
} else {
this._scrollIntoView();