languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 08:44:27 +00:00
Code Issues Projects Releases Packages Wiki Activity
dart-sdk/benchmarks/analysis_options.yaml

97 lines
3 KiB
YAML
Raw Normal View History

[benchmarks] Disable omit_local_variable_types analyzer hint This hint flags code such as int time = watch.elapsedMillisecond; and encourages using `var` everywhere: var time = watch.elapsedMillisecond; Though if the type is not obvious to a developer, we should be allowed to write it. Furthermore it copies the rules from `package:pedantic/analysis_options-1.9.0.yaml` to avoid being automatically opted-in to new rules when a new package:pedantic gets rolled into the SDK. Change-Id: I45c72584885c608a56745685e9068ba83dfbed47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151526 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-06-19 13:43:23 +00:00
# Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
- migrate sound_splay_tree.dart to null safety - exclude from analysis all dart 2 benchmarks This reduces the analysis errors when opening up the SDK significantly. Change-Id: I9e1c4f7e4b790e4962ea2112a293bf0ef5402b10 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292440 Reviewed-by: Stephen Adams <sra@google.com> Reviewed-by: Kallen Tu <kallentu@google.com> Commit-Queue: Jake Macdonald <jakemac@google.com>
2023-04-05 15:57:33 +00:00
analyzer:
exclude:
- '*/dart2/' # These don't analyze cleanly on newer sdks
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
# strong-mode:
# implicit-casts: false
linter:
rules:
[benchmarks] Disable omit_local_variable_types analyzer hint This hint flags code such as int time = watch.elapsedMillisecond; and encourages using `var` everywhere: var time = watch.elapsedMillisecond; Though if the type is not obvious to a developer, we should be allowed to write it. Furthermore it copies the rules from `package:pedantic/analysis_options-1.9.0.yaml` to avoid being automatically opted-in to new rules when a new package:pedantic gets rolled into the SDK. Change-Id: I45c72584885c608a56745685e9068ba83dfbed47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151526 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-06-19 13:43:23 +00:00
- always_declare_return_types
- always_require_non_null_named_parameters
- annotate_overrides
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
- avoid_empty_else
- avoid_function_literals_in_foreach_calls
- avoid_init_to_null
- avoid_null_checks_in_equality_operators
- avoid_relative_lib_imports
- avoid_renaming_method_parameters
- avoid_return_types_on_setters
- avoid_returning_null
- avoid_returning_null_for_future
- avoid_shadowing_type_parameters
- avoid_types_as_parameter_names
- avoid_unused_constructor_parameters
- await_only_futures
[benchmarks] Disable omit_local_variable_types analyzer hint This hint flags code such as int time = watch.elapsedMillisecond; and encourages using `var` everywhere: var time = watch.elapsedMillisecond; Though if the type is not obvious to a developer, we should be allowed to write it. Furthermore it copies the rules from `package:pedantic/analysis_options-1.9.0.yaml` to avoid being automatically opted-in to new rules when a new package:pedantic gets rolled into the SDK. Change-Id: I45c72584885c608a56745685e9068ba83dfbed47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151526 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-06-19 13:43:23 +00:00
- camel_case_extensions
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
- camel_case_types
- cancel_subscriptions
- comment_references
#- constant_identifier_names
- control_flow_in_finally
[benchmarks] Disable omit_local_variable_types analyzer hint This hint flags code such as int time = watch.elapsedMillisecond; and encourages using `var` everywhere: var time = watch.elapsedMillisecond; Though if the type is not obvious to a developer, we should be allowed to write it. Furthermore it copies the rules from `package:pedantic/analysis_options-1.9.0.yaml` to avoid being automatically opted-in to new rules when a new package:pedantic gets rolled into the SDK. Change-Id: I45c72584885c608a56745685e9068ba83dfbed47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151526 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-06-19 13:43:23 +00:00
- curly_braces_in_flow_control_structures
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
- directives_ordering
- empty_catches
- empty_constructor_bodies
- empty_statements
- hash_and_equals
- implementation_imports
Roll benchmarks-internal to 02695da98bcf006b95630d3c386f4169d7ec4ecf Ignore invariant_booleans lint rule when analyzing benchmarks. Change-Id: I6071d3c1407e9c67689204e4ceb50cc1c0c8e109 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152598 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Régis Crelier <regis@google.com>
2020-06-26 01:56:03 +00:00
#- invariant_booleans
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
- iterable_contains_unrelated_type
- library_names
- library_prefixes
- list_remove_unrelated_type
[benchmarks] Disable literal_only_boolean_expressions/unnecessary_await_in_return analyzer hints The literal_only_boolean_expressions analyzer hint flags this code: while (true) { ... if (cond) break; ... } => This is very common code. The unnecessary_await_in_return analyzer hint flags this code: Future foo() async { ... return await foo(); } => Addressing this hint by removing the `await` changes semantics, performance characteristics and async stack traces. Change-Id: I3c126123bfba7386b01033084e954267af21ba13 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152001 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
2020-06-23 06:02:07 +00:00
#- literal_only_boolean_expressions
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
- no_adjacent_strings_in_list
- no_duplicate_case_values
#- non_constant_identifier_names
- null_closures
#- omit_local_variable_types
#- only_throw_errors
- overridden_fields
- package_api_docs
- package_names
- package_prefixed_library_names
- prefer_adjacent_string_concatenation
- prefer_collection_literals
- prefer_conditional_assignment
- prefer_const_constructors
- prefer_contains
- prefer_equal_for_default_values
- prefer_final_fields
- prefer_final_locals
[benchmarks] Disable omit_local_variable_types analyzer hint This hint flags code such as int time = watch.elapsedMillisecond; and encourages using `var` everywhere: var time = watch.elapsedMillisecond; Though if the type is not obvious to a developer, we should be allowed to write it. Furthermore it copies the rules from `package:pedantic/analysis_options-1.9.0.yaml` to avoid being automatically opted-in to new rules when a new package:pedantic gets rolled into the SDK. Change-Id: I45c72584885c608a56745685e9068ba83dfbed47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151526 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-06-19 13:43:23 +00:00
- prefer_for_elements_to_map_fromIterable
- prefer_generic_function_type_aliases
- prefer_if_null_operators
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
- prefer_initializing_formals
- prefer_interpolation_to_compose_strings
- prefer_is_empty
- prefer_is_not_empty
[benchmarks] Disable omit_local_variable_types analyzer hint This hint flags code such as int time = watch.elapsedMillisecond; and encourages using `var` everywhere: var time = watch.elapsedMillisecond; Though if the type is not obvious to a developer, we should be allowed to write it. Furthermore it copies the rules from `package:pedantic/analysis_options-1.9.0.yaml` to avoid being automatically opted-in to new rules when a new package:pedantic gets rolled into the SDK. Change-Id: I45c72584885c608a56745685e9068ba83dfbed47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151526 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-06-19 13:43:23 +00:00
- prefer_iterable_whereType
- prefer_single_quotes
- prefer_spread_collections
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
#- prefer_typing_uninitialized_variables
- recursive_getters
- slash_for_doc_comments
- test_types_in_equals
- throw_in_finally
- type_init_formals
- unawaited_futures
[benchmarks] Disable literal_only_boolean_expressions/unnecessary_await_in_return analyzer hints The literal_only_boolean_expressions analyzer hint flags this code: while (true) { ... if (cond) break; ... } => This is very common code. The unnecessary_await_in_return analyzer hint flags this code: Future foo() async { ... return await foo(); } => Addressing this hint by removing the `await` changes semantics, performance characteristics and async stack traces. Change-Id: I3c126123bfba7386b01033084e954267af21ba13 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152001 Reviewed-by: Alexander Markov <alexmarkov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
2020-06-23 06:02:07 +00:00
#- unnecessary_await_in_return
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
- unnecessary_brace_in_string_interps
- unnecessary_const
- unnecessary_getters_setters
- unnecessary_lambdas
- unnecessary_new
- unnecessary_null_aware_assignments
[benchmarks] Disable omit_local_variable_types analyzer hint This hint flags code such as int time = watch.elapsedMillisecond; and encourages using `var` everywhere: var time = watch.elapsedMillisecond; Though if the type is not obvious to a developer, we should be allowed to write it. Furthermore it copies the rules from `package:pedantic/analysis_options-1.9.0.yaml` to avoid being automatically opted-in to new rules when a new package:pedantic gets rolled into the SDK. Change-Id: I45c72584885c608a56745685e9068ba83dfbed47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151526 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-06-19 13:43:23 +00:00
- unnecessary_null_in_if_null_operators
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
- unnecessary_parenthesis
- unnecessary_statements
[benchmarks] Disable omit_local_variable_types analyzer hint This hint flags code such as int time = watch.elapsedMillisecond; and encourages using `var` everywhere: var time = watch.elapsedMillisecond; Though if the type is not obvious to a developer, we should be allowed to write it. Furthermore it copies the rules from `package:pedantic/analysis_options-1.9.0.yaml` to avoid being automatically opted-in to new rules when a new package:pedantic gets rolled into the SDK. Change-Id: I45c72584885c608a56745685e9068ba83dfbed47 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151526 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
2020-06-19 13:43:23 +00:00
- unnecessary_this
[vm/benchmarks] Add IsolateSpawn spawn latency and memory benchmarks. The benchmark spawns an isolate that compiles hello world app with dart2js, measures time it takes for spawned isolate to get up and running, measures delta rss when isolate is spawned. This also adds analysis_options.yaml that helps with keeping the code lint-free. Change-Id: I5f1ffa9706766cd00bf1ea3fdad76957952de8a1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119538 Reviewed-by: Jonas Termansen <sortie@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-11 19:52:12 +00:00
- unrelated_type_equality_checks
- use_function_type_syntax_for_parameters
- use_rethrow_when_possible
- valid_regexps
Reference in a new issue Copy permalink