languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 16:41:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[benchmarks] Disable literal_only_boolean_expressions/unnecessary_await_in_return analyzer hints

Browse source 
The literal_only_boolean_expressions analyzer hint flags this code:

   while (true) {
     ...
     if (cond) break;
     ...
   }

=> This is very common code.

The unnecessary_await_in_return analyzer hint flags this code:

    Future foo() async {
      ...
      return await foo();
    }

=> Addressing this hint by removing the `await` changes semantics,
performance characteristics and async stack traces.

Change-Id: I3c126123bfba7386b01033084e954267af21ba13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152001
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
This commit is contained in:
Martin Kustermann 2020-06-23 06:02:07 +00:00 committed by commit-bot@chromium.org
parent 0a6a4a24ba
commit 177511aa17
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
benchmarks/analysis_options.yaml
View file

@ -41,7 +41,7 @@ linter:
- library_names
- library_prefixes
- list_remove_unrelated_type
- literal_only_boolean_expressions
#- literal_only_boolean_expressions
- no_adjacent_strings_in_list
- no_duplicate_case_values
#- non_constant_identifier_names
@ -77,7 +77,7 @@ linter:
- throw_in_finally
- type_init_formals
- unawaited_futures
- unnecessary_await_in_return
#- unnecessary_await_in_return
- unnecessary_brace_in_string_interps
- unnecessary_const
- unnecessary_getters_setters