kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 01:40:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
dolphin/src
History
Nikolai Krasheninnikov a9e2f01add Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed. 
Summary:
Dolphin crashes if no Konsole is installed and user clicks menu action "Defocus Terminal Panel".
This fix is pretty straight forward.

Steps to reproduce:
1. Run Dolphin without Konsole available.
2. Press F4 to open console window.
3. Click in service menu "Focus Terminal Panel".
4. Click in service menu "Defocus Terminal Panel". Observe the crash.

Test Plan:
1. Run Dolphin without Konsole available.
2. Press F4 to open console window.
3. Click in service menu "Focus Teminal Panel".
4. Click in service menu "Defocus Terminal Panel".
5. Click in service menu "Focus Terminal Panel".
6. Press F4 to close console window.

Reviewers: #dolphin, meven, elvisangelaccio, ngraham

Reviewed By: #dolphin, meven, elvisangelaccio, ngraham

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D29345
2020-05-04 22:36:51 +03:00
..
filterbar When filter bar is focused, switch to view when tab key is pressed 2019-05-25 21:32:29 -06:00
icons Add application icon for Mac and MS Windows. 2016-11-22 18:15:42 +01:00
kitemviews [Details mode] Allow to fill the column size of directories with actual size 2020-05-04 07:26:59 +02:00
panels Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed. 2020-05-04 22:36:51 +03:00
search filenamesearch:/ define a title for the query 2020-05-03 12:46:00 +02:00
settings Dolphin: Cleanup kcms 2020-05-04 20:36:15 +02:00
statusbar Remove unnecessary semicolons after Q_UNUSED 2019-11-09 22:09:16 +01:00
tests (search) Fix searching tags with spaces 2020-01-19 23:17:26 +01:00
trash Get rid of ugly static_cast usages in connect() calls 2019-05-05 17:53:29 +02:00
views Replace the list with the simplified list, instead of concatenate. 2020-05-04 08:00:07 -06:00
CMakeLists.txt Sync terminal with KIOFuse mount when browing remote directories 2020-04-07 18:29:22 +01:00
config-baloo.h.cmake Port Dolphin to Baloo 2014-02-06 20:29:09 +01:00
config-kactivities.h.cmake Bring back KActivities support 2019-03-18 21:18:04 +01:00
config-terminal.h.cmake Introduce HAVE_TERMINAL 2019-01-28 22:38:21 +01:00
dbusinterface.cpp Exclude daemonized processes from Dolphin::attachToExistingInstance() 2020-03-16 22:38:40 +01:00
dbusinterface.h Fix minor typo 2020-03-17 16:56:45 +02:00
dolphin.qrc Bundle the XMLGUI files into qrc resources. 2017-07-25 11:39:57 +02:00
dolphinbookmarkhandler.cpp Port away from deprecated KBookmarksmenu API 2020-03-30 15:50:07 +02:00
dolphinbookmarkhandler.h Remove dead code 2019-11-25 20:54:12 +01:00
dolphincontextmenu.cpp Add Duplicate feature 2020-03-15 13:13:08 -06:00
dolphincontextmenu.h Refactoring to reduce size of openItemContextMenu and add the ContextType TimelineOrSearchContext 2019-12-02 13:24:36 +01:00
dolphindockwidget.cpp don't use temporaries when uneeded 2018-06-22 16:17:47 +02:00
dolphindockwidget.h Don't use nullptr/0 as flags (deprecated in qt5.15) 2019-12-26 14:23:45 +01:00
dolphinmainwindow.cpp Add an option to show tabs from last time when Dolphin starts 2020-04-26 12:14:56 -06:00
dolphinmainwindow.h Add action for focusing Terminal Panel 2019-12-05 15:53:19 -07:00
dolphinnewfilemenu.cpp [CLAZY] Fixed all level 1 and level 2 warnings with small exceptions 2016-03-16 22:17:37 +01:00
dolphinnewfilemenu.h Remove unused #include 2018-03-04 21:00:47 +03:00
dolphinpart.cpp DolphinPart: port dolphin's last use of KRun::run to CommandLauncherJob. 2020-04-18 13:07:08 +02:00
dolphinpart.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2020-03-02 05:36:51 +01:00
dolphinpart.h [Dolphin] Open Preferred Search Tool action 2019-11-17 18:15:26 +01:00
dolphinpart.qrc Bundle the XMLGUI files into qrc resources. 2017-07-25 11:39:57 +02:00
dolphinpart.rc Add action for focusing Terminal Panel 2019-12-05 15:53:19 -07:00
dolphinpart_ext.cpp Remove unused #include 2018-03-04 21:00:47 +03:00
dolphinpart_ext.h Remove unused #include 2018-03-04 21:00:47 +03:00
dolphinplacesmodelsingleton.cpp Introduce singleton for KFilePlacesModel 2018-03-19 09:57:24 +01:00
dolphinplacesmodelsingleton.h Introduce singleton for KFilePlacesModel 2018-03-19 09:57:24 +01:00
dolphinrecenttabsmenu.cpp Remove unused #include 2018-03-04 21:00:47 +03:00
dolphinrecenttabsmenu.h Remove unused #include 2018-03-04 21:00:47 +03:00
dolphinremoveaction.cpp Remove unused #include 2018-03-04 21:00:47 +03:00
dolphinremoveaction.h Remove unused #include 2018-03-04 21:00:47 +03:00
dolphintabbar.cpp Remove unused #include 2018-03-04 21:00:47 +03:00
dolphintabbar.h Modernize: Use override where possible 2017-11-20 23:25:48 +01:00
dolphintabpage.cpp Remove unnecessary semicolons after Q_UNUSED 2019-11-09 22:09:16 +01:00
dolphintabpage.h Fix minor typos 2018-10-25 21:23:44 +03:00
dolphintabwidget.cpp Dolphin: port to CommandLauncherJob 2020-04-05 20:33:30 +02:00
dolphintabwidget.h Add actions for switching to a specific tab 2019-10-13 16:41:00 +02:00
dolphinui.rc Add Duplicate feature 2020-03-15 13:13:08 -06:00
dolphinviewcontainer.cpp [Details mode] Allow to fill the column size of directories with actual size 2020-05-04 07:26:59 +02:00
dolphinviewcontainer.h Do not display full path in the title of the tab 2020-04-15 09:47:57 -06:00
global.cpp Add an option to show tabs from last time when Dolphin starts 2020-04-26 12:14:56 -06:00
global.h Add an option to show tabs from last time when Dolphin starts 2020-04-26 12:14:56 -06:00
main.cpp Add an option to show tabs from last time when Dolphin starts 2020-04-26 12:14:56 -06:00
Messages.sh i18n: drop servicemenuinstaller messages from main po file 2019-07-15 08:08:23 +02:00
middleclickactioneventfilter.cpp Add navigation history to forward/back buttons 2019-09-29 14:16:11 +02:00
middleclickactioneventfilter.h Fix all 'explicit constructor' krazy warnings 2018-02-03 22:21:30 +01:00
org.kde.dolphin.appdata.xml GIT_SILENT Update Appstream for new release 2020-04-15 10:59:54 +02:00
org.kde.dolphin.desktop SVN_SILENT made messages (.desktop file) - always resolve ours 2019-11-11 09:42:43 +01:00