kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-07-15 18:01:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

DolphinPart: port dolphin's last use of KRun::run to CommandLauncherJob.

Browse source 
Summary:
I chose CommandLauncherJob rather than ApplicationLauncherJob
because that would require either looking up org.kde.kfind.desktop
(with a risk of failure) or duplicating the icon name...

Test Plan:
commented out the if() block of the slot, to make sure we end
up launching kfind with this code. Then konqueror /, and Ctrl+F.

Reviewers: broulik

Reviewed By: broulik

Differential Revision: https://phabricator.kde.org/D28810
This commit is contained in:
David Faure 2020-04-14 00:11:16 +02:00
parent 8fa3e7c145
commit ec2c69726a
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/dolphinpart.cpp
View file

@ -34,6 +34,7 @@
#include <KActionCollection>
#include <KAuthorized>
#include <KConfigGroup>
#include <KDialogJobUiDelegate>
#include <KFileItemListProperties>
#include <KIconLoader>
#include <KJobWidgets>
@ -42,7 +43,7 @@
#include <KMimeTypeEditor>
#include <KNS3/KMoreToolsMenuFactory>
#include <KPluginFactory>
#include <KRun>
#include <KIO/CommandLauncherJob>
#include <KSharedConfig>
#include <KToolInvocation>
@ -546,7 +547,10 @@ void DolphinPart::slotFindFile()
if (!(actions.isEmpty())) {
actions.first()->trigger();
} else {
KRun::run(QStringLiteral("kfind"), {url()}, widget());
KIO::CommandLauncherJob *job = new KIO::CommandLauncherJob(QStringLiteral("kfind"), {url().toString()}, this);
job->setDesktopName(QStringLiteral("org.kde.kfind"));
job->setUiDelegate(new KDialogJobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, widget()));
job->start();
}
}