From ec2c69726a89daea1348efbd0e1c6e92145f1773 Mon Sep 17 00:00:00 2001 From: David Faure Date: Tue, 14 Apr 2020 00:11:16 +0200 Subject: [PATCH] DolphinPart: port dolphin's last use of KRun::run to CommandLauncherJob. Summary: I chose CommandLauncherJob rather than ApplicationLauncherJob because that would require either looking up org.kde.kfind.desktop (with a risk of failure) or duplicating the icon name... Test Plan: commented out the if() block of the slot, to make sure we end up launching kfind with this code. Then konqueror /, and Ctrl+F. Reviewers: broulik Reviewed By: broulik Differential Revision: https://phabricator.kde.org/D28810 --- src/dolphinpart.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/dolphinpart.cpp b/src/dolphinpart.cpp index 7e7425121..0c41b2bec 100644 --- a/src/dolphinpart.cpp +++ b/src/dolphinpart.cpp @@ -34,6 +34,7 @@ #include #include #include +#include #include #include #include @@ -42,7 +43,7 @@ #include #include #include -#include +#include #include #include @@ -546,7 +547,10 @@ void DolphinPart::slotFindFile() if (!(actions.isEmpty())) { actions.first()->trigger(); } else { - KRun::run(QStringLiteral("kfind"), {url()}, widget()); + KIO::CommandLauncherJob *job = new KIO::CommandLauncherJob(QStringLiteral("kfind"), {url().toString()}, this); + job->setDesktopName(QStringLiteral("org.kde.kfind")); + job->setUiDelegate(new KDialogJobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, widget())); + job->start(); } }