Commit graph

247 commits

Author SHA1 Message Date
Peter Penz 00afeea5f5 Activate the tab when an item is dragged above an inactive tab. Thanks to Dmitry Khlystov for the patch!
BUG: 164312

svn path=/trunk/KDE/kdebase/apps/; revision=846009
2008-08-12 19:22:38 +00:00
Peter Penz b354c7503d Assure that the "Close Tab" action gets disabled when only one tab is open.
BUG: 168904

svn path=/trunk/KDE/kdebase/apps/; revision=845995
2008-08-12 18:59:25 +00:00
Alex Merry c167ffbb4f We want to change the tab, not just the view.
Fixes the issue: open three tabs.  Select the second one and close it.  Now right tab is active, but content for left tab is shown.

Will backport to 4.1.

CCMAIL: peter.penz@gmx.at


svn path=/trunk/KDE/kdebase/apps/; revision=839877
2008-07-31 01:02:52 +00:00
Peter Penz 4759321fdd forgot to remove unused variable in last commit
svn path=/trunk/KDE/kdebase/apps/; revision=838119
2008-07-26 19:23:20 +00:00
Peter Penz 8d189f44c4 use DBus interface instead of KRun::runCommand()
svn path=/trunk/KDE/kdebase/apps/; revision=838112
2008-07-26 19:09:17 +00:00
Peter Penz a07ea82381 Provide a "Quick View" in the Tools menu, which uses the Previewer plasmoid.
TODO 1: use the D-Bus interface directly instead of using KRun::runCommand() as workaround.

TODO 2: a new icon would be necessary

CCMAIL: alediaferia@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=838039
2008-07-26 13:49:50 +00:00
Peter Penz 5d7de69ae6 fixed issue that the close-action for the split view has been applied to the inactive view instead of the active view
BUG: 167209

svn path=/trunk/KDE/kdebase/apps/; revision=836643
2008-07-22 17:36:52 +00:00
David Faure b5e97174d0 Code factorization: move "properties" action and slot to DolphinViewActionHandler.
svn path=/trunk/KDE/kdebase/apps/; revision=831148
2008-07-11 23:06:07 +00:00
Peter Penz 3bc3ca1458 Move the "Find File..." action from DolphinMainWindow to DolphinViewActionHandler, so that is used in DolphinPart and hence also in Konqueror. Thanks to Bram for the patch!
CCMAIL: bramschoenmakers@kde.nl
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=826383
2008-06-30 16:37:08 +00:00
Peter Penz b5de4d8ffb Don't disable the "Properties" action when no file is selected, just use the current folder as source. TODO: the code in DolphinPart::slotProperties() and DolphinMainWindow::properties() is quite similar -> move to DolphinViewActionHandler?
CCMAIL: faure@kde.org
BUG: 165311

svn path=/trunk/KDE/kdebase/apps/; revision=825846
2008-06-29 13:54:52 +00:00
Peter Penz cb32d720d1 provide Ctrl+T as alternative shortcut to Ctrl+Shift+N for "New Tab" like Konqueror
BUG: 165309

svn path=/trunk/KDE/kdebase/apps/; revision=825833
2008-06-29 13:36:53 +00:00
Peter Penz c446e29bc3 Don't check for "kompare" each time 2 items are selected (thanks to Andreas Scherf). As Albert Astals Cid pointed out it might be nicer to use a menu plugin instead of hardcoding "kompare" (> KDE 4.1).
CCMAIL: scherfa@arcor.de

svn path=/trunk/KDE/kdebase/apps/; revision=825587
2008-06-28 18:42:51 +00:00
Peter Penz c4f8d95a60 Move code for disabling the paste action into DolphinView::pasteInfo() -> Dolphin KPart now also is aware about the disabled paste action.
@David: Konqueror hides the paste action in the context menu now, but still the action in the edit menu stays enabled

CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=819116
2008-06-10 16:23:46 +00:00
Peter Penz ffe9bbacd9 disable the paste action if no writing is supported for the paste-destination
BUG: 161639

svn path=/trunk/KDE/kdebase/apps/; revision=818445
2008-06-08 15:20:19 +00:00
David Faure 3d28c53564 When "move_to_trash" is disabled and "delete" is enabled (e.g. non-local files),
enable a hidden action with Key_Del as shortcut, so that the user can press Del to delete the file.
BUG: 76016

svn path=/trunk/KDE/kdebase/apps/; revision=817389
2008-06-05 22:25:07 +00:00
George Goldberg 0a3a481ee2 Fix the edit-menu action disabling/enabling bug in dolphinpart finally! Also, move FileItemCapabilities from dolphin to KonqFileItemCapabilities at dfaure's request (making it implicitly shared along the way).
BUGS:161594

svn path=/trunk/KDE/kdebase/apps/; revision=815584
2008-06-02 10:07:13 +00:00
Peter Penz 70d1cb86e0 increase the readability of the code
svn path=/trunk/KDE/kdebase/apps/; revision=815420
2008-06-01 18:44:35 +00:00
George Goldberg 08dfefec38 Fix dolphin to only enable the Cut context menu option if the file capabilites supportsMoving().
CCBUGS: 161594

Still need to fix Send to trash Context Option in Konqueror

svn path=/trunk/KDE/kdebase/apps/; revision=815362
2008-06-01 15:16:27 +00:00
Peter Penz d326c746bc Assure that tabs always have a text. If the file name is empty, use the protocol instead. This fixes the issue that for "trash://" no text is shown in the tab.
svn path=/trunk/KDE/kdebase/apps/; revision=813844
2008-05-28 20:48:40 +00:00
James Richard Tyrer 8a891082f4 Adding icon name "tab-close-other" to replace "tab-close" where the action is to close other tabs.
svn path=/trunk/KDE/kdebase/apps/; revision=809235
2008-05-18 15:31:24 +00:00
Peter Penz 95ac842f29 A middle click on an item of the tree view panel should open the URL inside a new tab.
TODO: cleanup some obsolete signals/structure inside SidebarPage and TreeviewSidebarPage.

svn path=/trunk/KDE/kdebase/apps/; revision=806635
2008-05-11 21:51:04 +00:00
Peter Penz 57e3503e2f If the middle mouse button is pressed above an item of the places panel, open the URL inside a new tab.
svn path=/trunk/KDE/kdebase/apps/; revision=806606
2008-05-11 20:14:50 +00:00
David Faure fd98230020 Move "Adjust view properties" to dolphinviewactionhandler so that it's available in dolphinpart (konqueror) too.
Bug reported by kde-bug-hunter "lemma".

svn path=/trunk/KDE/kdebase/apps/; revision=804037
2008-05-04 21:16:30 +00:00
Peter Penz 5e36288789 Assure that after "Split View" has been executed, that the second view gets the focus instead of the first view.
BUG: 161365

svn path=/trunk/KDE/kdebase/apps/; revision=803984
2008-05-04 18:40:06 +00:00
David Faure 06e9ece821 KonqFileUndoManager moved to kdelibs, as KIO::FileUndoManager. Ported the code in libkonq+dolphin+konqueror.
svn path=/trunk/KDE/kdebase/apps/; revision=802881
2008-04-30 23:32:33 +00:00
Peter Penz a593ad0b99 let a double-click on the empty tab-area open a new tab (-> consistent with konsole behavior)
svn path=/trunk/KDE/kdebase/apps/; revision=800241
2008-04-23 18:28:23 +00:00
David Faure d1aaeab617 Fix bug with the UndoUiInterface usage: if more than one mainwindow was used, the statusbar of the wrong window could be used for displaying error messages from the undo manager.
svn path=/trunk/KDE/kdebase/apps/; revision=799250
2008-04-20 22:07:44 +00:00
Peter Penz 4e58afa1fd fixed some stupid bugs I did not see in the previous commit -> after 9 hours in the office and 3 hours Dolphin it seems I'm too tired :-(
svn path=/trunk/KDE/kdebase/apps/; revision=798677
2008-04-18 20:31:31 +00:00
Peter Penz 6ba12bacc7 consider the protocol and directory capabilities for file actions like Rename, Delete and Move To Trash
svn path=/trunk/KDE/kdebase/apps/; revision=798674
2008-04-18 20:21:21 +00:00
Peter Penz 50acc2d6ec fix possible crash when selecting "New Tab" from the tab context menu of an inactive tab
svn path=/trunk/KDE/kdebase/apps/; revision=797843
2008-04-16 21:27:39 +00:00
Peter Penz 12c1feb0c5 * provide context menu for tabs
* assure that the tab name is set to "/" for the root URL instead of using an empty string

svn path=/trunk/KDE/kdebase/apps/; revision=797725
2008-04-16 20:03:05 +00:00
Peter Penz 8cb8b51909 let Dolphin use the new tab-close-buttons
svn path=/trunk/KDE/kdebase/apps/; revision=797061
2008-04-14 20:19:17 +00:00
Peter Penz ac9e01f789 implemented functionality for closing tabs
svn path=/trunk/KDE/kdebase/apps/; revision=796587
2008-04-13 20:20:30 +00:00
Peter Penz 9d394f7a4a prevent flickering when switching between tabs having a split view
svn path=/trunk/KDE/kdebase/apps/; revision=796566
2008-04-13 19:18:54 +00:00
Peter Penz 9d1a8d98dd fixes for tabs:
* remember active view when having a split view inside a tab
* prevent a possible recursion when returning into a tab having a split view

svn path=/trunk/KDE/kdebase/apps/; revision=796563
2008-04-13 19:12:52 +00:00
Peter Penz 030a5d5433 when clicking with the middle mouse button on a directory, a new tab should be opened
svn path=/trunk/KDE/kdebase/apps/; revision=796116
2008-04-12 16:12:57 +00:00
Peter Penz 3b06c2120d "New Tab" menu + some related code ;-)
BUG: 143995

svn path=/trunk/KDE/kdebase/apps/; revision=796101
2008-04-12 15:09:46 +00:00
Peter Penz c33b01efb2 Move the pasteIntoFolder() method from the contextmenu into DolphinView. This allows to show the information inside the statusbar, that the paste operation has been completed (also some code duplication can be prevented by the way).
svn path=/trunk/KDE/kdebase/apps/; revision=791436
2008-03-29 14:54:56 +00:00
Luboš Luňák 2328577ac6 Append # to the object name (window role), KWin uses it for better
window grouping.


svn path=/trunk/KDE/kdebase/apps/; revision=788492
2008-03-21 17:24:06 +00:00
Peter Penz a47758bae5 show the Information Panel per default as discussed in core-devel
CCMAIL: jriddell@ubuntu.com

svn path=/trunk/KDE/kdebase/apps/; revision=788150
2008-03-20 21:10:27 +00:00
Chusslove Illich 428a5cacce Fix Krazy i18n issues.
svn path=/trunk/KDE/kdebase/apps/; revision=787308
2008-03-18 22:38:52 +00:00
Peter Penz e83c309781 remove unused signal
svn path=/trunk/KDE/kdebase/apps/; revision=784855
2008-03-12 17:07:42 +00:00
Peter Penz 74541a5d48 menu actions have not been updated correctly when changing between the split views (regression from KDE 4.0.1 to KDE 4.0.2)
BUG: 158317

svn path=/trunk/KDE/kdebase/apps/; revision=784853
2008-03-12 16:58:11 +00:00
Jeff Mitchell e8f247159e Don't try to show the terminal in dolphin when in Windows
svn path=/trunk/KDE/kdebase/apps/; revision=784126
2008-03-10 17:33:30 +00:00
Peter Penz eb7294fa10 minor cleanup: no need to create a slot which just invokes another method, just use the other method as slot
svn path=/trunk/KDE/kdebase/apps/; revision=778423
2008-02-23 15:48:56 +00:00
Peter Penz 98497a639a let F6 also select the whole text of the URL navigator to stay consistent with Konqueror and Firefox
BUG: 157589

svn path=/trunk/KDE/kdebase/apps/; revision=775977
2008-02-16 22:05:34 +00:00
Peter Penz f70b85b4ca Initially I thought it's better not having code as default value inside dolphin_generalsettings.kcfg. But the check for an empty home URL in DolphinMainWindow::init() must also be done when invoking GeneralSettings::setDefaults() in StartupSettingsPage, otherwise the home URL would get empty... Using QDir::homePath() as default-value inside the *.kcfg file prevents such issues.
CCMAIL: michael.a.oshea@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=775494
2008-02-15 23:13:47 +00:00
Peter Penz e43bc5a6f6 minor code cleanup
svn path=/trunk/KDE/kdebase/apps/; revision=775094
2008-02-14 21:25:36 +00:00
Peter Penz 57e2cd9ae9 ~ is no useful home folder in a Windows environment (thanks to Michael O'Shea for the patch!)
BUG: 156463
CCMAIL: michael.a.oshea@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=775056
2008-02-14 20:11:51 +00:00
David Faure a8a050952d Provide the "sort by" actions in dolphinpart (konqueror); share and simplify the code by connecting to the actiongroup's signal.
svn path=/trunk/KDE/kdebase/apps/; revision=774699
2008-02-13 20:52:21 +00:00