Commit graph

2944 commits

Author SHA1 Message Date
Peter Penz f60340508b Reset the file-item when the viewport is entered and files are selected. Otherwise the information of the file-item will be shown instead of the selection.
svn path=/trunk/KDE/kdebase/apps/; revision=1183544
2010-10-07 18:13:55 +00:00
Peter Penz 6751f6a52a Internal cleanups to assure that the asynchronous request for the folder-information works reliable when switching between directories.
svn path=/trunk/KDE/kdebase/apps/; revision=1183537
2010-10-07 18:00:58 +00:00
Peter Penz 431da0482c Internal cleanup for panels: Let the panel-implementations decide whether they accept an URL or not.
svn path=/trunk/KDE/kdebase/apps/; revision=1183480
2010-10-07 14:09:30 +00:00
Peter Penz 06b0569613 Ignore search-results in the treeview, as showing equal directory names without path makes no sense.
svn path=/trunk/KDE/kdebase/apps/; revision=1183472
2010-10-07 13:42:17 +00:00
Peter Penz 50294c7a3c Hide the text of the go-back, go-forward and view-mode actions per default when the text is shown alongside icons.
svn path=/trunk/KDE/kdebase/apps/; revision=1183466
2010-10-07 13:33:01 +00:00
Peter Penz a83876c44f Implement the actions "Open in New Window" and "Open in New Tab" for the case if no item is selected.
svn path=/trunk/KDE/kdebase/apps/; revision=1183222
2010-10-06 15:04:37 +00:00
Peter Penz d928089fd2 Restore the cursor if the URL has been changed. This assures that the pointing-hand cursor gets reset when changing the directory.
svn path=/trunk/KDE/kdebase/apps/; revision=1183219
2010-10-06 14:53:06 +00:00
Peter Penz ec861fd269 Apply the cursor asynchronously. This fixes the issue that a pointing-hand cursor is shown if the selection-toggle and the item are hovered at the same time.
svn path=/trunk/KDE/kdebase/apps/; revision=1183214
2010-10-06 14:42:48 +00:00
Peter Penz e2b844437e Use a pointing-hand cursor when hovering items as discussed on http://lists.kde.org/?l=kde-core-devel&m=126027946921686&w=1
svn path=/trunk/KDE/kdebase/apps/; revision=1183195
2010-10-06 13:58:47 +00:00
Frank Reininghaus 2297cbee2e Prevent that icons overlap in Details View when zooming.
The problem was that a maximum size was assigned to KFileItemDelegate
for displaying items without considering that icon zooming may change
the item height.

CCBUG: 234600

svn path=/trunk/KDE/kdebase/apps/; revision=1182797
2010-10-05 17:56:07 +00:00
Peter Penz 7437798a87 SVN_SILENT: Remove commented (and obsolete) code
svn path=/trunk/KDE/kdebase/apps/; revision=1182780
2010-10-05 16:44:38 +00:00
Peter Penz 3b2cd9c02e Fix minor regression resulted by the previous commit: The m_newName-member may only get updated after the OK-button has been pressed, otherwise renaming a single file fails.
svn path=/trunk/KDE/kdebase/apps/; revision=1182779
2010-10-05 16:38:00 +00:00
Peter Penz 828ba8902c - Integrate the patch from Matthias Fuchs from http://reviewboard.kde.org/r/5496 to allow having leading zeros when renaming files: E.g. Using the name "A ###.jpg" results in the filenames "A 001.jpg", "A 002.jpg"... The patch could be simplified a little bit by guaranting only one connective sequence of #'s.
- Move the renaming code into the RenameDialog

CCMAIL: mat69@gmx.net
BUG: 226761
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1182776
2010-10-05 16:30:03 +00:00
Peter Penz 7fcab3c783 Use "Open Path" instead of "Open Parent Folder", as the headline in the search-result is "Path".
svn path=/trunk/KDE/kdebase/apps/; revision=1182754
2010-10-05 14:40:42 +00:00
David Faure dbc6cb9a85 Make executable the Type=Application .desktop files we install,
so that they can be used even from a KDE running in another prefix (http://markmail.org/message/4p3krovtnzwx35zd)

svn path=/trunk/KDE/kdebase/apps/; revision=1182558
2010-10-04 22:55:09 +00:00
Peter Penz c98eebdfa3 Fix issue that no content is shown in the Information Panel on startup
svn path=/trunk/KDE/kdebase/apps/; revision=1180723
2010-09-28 17:51:20 +00:00
Peter Penz af98817d43 Fix issue that tooltip-labels might get clipped (this regression has been introduced by revision 1158057)
CCBUG: 241608


svn path=/trunk/KDE/kdebase/apps/; revision=1180693
2010-09-28 15:58:14 +00:00
Frank Reininghaus 732459f4e2 Use KStringHandler::preProcessWrap() when calculating the width of a
file name in DolphinFileItemDelegate. This makes sure that zero width
spaces (which prevent kerning) are added at the same places where
KFileItemDelegate adds them when actually rendering the name. Fixes
the problem that file names are elided and partly replaced by "..."
even though there is enough space for the full name.

CCBUG: 251121

svn path=/trunk/KDE/kdebase/apps/; revision=1179568
2010-09-25 22:01:05 +00:00
Peter Penz c5659d48b0 Fix icon-name for the filenamesearch protocol. This fixes the issue that an unknown-icon is shown when the search is done in a tab.
svn path=/trunk/KDE/kdebase/apps/; revision=1178364
2010-09-22 20:32:06 +00:00
Peter Penz 7f7bea872b If the context-menu is opened for a file shown as search result, offer the actions "Open Parent Folder in New Window" and "Open Parent Folder in New Tab"
svn path=/trunk/KDE/kdebase/apps/; revision=1178362
2010-09-22 20:24:49 +00:00
Peter Penz 5bb2a0f3c9 Unbelievable: I simply forgot to implement the Stop-action in Dolphin since KDE SC 4.0. Well better later than never: Done now :-)
BUG: 233836

svn path=/trunk/KDE/kdebase/apps/; revision=1178344
2010-09-22 19:39:46 +00:00
Peter Penz abefc8663a Add a small invisible margin to the selection toggle in case the item-height is nearly equal to the toggle-height. This prevents an accidental execution of application in the details-view with the default icon-size.
BUG: 169494
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1178332
2010-09-22 19:12:09 +00:00
Peter Penz 5517e4cf10 If 'remember view-properties' is selected, store the .directory files only if the directory is part of the home-path. Otherwise use the mirror in ~/.kde/share/apps/dolphin/view_properties to store the .directory file. This prevents conflicting view-properties if several users have write-access to a common directory.
BUG: 63347
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1178321
2010-09-22 18:10:45 +00:00
Peter Penz 1f45355b7d Fix issue, that the details-view has no size and date column in the following case:
- Use icons-view as default view
- Create a new directory
- Change view-properties of directory to show e.g. the owner
- Switch to the details-view

svn path=/trunk/KDE/kdebase/apps/; revision=1178311
2010-09-22 17:28:26 +00:00
Peter Penz 7d7ecaafb1 - Use less separators
- Move "Add to Places" action upwards


svn path=/trunk/KDE/kdebase/apps/; revision=1177960
2010-09-21 19:56:35 +00:00
Peter Penz bf8f150507 - DolphinViewContainer::url() returns an instance, not a reference
- GeneralSettings::homeUrl() returns a QString instance, not a KUrl reference

svn path=/trunk/KDE/kdebase/apps/; revision=1177958
2010-09-21 19:38:26 +00:00
Peter Penz 53dbea61bc Update the title of the tab when closing the second view in the split-mode. Thanks to
Enrique Alonso for analysing the root-cause! 

CCMAIL: enrique_alonso@igluk.com

svn path=/trunk/KDE/kdebase/apps/; revision=1177952
2010-09-21 19:30:26 +00:00
Peter Penz 801e28d7d6 SVN_SILENT: There is no plural for "information"
svn path=/trunk/KDE/kdebase/apps/; revision=1177951
2010-09-21 19:18:16 +00:00
Peter Penz 1e8e05e81f It was a bad idea to store the enabled additional-information as bit-values: With the current setup only up to 8 additional informations are possible. This restriction is bypassed now:
- Backward compatibility for old .directorry files is provided
- A version-information has been added for possible future changes
- As "side-effect" it also allows to have a details-view with only one column (#238140)

BUG: 238140
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1177944
2010-09-21 19:03:04 +00:00
Peter Penz fcef5f7721 Use K_GLOBAL_STATIC for the previously committed workaround to bypass a X11-issue in combination with KModifierKeyInfo. Thanks to David Faure for the hint.
svn path=/trunk/KDE/kdebase/apps/; revision=1177902
2010-09-21 16:18:20 +00:00
Script Kiddy d88f623969 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=1177799
2010-09-21 10:01:09 +00:00
Matthias Fuchs a934fd59bc Does not use bitwise operators on booleans. Thanks to dfaure for pointing it out.
svn path=/trunk/KDE/kdebase/apps/; revision=1177781
2010-09-21 09:31:04 +00:00
Matthias Fuchs b51083c12b Disables the rename button if no name or an identical name has been specified.
Checks for '#' in the case of renaming multiple files.

svn path=/trunk/KDE/kdebase/apps/; revision=1177675
2010-09-20 21:04:48 +00:00
Peter Penz c7e8c4af3d Workaround for a X11-issue in combination with KModifierKeyInfo: When constructing KModifierKeyInfo in the constructor of the context menu, the user interface might freeze. Thanks to Mark Gaiser for clarifying this with the KModifierKeyInfo maintainer and testing the workaround!
CCMAIL: markg85@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=1177658
2010-09-20 19:52:40 +00:00
Peter Penz 4822c2cc3b Remove the fixed-size workaround, only one action is used now in this case
svn path=/trunk/KDE/kdebase/apps/; revision=1176537
2010-09-17 22:59:37 +00:00
Peter Penz 23a4868dea - Fix issue, that the 'Move To Trash'-action or 'Delete'-action from the File menu get invisible
- Use KFileItemListProperties to check whether all selected URLs are local
- Coding style cleanups

CCMAIL: markg85@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=1176534
2010-09-17 22:23:11 +00:00
Peter Penz 9a55b0d704 There is no need to burden DolphinMainWindow with internals of the context-menu.
CCMAIL: markg85@gmail.com


svn path=/trunk/KDE/kdebase/apps/; revision=1176513
2010-09-17 21:16:56 +00:00
Mark Gaiser 304e9524b6 When you view the context menu of a file/folder and shift is pressed (and the delete action line is not enabled in the settings) then the
"Move to trash (del)" action gets replaced by the "Delete (shift del)" action and replaced back to "Move to trash (del)" when you release 
shift.

BUG: 194275

svn path=/trunk/KDE/kdebase/apps/; revision=1176493
2010-09-17 19:47:01 +00:00
Peter Penz 02c02a05c1 Show location in window title for non-local URLs. Thanks to Mark Gaiser for the patch and David Faure for the review on http://reviewboard.kde.org/r/5178.
BUG: 244512
FIXED-IN: 4.6.0

svn path=/trunk/KDE/kdebase/apps/; revision=1176395
2010-09-17 14:42:57 +00:00
Peter Penz 55739979a8 KDirModel takes ownership of the directory lister, so don't delete the directory lister manually.
BUG: 196681

svn path=/trunk/KDE/kdebase/apps/; revision=1176325
2010-09-17 11:24:06 +00:00
Script Kiddy 45d7ec30c4 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=1175951
2010-09-16 08:30:33 +00:00
Peter Penz 642cf1f8f5 Further optimizations for calculating the width of columns
svn path=/trunk/KDE/kdebase/apps/; revision=1171607
2010-09-04 17:23:05 +00:00
Peter Penz 0e4202843d The row-count cannot be 0 at this part of the code.
svn path=/trunk/KDE/kdebase/apps/; revision=1171602
2010-09-04 17:01:24 +00:00
Peter Penz f9554d6457 Use the size-hint provided by the item-delegate to calculate the required width of the columns. This assures that columns like "Path" are not clipped.
svn path=/trunk/KDE/kdebase/apps/; revision=1171601
2010-09-04 16:59:47 +00:00
Peter Penz bfdc7b4fa2 Never ignore the view-properties if "Use common view properties for all folders" has been set, otherwise the view-properties switch when searching files won't work. Originally this flag has been introduced when working with a split view, however I consider the behavior to always respect the view-properties when changing a folder more consistent anyway.
svn path=/trunk/KDE/kdebase/apps/; revision=1171589
2010-09-04 15:31:01 +00:00
Peter Penz d78c7bffb1 When searching for files, as default view the details view is used showing the path of the search result. The view still can be adjusted by the user of course.
svn path=/trunk/KDE/kdebase/apps/; revision=1171585
2010-09-04 15:14:53 +00:00
Peter Penz 1dfb2f385a Remove custom handling of wheel-events for tabs, this is done now in KTabBar
CCBUG: 248962


svn path=/trunk/KDE/kdebase/apps/; revision=1171577
2010-09-04 13:56:16 +00:00
Peter Penz e53ce0959f Fix issue that an old preview might be shown in a tooltip. Cool bug-id btw ;-)
CCBUG: 250000
FIXED-IN: 4.5.2

svn path=/trunk/KDE/kdebase/apps/; revision=1171569
2010-09-04 13:21:05 +00:00
David Faure 12f15322b3 Move dolphin's statusbar message-label (the one with support for errors and a close button) to libkonq
so that it can be used in konqueror as well. Fix its sizeHint. Reviewed by Peter Penz.

svn path=/trunk/KDE/kdebase/apps/; revision=1169901
2010-08-30 08:56:19 +00:00
Jonathan Michael Thomas efb1cd9cad Avoid the unnecessary construction of a KIconEffect by using the one provided by Dolphin's global KIconLoader
svn path=/trunk/KDE/kdebase/apps/; revision=1169558
2010-08-29 17:12:25 +00:00