Commit graph

281 commits

Author SHA1 Message Date
Peter Penz 8acb68ed28 Relayout of the settings dialog, so that all Dolphin KPart relevant settings can be made available in Konqueror's settings dialog too. Further cleanups and layout fixes are required and will be done during the next week.
svn path=/trunk/KDE/kdebase/apps/; revision=912587
2009-01-17 18:42:06 +00:00
Peter Penz 6d6ac58d3f provide icons for "Places", "Folders", "Information" and "Terminal" actions, so that they can be added to the toolbar
BUG: 180847

svn path=/trunk/KDE/kdebase/apps/; revision=911845
2009-01-16 09:54:55 +00:00
Peter Penz f37ecd6ecf Cleanup panel related class names: The terms "sidebar"/"sidebarpage" are relicts from the KDE 3 version of Dolphin and are called "Panels" in the KDE 4 version of Dolphin. Yes, renaming classes may take more than 1 year ;-)
svn path=/trunk/KDE/kdebase/apps/; revision=911089
2009-01-14 20:14:36 +00:00
Peter Penz 307285e963 Group classes into folders, Dolphin is too big in the meantime for having a flat directory hierarchy. dolphin/src/CMakeLists.txt will be cleaned up later.
svn path=/trunk/KDE/kdebase/apps/; revision=911065
2009-01-14 19:26:23 +00:00
Peter Penz 86d9c40ab7 prevent that the user can open more than one instance of the settings dialog
svn path=/trunk/KDE/kdebase/apps/; revision=910588
2009-01-13 18:06:15 +00:00
Peter Penz 6d2904ec48 add action "Close Tab" to the file menu, so that users get the chance to discover the key shortcut
svn path=/trunk/KDE/kdebase/apps/; revision=909450
2009-01-11 16:28:42 +00:00
Peter Penz db5ee5f2a6 raise() and activateWindow() are not needed in this case
svn path=/trunk/KDE/kdebase/apps/; revision=908812
2009-01-10 14:27:07 +00:00
Peter Penz e931b21216 there is no reason that the settings dialog is modal...
BUG: 179757

svn path=/trunk/KDE/kdebase/apps/; revision=908577
2009-01-09 22:56:24 +00:00
Peter Penz 3b4e44d6da if "split view" is used as startup setting, also open new tabs in the split view mode
BUG: 176980

svn path=/trunk/KDE/kdebase/apps/; revision=896206
2008-12-12 20:30:23 +00:00
Peter Penz 85aec92f81 SVN_SILENT: removed trailing spaces
svn path=/trunk/KDE/kdebase/apps/; revision=895978
2008-12-12 06:55:26 +00:00
Peter Penz fe06efe734 open the tab in the background when "Open in new tab" is selected with the context menu (-> consistent behavior with middle click)
svn path=/trunk/KDE/kdebase/apps/; revision=891716
2008-12-02 18:36:42 +00:00
Peter Penz da5f59b3bb * assure that the keyboard focus is in the view when switching between tabs
* assure that the URL navigator gets the focus when it is editable and a new tab is opened by File -> New Tab 

BUG: 174594

svn path=/trunk/KDE/kdebase/apps/; revision=891367
2008-12-01 20:56:00 +00:00
Peter Penz f542da84a2 Disable the "quick view" feature: I like the Previewer plasmoid, but I think after a few months of trying to use it there is no need for having a separate menu entry (shortcut: CTRL+Return) in Dolphin: Doing a drag & drop operation to the previewer plasmoid is faster than selecting a file and pressing CTRL+Return (or selecting the menu entry). Using "Space" as shortcut conflicts with the Terminal and is still slower than simply just opening the file...
The i18n() string is still part of the code, so that it could be reactivated during the 4.2 cycle.

svn path=/trunk/KDE/kdebase/apps/; revision=886672
2008-11-19 20:09:51 +00:00
Peter Penz 1743e4b1fa provide a 'Create New' entry for a context menu above a directory
BUG: 169880

svn path=/trunk/KDE/kdebase/apps/; revision=884373
2008-11-14 19:51:13 +00:00
Peter Penz c0fd7f2a19 * show an error message instead of an information message when an invalid dragging is done
* show an error message if a folder is dropped on to itself

svn path=/trunk/KDE/kdebase/apps/; revision=883836
2008-11-13 17:22:35 +00:00
Peter Penz a7838db28e * implement the DragAndDropHelper as singleton derived from QObject, so that emitting of signals is possible
* show an information message in the statusbar, if items are dragged into the same directory

TODO: although the signal seems to get connected correctly, the slot DolphinMainWindow::showInformationMessage() is not invoked when the signal is emitted -> will debug this later, it is important that the new string is added before the message freeze

svn path=/trunk/KDE/kdebase/apps/; revision=881627
2008-11-08 16:22:30 +00:00
Peter Penz b1aadb8cce If the context menu is opened above a directory, add the actions "Open in New Window" and "Open in New Tab" to the context menu.
Thanks to Mathias Soeken for the patch!

CCMAIL: msoeken@tzi.de

svn path=/trunk/KDE/kdebase/apps/; revision=875711
2008-10-25 10:32:55 +00:00
Peter Penz 5d69f066db * renamed "[x] Show Full Location" to "[x] Editable Location"
* renamed "Edit Location" to "Replace Location"

svn path=/trunk/KDE/kdebase/apps/; revision=875699
2008-10-25 09:41:39 +00:00
Peter Penz 6efdfda500 SVN_SILENT: minor coding style fixes
svn path=/trunk/KDE/kdebase/apps/; revision=875696
2008-10-25 09:21:20 +00:00
Mathias Soeken 75bf8edaeb You can now switch the tabs in dolphin via keyboard shortcuts like in konqueror
svn path=/trunk/KDE/kdebase/apps/; revision=875689
2008-10-25 09:00:28 +00:00
Peter Penz e7bd514a39 * Move code from DolphinDropController to DragAndDropHelper.
* Move code which checks whether the dragging of a MIME type is supported to DragAndDropHelper. This allows adding an improved support for dropping compressed files from Ark to Dolphin later...

CCMAIL: haraldhv@stud.ntnu.no

svn path=/trunk/KDE/kdebase/apps/; revision=875611
2008-10-24 22:19:23 +00:00
Peter Penz e0bef260da Assure that the docks get informed about an URL change before the GUI is setup (thanks to Frank Reininghaus for the patch!). This prevents that slots from the docks are called with invalid URLs.
BUG: 169103
CCMAIL: frankreininghaus@web.de>

svn path=/trunk/KDE/kdebase/apps/; revision=871525
2008-10-15 06:03:41 +00:00
Peter Penz c617050efb improvement to previous commit: check whether the URL can be listed by asking the protocol manager (thanks to David Faure for the hint)
svn path=/trunk/KDE/kdebase/apps/; revision=869022
2008-10-07 22:05:55 +00:00
Peter Penz 0ee9ee0ea8 If an URL cannot be listed, just let the view and the panels show the last listable URL. This prevents having an empty view and empty panels when typing a wrong URL.
BUG: 170695

svn path=/trunk/KDE/kdebase/apps/; revision=868984
2008-10-07 20:29:18 +00:00
Peter Penz 84f25c4503 when changing the settings it is necessary to refresh all tabs, not only the active tab
svn path=/trunk/KDE/kdebase/apps/; revision=868952
2008-10-07 18:37:59 +00:00
Peter Penz d89548a828 allow to configure whether the zoom slider and/or the space information should be shown in the statusbar
svn path=/trunk/KDE/kdebase/apps/; revision=868596
2008-10-06 18:15:53 +00:00
Peter Penz aa0b09dac4 * adjusted Dolphin to use KonqOperations::doDrop() instead of using a custom implementation
* used new signals jobRecordingStarted() and jobRecordingFinished from FileUndoManager to inform the user in the statusbar when a recorded command has been finished

svn path=/trunk/KDE/kdebase/apps/; revision=866777
2008-10-01 21:39:35 +00:00
David Faure 62afe1570e Fix connect.
But the one in dolphinviewcontainer (connecting to the kurlnavigator slot urlsDropped) still fails,
since it has no QDropEvent. Not sure what's the plan there.
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=866046
2008-09-29 21:00:34 +00:00
Peter Penz 0382f24544 Use KonqOperations::doDrop() instead of a custom dropping code. Still some minor issues are open (Dolphin currently gets no feedback anymore when the operations have been finished), but they will be solved during the next week.
BUG: 168154

svn path=/trunk/KDE/kdebase/apps/; revision=865708
2008-09-28 18:38:00 +00:00
Peter Penz 41dfbdf3d9 Fixed issue that the "Show Menu Bar" state is not updated correctly (workaround for bug #171080). Patch has been provided by Laurens Vanhove.
svn path=/trunk/KDE/kdebase/apps/; revision=863909
2008-09-23 13:04:46 +00:00
Peter Penz 5babb62366 don't use SPACE as shortcut for Quick View, as this conflicts with the Terminal Panel
svn path=/trunk/KDE/kdebase/apps/; revision=857151
2008-09-04 20:11:14 +00:00
Rafael Fernández López 0bca190b0e Booo... false alarm. After going to the XMLGUI code this is perfect. I also wonder why call to setAutoSaveSettings when using Save flag, and why createGUI when using Create flag, is what setupGUI
internally is doing indeed. So nah, going back and removing those unnecessary calls. Now user preferences on toolbar places and sizes of icons are obeyed.

CCMAIL: peter.penz@gmx.at
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=853002
2008-08-26 23:51:05 +00:00
Rafael Fernández López 78b45e3d6a Do not create with Save flag. OMG, this is a very bad problem of XMLGUI... if you set that flag (which needs to be done
before createGUI, it will go to setAutoSaveSettings from KMainWindow, which will apply the personal preferences of
toolbars etc... of a NON EXISTANT GUI !. So take out this parameter from here... since we are calling anyway
setAutoSaveSettings couple lines after. I wonder if we should encourage people to not use Save flag, or we should fix
this into XMLGUI.

CCMAIL: peter.penz@gmx.at
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=852998
2008-08-26 23:42:53 +00:00
Sascha Peilicke 817f3952e2 Fix for show_filter_bar action of tools-menu, which is not correctly set (when the corresponding option is checked in the startupsettingsview) at application start-up.
svn path=/trunk/KDE/kdebase/apps/; revision=846896
2008-08-14 10:12:32 +00:00
Peter Penz 00afeea5f5 Activate the tab when an item is dragged above an inactive tab. Thanks to Dmitry Khlystov for the patch!
BUG: 164312

svn path=/trunk/KDE/kdebase/apps/; revision=846009
2008-08-12 19:22:38 +00:00
Peter Penz b354c7503d Assure that the "Close Tab" action gets disabled when only one tab is open.
BUG: 168904

svn path=/trunk/KDE/kdebase/apps/; revision=845995
2008-08-12 18:59:25 +00:00
Alex Merry c167ffbb4f We want to change the tab, not just the view.
Fixes the issue: open three tabs.  Select the second one and close it.  Now right tab is active, but content for left tab is shown.

Will backport to 4.1.

CCMAIL: peter.penz@gmx.at


svn path=/trunk/KDE/kdebase/apps/; revision=839877
2008-07-31 01:02:52 +00:00
Peter Penz 4759321fdd forgot to remove unused variable in last commit
svn path=/trunk/KDE/kdebase/apps/; revision=838119
2008-07-26 19:23:20 +00:00
Peter Penz 8d189f44c4 use DBus interface instead of KRun::runCommand()
svn path=/trunk/KDE/kdebase/apps/; revision=838112
2008-07-26 19:09:17 +00:00
Peter Penz a07ea82381 Provide a "Quick View" in the Tools menu, which uses the Previewer plasmoid.
TODO 1: use the D-Bus interface directly instead of using KRun::runCommand() as workaround.

TODO 2: a new icon would be necessary

CCMAIL: alediaferia@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=838039
2008-07-26 13:49:50 +00:00
Peter Penz 5d7de69ae6 fixed issue that the close-action for the split view has been applied to the inactive view instead of the active view
BUG: 167209

svn path=/trunk/KDE/kdebase/apps/; revision=836643
2008-07-22 17:36:52 +00:00
David Faure b5e97174d0 Code factorization: move "properties" action and slot to DolphinViewActionHandler.
svn path=/trunk/KDE/kdebase/apps/; revision=831148
2008-07-11 23:06:07 +00:00
Peter Penz 3bc3ca1458 Move the "Find File..." action from DolphinMainWindow to DolphinViewActionHandler, so that is used in DolphinPart and hence also in Konqueror. Thanks to Bram for the patch!
CCMAIL: bramschoenmakers@kde.nl
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=826383
2008-06-30 16:37:08 +00:00
Peter Penz b5de4d8ffb Don't disable the "Properties" action when no file is selected, just use the current folder as source. TODO: the code in DolphinPart::slotProperties() and DolphinMainWindow::properties() is quite similar -> move to DolphinViewActionHandler?
CCMAIL: faure@kde.org
BUG: 165311

svn path=/trunk/KDE/kdebase/apps/; revision=825846
2008-06-29 13:54:52 +00:00
Peter Penz cb32d720d1 provide Ctrl+T as alternative shortcut to Ctrl+Shift+N for "New Tab" like Konqueror
BUG: 165309

svn path=/trunk/KDE/kdebase/apps/; revision=825833
2008-06-29 13:36:53 +00:00
Peter Penz c446e29bc3 Don't check for "kompare" each time 2 items are selected (thanks to Andreas Scherf). As Albert Astals Cid pointed out it might be nicer to use a menu plugin instead of hardcoding "kompare" (> KDE 4.1).
CCMAIL: scherfa@arcor.de

svn path=/trunk/KDE/kdebase/apps/; revision=825587
2008-06-28 18:42:51 +00:00
Peter Penz c4f8d95a60 Move code for disabling the paste action into DolphinView::pasteInfo() -> Dolphin KPart now also is aware about the disabled paste action.
@David: Konqueror hides the paste action in the context menu now, but still the action in the edit menu stays enabled

CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=819116
2008-06-10 16:23:46 +00:00
Peter Penz ffe9bbacd9 disable the paste action if no writing is supported for the paste-destination
BUG: 161639

svn path=/trunk/KDE/kdebase/apps/; revision=818445
2008-06-08 15:20:19 +00:00
David Faure 3d28c53564 When "move_to_trash" is disabled and "delete" is enabled (e.g. non-local files),
enable a hidden action with Key_Del as shortcut, so that the user can press Del to delete the file.
BUG: 76016

svn path=/trunk/KDE/kdebase/apps/; revision=817389
2008-06-05 22:25:07 +00:00
George Goldberg 0a3a481ee2 Fix the edit-menu action disabling/enabling bug in dolphinpart finally! Also, move FileItemCapabilities from dolphin to KonqFileItemCapabilities at dfaure's request (making it implicitly shared along the way).
BUGS:161594

svn path=/trunk/KDE/kdebase/apps/; revision=815584
2008-06-02 10:07:13 +00:00