Commit graph

61 commits

Author SHA1 Message Date
George Goldberg df7c2385ec Fix dolphinpart context menu so that the delete/rename/send to trash options are disabled when the directory containing the selected files/dirs is not writable.
CCBUGS: 161594

Issues remaining: Send to trash should be disabled on remote files (and replaced with delete) and edit menu of konqueror still has the actions like cut/delete/rename always enabled.

svn path=/trunk/KDE/kdebase/apps/; revision=815517
2008-06-02 02:50:36 +00:00
David Faure 707f9a9409 Handle redirections (e.g. from fish://localhost) without breaking the column view -- thanks Peter for the advice on how to separate the two cleanly.
svn path=/trunk/KDE/kdebase/apps/; revision=813954
2008-05-28 23:07:09 +00:00
Peter Penz d4287eb8e3 allow Konqueror to open also files inside a new tab, not only directories
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=805184
2008-05-07 20:02:37 +00:00
David Faure ba509a3be3 Re-enable name filtering (e.g. /home/dfaure/*.txt) in konqueror
svn path=/trunk/KDE/kdebase/apps/; revision=804094
2008-05-05 00:42:33 +00:00
David Faure 5ad129ac78 Ooops, fix name of componentdata so that the dolphinpart GUI is found again.
svn path=/trunk/KDE/kdebase/apps/; revision=804036
2008-05-04 21:15:14 +00:00
David Faure 439fa3c474 don't allow to trash files which are inside trash:/ already
svn path=/trunk/KDE/kdebase/apps/; revision=801853
2008-04-27 22:35:49 +00:00
Peter Penz 2a4f4c4b9c provide middle-mouse-button support for Konqueror (= create new window or tab)
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=800298
2008-04-23 20:57:58 +00:00
David Faure fcafd387f7 Ported dolphinpart to K_PLUGIN_FACTORY
Ported konqueror's part loading to KPluginLoader. Factorized some code into a tryLoadingService.
If you miss some khtml actions, update kdelibs/kdecore/util.

svn path=/trunk/KDE/kdebase/apps/; revision=798291
2008-04-17 21:49:53 +00:00
David Faure 71b626b358 Load plugins at the end of the ctor, so that everything is set up already. Will improve the Part API to make this easier.
svn path=/trunk/KDE/kdebase/apps/; revision=795466
2008-04-10 11:51:30 +00:00
Laurent Montel 60f40aaa4d Readd as in libkonq "part" this signal ""aboutToOpenURL""
used to signal to plugins kdirfilter that url changed

svn path=/trunk/KDE/kdebase/apps/; revision=795079
2008-04-09 07:02:55 +00:00
Peter Penz 03f4481bdf assure that the Dolphin KPart inside Konqueror gets updated when the settings are changed
svn path=/trunk/KDE/kdebase/apps/; revision=792496
2008-04-01 11:00:27 +00:00
Rafael Fernández López 7244399154 Fix a crash when right clicking on the viewport and no items selected.
CCMAIL: edulix@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=782768
2008-03-05 22:25:01 +00:00
Norbert Frese 7a1992e86b Make Konqueror and Dolphin use the new KFileItem::targetUrl() method.
svn path=/trunk/KDE/kdebase/apps/; revision=782396
2008-03-05 00:17:53 +00:00
Eduardo Robles Elvira 488ab56d0a Bugfix for konqueror for in dolphin: open in new tab/window opens one of the selected files
(See email sent to kfm-devel for details)
CCMAIL:kfm-devel@kde.org


svn path=/trunk/KDE/kdebase/apps/; revision=782282
2008-03-04 19:14:15 +00:00
Bill Egert ff32f4c1c4 No longer use Obsolete Member for QWidget:
topLevelWidget() => window() 

svn path=/trunk/KDE/kdebase/apps/; revision=776408
2008-02-18 01:06:50 +00:00
David Faure a8a050952d Provide the "sort by" actions in dolphinpart (konqueror); share and simplify the code by connecting to the actiongroup's signal.
svn path=/trunk/KDE/kdebase/apps/; revision=774699
2008-02-13 20:52:21 +00:00
David Faure 804a196700 Provide the dolphinpart view modes (Icons, Details, Columns) in konqueror's View Modes menu.
(this is done using a Q_PROPERTY in the dolphin part and a signal; the available view modes for creating the menu in the first place are listed in dolphinpart.desktop)
Konqueror: cleaned up the old (complex) handling of view modes as N toolbar buttons from M services grouped by library (240 lines less!).
Dolphin: moved view mode handling to DolphinViewActionHandler, removes duplication between part and mainwindow.

svn path=/trunk/KDE/kdebase/apps/; revision=774646
2008-02-13 18:45:20 +00:00
David Faure 45a1074b0a Factorize all the view-related action handling to DolphinViewActionHandler, to remove code duplication between mainwindow and part, and to remove my code-splitting with the static createFooAction methods in the view.
svn path=/branches/KDE/4.0/kdebase/apps/; revision=773570
2008-02-11 12:34:48 +00:00
David Faure cdc40d4398 Centralize three more actions so that they are available in DolphinPart: 'Show preview' 'Show hidden files' 'Categorized sorting'
Found a way of sharing the actions with even less code duplication, discussed it with Peter, but this will be for after 4.0.1

svn path=/branches/KDE/4.0/kdebase/apps/; revision=767566
2008-01-28 11:33:49 +00:00
David Faure e6dcf5e8ff And finally: provide those "additional info" actions in the part too.
svn path=/branches/KDE/4.0/kdebase/apps/; revision=764549
2008-01-22 01:36:28 +00:00
David Faure af333d9c7a Make sort/descending available in dolphinpart
svn path=/branches/KDE/4.0/kdebase/apps/; revision=764444
2008-01-21 19:42:16 +00:00
David Faure c00478bbc1 Revert the moving of the action to the DolphinView instance, this doesn't work with splitted views.
(Each view would need its own action collection, but then DolphinView would have to become
a KXMLGUIClient, and the GUI would flicker when switching views).

Instead, use the same solution as the other shared actions: static method in DolphinView (for now),
slot in the mainwindow (and for the more complex actions than this one, shared code in DolphinView)

svn path=/branches/KDE/4.0/kdebase/apps/; revision=764429
2008-01-21 19:08:52 +00:00
David Faure f9aeb825c6 merge -c764347 by Peter, needed for dolphinpart bugfixing
svn path=/branches/KDE/4.0/kdebase/apps/; revision=764379
2008-01-21 16:12:25 +00:00
André Wöbbeking baed5a65d4 make sure that other apps using this part find Dolphin's view-file-columns icons
svn path=/branches/KDE/4.0/kdebase/apps/; revision=761729
2008-01-15 11:09:56 +00:00
David Faure ac2e0e2d54 Make it possible to run applications from the applications:/ kioslave again.
svn path=/branches/KDE/4.0/kdebase/apps/; revision=757231
2008-01-04 14:40:31 +00:00
Jakob Petsovits 597b083dbc Icon naming spec compliance (code changes - KDE/):
drive-remote -> folder-remote

Seems like all of the drive-remote occurrences in SVN
make a perfect fit for being replaced by folder-remote
(which is specified by the naming spec).

svn path=/trunk/KDE/kdebase/apps/; revision=752590
2007-12-25 00:43:40 +00:00
David Faure 8eed64171c Move (broken) action "Edit/Properties" to dolphinpart and made it work there.
Pass parent widget to all KPropertiesDialog instances.

svn path=/trunk/KDE/kdebase/apps/; revision=752542
2007-12-24 19:07:32 +00:00
David Faure 728ecea4a1 Move (broken) editMimeType action from konqueror to dolphinpart (and made it work there)
svn path=/trunk/KDE/kdebase/apps/; revision=752422
2007-12-24 11:50:08 +00:00
David Faure 5a3a5f5135 Move a bunch of Go menu actions from konqueror to dolphinpart, so that they don't clutter the Go menu when using other parts. As posted on k-c-d.
svn path=/trunk/KDE/kdebase/apps/; revision=752408
2007-12-24 11:17:16 +00:00
David Faure d56ae4eda3 If we should open the URL right away, then let's do it right away.
We can tell konqueror afterwards by using the openUrlNotify() signal.

Note: this design bit is a bit strange; the controller has urlChanged() and requestUrlChange(),
but they are both channeled to DolphinView::urlChanged(), which means the recipient has
to figure out if the url change was already done or not, with "if (m_view->url() != url)".
Wouldn't it be simpler to just have both signals coming out of DolphinView?
(but some receivers like the view container don't seem to care which one was emitted... strange)

CCMAIL: peter.penz@gmx.at, ereslibre@kde.org
CCBUG: 154053

svn path=/trunk/KDE/kdebase/apps/; revision=750996
2007-12-20 20:44:58 +00:00
Rafael Fernández López c2d9d9beca Fix the problem with the column views.
BUG: 154053
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=750749
2007-12-20 00:08:17 +00:00
David Faure 609ce09292 Moving code around in dolphin fixes DnD support in konqueror :)
svn path=/trunk/KDE/kdebase/apps/; revision=748476
2007-12-14 15:53:40 +00:00
Jakub Stachowski 51e6281fe8 When listing already visited dir, completed() would be emitted from within setUrl, before
emit started(0) making konq logo spinning indefinitely.


svn path=/trunk/KDE/kdebase/apps/; revision=742730
2007-11-28 19:44:44 +00:00
Albert Astals Cid 19a3216a0c and now the correct fix by master dfaure
svn path=/trunk/KDE/kdebase/apps/; revision=740707
2007-11-23 23:29:45 +00:00
Albert Astals Cid 52f20900d6 Ahhh, fixing the bugs you report, that rocks ;-)
Insert the dolphin catalog so the messages appear translated correctly when eg, embedded into konqueror

BUG: 152752

svn path=/trunk/KDE/kdebase/apps/; revision=740701
2007-11-23 22:54:12 +00:00
David Faure 71f5520898 Move F10 (create directory) shortcut from konq to dolphinpart.
About all those filemanagement feature moves: I double checked and the other inode/directory parts are cervisia (need own file-related operations for VCS support), konsole (no gui), kfilereplacepart (no mkdir) and fsview (readonly). So better unbloat konq itself.

svn path=/trunk/KDE/kdebase/apps/; revision=740491
2007-11-23 11:50:00 +00:00
David Faure afe7ee8583 Moved popupmenu logic for trash+del to dolphinpart
svn path=/trunk/KDE/kdebase/apps/; revision=737696
2007-11-17 00:53:45 +00:00
David Faure 8578ad1e75 Fix "delete" and "move to trash" actions in dolphinpart; moved all logic for those out of konqueror.
Inside dolphin, the usual: moving code to DolphinView.
Pressing shift while clicking on "Move to Trash" in konq (dolphinpart) offers to delete, as in kde3 (this bit of logic might be good for dolphin itself too? see DolphinPart::slotTrashActivated)
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=737682
2007-11-17 00:08:54 +00:00
David Faure f8302197da Implement cut/copy/paste in dolphinpart.
Had to move more code to DolphinView, to use it from the part.

svn path=/trunk/KDE/kdebase/apps/; revision=737203
2007-11-15 20:04:05 +00:00
David Faure da8dc77c53 fix crash when pressing F2 on startup
enable undo

svn path=/trunk/KDE/kdebase/apps/; revision=737159
2007-11-15 17:16:17 +00:00
David Faure 53d65e6392 Implement renaming in dolphinpart.
No more rename action provided by konqueror, the part provides it now.
Had to move a bit of code around in dolphin, as discussed with Peter.

svn path=/trunk/KDE/kdebase/apps/; revision=737121
2007-11-15 14:59:02 +00:00
David Faure 2a3035088b Fix the other bug reported by BCoppens: the tab title was the full path, until switching tabs and back, then it changed to just the dir name (as it should be, in fact).
The logic in KonqView::setCaption was being confused by the part url still being empty; let's do things in the right order here.
+ .rc cleanups

svn path=/trunk/KDE/kdebase/apps/; revision=735495
2007-11-11 21:03:59 +00:00
Peter Penz 2a0ab25c1b Fixed issue that within Konqueror changing the active column from the column-view is ignored. From the hosts point of view this has to be handled like an URL change.
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=728394
2007-10-23 07:10:51 +00:00
David Faure 8d4fb36089 DolphinPart: provide a way to switch between view modes in konqueror.
Factorized those actions between dolphinmainwindow and dolphinpart (see new methods in dolphinview), and simplified mainwindow code by using the signal from the action group and the QVariant data of the actions (standard Qt4 solution for a group of actions).

svn path=/trunk/KDE/kdebase/apps/; revision=723871
2007-10-10 23:01:35 +00:00
Peter Penz ba150e5735 replace QList<KFileItem> by KFileItemList, as KFileItemList is not QList<KFileItem*> anymore since todays update of kfileitem.* in kdelibs
svn path=/trunk/KDE/kdebase/apps/; revision=720234
2007-10-02 19:03:03 +00:00
David Faure dd34d651b5 Ported KonqPopupMenu away from xmlgui to make things debuggable (we had code that dynamically created XML, and then passed it for gui merging with KonqPopupMenu's own generated XML, that was too much magic and headaches).
There are now unit tests for KonqPopupMenu, and its code has a bit less magic hacks than before.
There is no more KonqPopupMenuPlugin though, but I'm happy to re-create it once there's a real use case for it.

svn path=/trunk/KDE/kdebase/apps/; revision=719676
2007-10-01 17:06:34 +00:00
Tobias Koenig 29a1b26421 Making KFileItemList value based.
svn path=/trunk/KDE/kdebase/apps/; revision=719514
2007-10-01 08:00:48 +00:00
David Faure f78bac9909 Pass ref instead of pointer in mouseOverInfo signal
svn path=/trunk/KDE/kdebase/apps/; revision=716256
2007-09-24 10:55:55 +00:00
David Faure ce3ec0d0e6 Fix crash in dolphinpart when doing RMB on viewport.
Clean up unnecessary use of Q3ValueList.

svn path=/trunk/KDE/kdebase/apps/; revision=714532
2007-09-19 20:33:28 +00:00
Rafael Fernández López c8072005fa Create the new architecture for KCategorizedView. Now DolphinModel is created, inheriting KDirModel for returning valid data for the role of the category of
an item. DolphinSortFilterProxyModel implements now methods lessThanCategoryMethod and lessThanGeneralMethod from KCategorizedSortFilterProxyModel.

The only thing that needs to be adapted is the keyboard navigation on the KCategorizedView.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=713319
2007-09-17 04:02:17 +00:00