kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-12 12:54:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

If we should open the URL right away, then let's do it right away.

Browse source 
We can tell konqueror afterwards by using the openUrlNotify() signal.

Note: this design bit is a bit strange; the controller has urlChanged() and requestUrlChange(),
but they are both channeled to DolphinView::urlChanged(), which means the recipient has
to figure out if the url change was already done or not, with "if (m_view->url() != url)".
Wouldn't it be simpler to just have both signals coming out of DolphinView?
(but some receivers like the view container don't seem to care which one was emitted... strange)

CCMAIL: peter.penz@gmx.at, ereslibre@kde.org
CCBUG: 154053

svn path=/trunk/KDE/kdebase/apps/; revision=750996
This commit is contained in:
David Faure 2007-12-20 20:44:58 +00:00
parent 15bf954906
commit d56ae4eda3
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/dolphinpart.cpp
View file

@ -319,8 +319,8 @@ void DolphinPart::slotUrlChanged(const KUrl& url)
if (m_view->url() != url) {
// If the view URL is not equal to 'url', then an inner URL change has
// been done (e. g. by activating an existing column in the column view).
// From the hosts point of view this must be handled like changing the URL.
emit m_extension->openUrlRequestDelayed(url, KParts::OpenUrlArguments(), KParts::BrowserArguments());
openUrl(url);
emit m_extension->openUrlNotify();
}
}