Commit graph

619 commits

Author SHA1 Message Date
Script Kiddy d13740a367 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=681471
2007-06-29 04:24:44 +00:00
Rafael Fernández López fc49fd7b09 Better drawing when big selection rect is drawn.
svn path=/trunk/KDE/kdebase/apps/; revision=681460
2007-06-29 01:19:56 +00:00
Rafael Fernández López 71680def7f ++optimization
svn path=/trunk/KDE/kdebase/apps/; revision=681449
2007-06-28 23:29:47 +00:00
Rafael Fernández López 123e5008ae What is faster ? the eye or the brain ?
svn path=/trunk/KDE/kdebase/apps/; revision=681443
2007-06-28 23:03:00 +00:00
Peter Penz 8c32c621ad don't request the activation of the active URL on the mouse press event, as the sub folder will be opened on the release event...
svn path=/trunk/KDE/kdebase/apps/; revision=681376
2007-06-28 19:01:12 +00:00
Peter Penz 34ff90696f Improve handling of column view:
* Activate column on a mouse press event
* Always synchronize the active column with the URL navigator and vice versa

svn path=/trunk/KDE/kdebase/apps/; revision=681369
2007-06-28 18:52:54 +00:00
Rafael Fernández López ba6c853219 Add needed method for keyboard navigation
svn path=/trunk/KDE/kdebase/apps/; revision=681118
2007-06-27 23:23:41 +00:00
Peter Penz c05153ac9b don't connect to the activated() signal, just use singleClick() and doubleClick() dependent from the global KDE single/double click setting
svn path=/trunk/KDE/kdebase/apps/; revision=680990
2007-06-27 17:03:51 +00:00
Peter Penz 3e5f57127d connecting the the activated() signal does not work when using the double click setting within KDE
svn path=/trunk/KDE/kdebase/apps/; revision=680989
2007-06-27 17:02:55 +00:00
Rafael Fernández López b5f2d46ef9 activated signal actually does that :)
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=680979
2007-06-27 16:28:39 +00:00
Peter Penz afc732d220 Fix the following reproducible crash in a slightly different way (reported + initial fix done by Rafael):
* Open Dolphin. Enable categorization.
* Split the view. Disable categorization on the right one.
* Join the views.

CCMAIL: ereslibre@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=680956
2007-06-27 15:15:29 +00:00
Script Kiddy 4ad537ce4f SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=680810
2007-06-27 05:24:25 +00:00
Rafael Fernández López 8cc6f7c0c7 Boost group selections and remove unnecessary stuff.
svn path=/trunk/KDE/kdebase/apps/; revision=680656
2007-06-26 20:33:21 +00:00
Rafael Fernández López a6132b67fd Improve behavior when changes are detected on the model.
svn path=/trunk/KDE/kdebase/apps/; revision=680643
2007-06-26 19:52:45 +00:00
Rafael Fernández López d1aa2eb180 Fancy dragged items. There are two bad parts of this story: the hardcoded value of
the opacity and the break-of-unification between QListView and KListView. This 
will be removed for sure, just for testing reasons.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=680555
2007-06-26 14:32:42 +00:00
Rafael Fernández López 964d7125b2 Faster selections
svn path=/trunk/KDE/kdebase/apps/; revision=680550
2007-06-26 14:23:44 +00:00
Rafael Fernández López 14a666ce8d Fix crash. Steps to reproduce:
* Open Dolphin. Enable categorization.
* Split the view. Disable categorization on the right one.
* Join the views.

I am not sure if this is the best way to proceed for this small bug. Please Peter, take a look.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=680499
2007-06-26 11:50:54 +00:00
Rafael Fernández López d57134a033 Let deselect items individually using Ctrl+Click
svn path=/trunk/KDE/kdebase/apps/; revision=680368
2007-06-26 00:31:30 +00:00
Rafael Fernández López 289d854969 Take offsets in count
svn path=/trunk/KDE/kdebase/apps/; revision=680285
2007-06-25 20:25:07 +00:00
Rafael Fernández López 0abbaf9e11 Draw dragged items. Better conditions (more accurate to our behavior, hey ! we have columnview too...)
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=680283
2007-06-25 20:21:35 +00:00
Rafael Fernández López ad3beec4b2 Fix the small issue when you select by categories and then you
Ctrl+Click a subset, and those items selected were deselected

svn path=/trunk/KDE/kdebase/apps/; revision=679315
2007-06-23 15:47:20 +00:00
Rafael Fernández López 78195dd8fe Improve selection speed. I think we can still improve this a little bit, but I think we can live with this speed for now
svn path=/trunk/KDE/kdebase/apps/; revision=679308
2007-06-23 15:39:21 +00:00
Rafael Fernández López 66f4c8b3c8 Fix compile problems on systems that don't want nepomuk. eeek !
svn path=/trunk/KDE/kdebase/apps/; revision=679265
2007-06-23 13:12:21 +00:00
Rafael Fernández López 126c14b3ba Small fixes, but that have an impact of how things are visualized.
* Move "not tagged" elements to the end. We sort the rest (when they have tags), but keep untagged elements (the category) at the end of the view, since the user had
"less" interest on them.

* Break the law again of "dirs first". If we have on a folder only a tagged file (and is a file) and the rest are folders, that file goes first, since it was tagged.

* If we are on the same category, dirs go first. Here we make them citizens of first class.

* Commas instead of spaces when building categories for tags, they make it more readable and less error-prone (we can have tags "a", "dog" and "a dog" as tags, right?, 
so spaces here make the thing a bit hard to distinguish, I have two tags "a", "dog", or the tag "a dog") ;)

* Return an empty string when the item is not tagged at the method tagsForIndex. This way we always show untagged items the latest ones very easily (without nasty string 
checks). We will let the categorizer put a fancy name for them, if the returned string was empty.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=679097
2007-06-23 00:43:20 +00:00
Peter Penz 743590a944 Implement sorting by "tags". Same performance problems occur as when using sorting by "rating", but we must get a feeling first how we use the Nepomuk API before thinking about caching...
svn path=/trunk/KDE/kdebase/apps/; revision=678957
2007-06-22 16:42:34 +00:00
Rafael Fernández López b22d9b7b9c If we are sorting by rating, we won't apply the general rule: folders before regular files. The user said that was more interesting for him/her, so we respect his/her
decision. In this case folders and files are citizens of the same class.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=678894
2007-06-22 13:58:21 +00:00
André Wöbbeking 1304e17f34 also compile without nepomuk
svn path=/trunk/KDE/kdebase/apps/; revision=678876
2007-06-22 13:16:39 +00:00
Rafael Fernández López 3b0b987093 More human category when items haven't been rated yet
svn path=/trunk/KDE/kdebase/apps/; revision=678853
2007-06-22 12:16:44 +00:00
Peter Penz 4062c4cf2d Allow to sort by rating, which can be quite useful in combination with the "Show in Groups" feature. Although still slow, it basically works. All the code is based on Rafael Fernández López patch available at http://media.ereslibre.es/2007/06/dolphin-21062007.diff.
svn path=/trunk/KDE/kdebase/apps/; revision=678801
2007-06-22 10:18:46 +00:00
Max Blazejak aed0e93195 Enable the Code for additional metainfo again, doesn't hang on zip-files anymore
svn path=/trunk/KDE/kdebase/apps/; revision=678661
2007-06-21 22:27:16 +00:00
Rafael Fernández López 48ff18ebba Fix memory problem, thanks to Holger Freyther for pointing out
CCMAIL: zecke@selfish.org
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=678434
2007-06-21 11:44:00 +00:00
Rafael Fernández López 689a80543f Fix the "I can't/don't want to" finish the drag event (what is called
drop :P), and the selection rect is shown.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=678293
2007-06-21 02:18:54 +00:00
Peter Penz c01979aff1 it's not needed anymore to remember the URL per column
svn path=/trunk/KDE/kdebase/apps/; revision=678184
2007-06-20 21:04:36 +00:00
Peter Penz 15f50df9f6 don't pass a custom viewport URL to the context menu anymore, as this cannot work together with the menu actions
svn path=/trunk/KDE/kdebase/apps/; revision=678175
2007-06-20 20:48:36 +00:00
Peter Penz cd780167c3 minor coding style cleanups
svn path=/trunk/KDE/kdebase/apps/; revision=678172
2007-06-20 20:44:18 +00:00
Peter Penz 78da52a9ad assure that the context menu for column view is applied to the correct URL (depends from the current column)
svn path=/trunk/KDE/kdebase/apps/; revision=678166
2007-06-20 20:21:48 +00:00
Peter Penz eadb9a0f45 don't forget applying the view properties when refreshing the view
svn path=/trunk/KDE/kdebase/apps/; revision=678067
2007-06-20 15:59:32 +00:00
Peter Penz 9f81672476 split view on startup if it is defined by the settings
svn path=/trunk/KDE/kdebase/apps/; revision=678063
2007-06-20 15:46:57 +00:00
Dirk Mueller 98719c18ba at least return something
svn path=/trunk/KDE/kdebase/apps/; revision=677932
2007-06-20 07:50:06 +00:00
Peter Penz 318bdfa27f * coding style update to match with http://techbase.kde.org/Policies/Kdelibs_Coding_Style
* minor speed improvements by moving QString, QVariant, KDateTime, ... declarations inside inner scopes; further speed improvements should be possible, but lets do it step by step...

svn path=/trunk/KDE/kdebase/apps/; revision=677719
2007-06-19 19:28:08 +00:00
Rafael Fernández López 7cd33328af EBN fixes
svn path=/trunk/KDE/kdebase/apps/; revision=677715
2007-06-19 19:17:32 +00:00
Peter Penz a0ed7ae53d A cleanup in KDiskFreeSpace has been done -> adjust signal/slot to the new (and nicer) method signature
svn path=/trunk/KDE/kdebase/apps/; revision=677710
2007-06-19 19:08:49 +00:00
Rafael Fernández López 051f0b975d Fix the problem "the scrollbar remains if it was shown on the
categorized view, and now it has been disabled (the categorized 
view)"

svn path=/trunk/KDE/kdebase/apps/; revision=677706
2007-06-19 18:59:13 +00:00
Peter Penz eaa0ff560b when requesting a context menu provide a URL for the viewport, because in the column view this URL can differ from the navigator URL
svn path=/trunk/KDE/kdebase/apps/; revision=677704
2007-06-19 18:58:30 +00:00
Rafael Fernández López f9f4dbf005 Fix the scrollbar issue. We can live with the setSingleStep nasty workaround for now. Anyway we can adapt it to fit better in the context.
CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=677702
2007-06-19 18:52:55 +00:00
Rafael Fernández López 41d6071059 Fix the problem of the crash related to commit 677667, taking in count we are in IconMode, not in a mode
different than ListMode. Fix some comments.

svn path=/trunk/KDE/kdebase/apps/; revision=677668
2007-06-19 17:26:09 +00:00
Peter Penz 85e0112c3d provide temporary (?) fix for a crash that occurs if the categorization is turned off and a switch is done from another view mode
CCMAIL: ereslibre@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=677667
2007-06-19 17:23:14 +00:00
Rafael Fernández López 740b3b0ca4 Fix for not C99 compliant systems when trying to use trunc() function. I have defined this function on kdefakes library, so we have it KDE wide.
BUG: 146963

svn path=/trunk/KDE/kdebase/apps/; revision=677663
2007-06-19 17:09:27 +00:00
Peter Penz 2e6dc566dd don't use deprecated KGlobalSettings::xxxColor() methods anymore
svn path=/trunk/KDE/kdebase/apps/; revision=677660
2007-06-19 16:49:31 +00:00
Peter Penz 5926d0fddd * fixed issue that some view properties like "show in groups" are ignored when a new DolphinViewContainer has been created (happens on startup or when a view is split)
* get rid of redundant parameter in constructors of DolphinView and DolphinViewContainer

svn path=/trunk/KDE/kdebase/apps/; revision=677654
2007-06-19 16:35:52 +00:00