Commit graph

3602 commits

Author SHA1 Message Date
Dawit Alemayehu
d13504b5a7 When populating the "Show Remote Encoding" menu, put the check mark besides
the correct saved remote encoding charset.

BUG: 186289
FIXED-IN: 4.8.0
REVIEW: 103730
(cherry picked from commit 8f231bd081)
2012-01-18 18:05:15 -05:00
Frank Reininghaus
0b0b2cba93 Make PageUp/PageDown work in Dolphin's new view engine
BUG: 288748
FIXED-IN: 4.8.0
REVIEW: 103721
(cherry picked from commit e56a363aa6)
2012-01-18 10:46:47 +01:00
Frank Reininghaus
375b35762d Fix typo, which caused a Qt runtime warning when closing Dolphin
(cherry picked from commit dbf0bfffa7)
2012-01-18 09:39:07 +01:00
Peter Penz
e96af09351 Avoid unnecessary animations when switching view modes
Thanks to Nikita Skovoroda for the initial patch and the analyses.

BUG: 290947
FIXED-IN: 4.8.0
2012-01-17 23:44:28 +01:00
Peter Penz
8b8091f275 Fix probably wrong alternative background color
Thanks to Nikita Skovoroda for the patch!

CCMAIL: chalkerx@gmail.com
2012-01-17 21:19:34 +01:00
Peter Penz
7f718123b2 Do a synchronous layout for dynamic item sizes when changing the geometry
This prevents a delayed update when resizing the window e.g. in the details
view. As no animated item position changes can happen for dynamic item sizes
the synchronous relayout is fine from a performance point of view.

BUG: 290953
FIXED-IN: 4.8.0
2012-01-17 21:11:49 +01:00
Peter Penz
ab61a6174e Disable smooth-scrolling dependent on the graphics-effect level
If the graphics-effect-level has been set to NoEffects (systemsettings -> Appearance
-> Style -> Fine Tuning), the smooth scrolling in Dolphin will be disabled.

Additionally the duration for the smooth-scrolling has been decreased from 200 ms
to 100 ms to reduce the lag.

A wrong calculation of the end-value has been fixed that might trigger
a wrong position of the content.

BUG: 291740
BUG: 291607
FIXED-IN: 4.8.0
2012-01-17 10:04:00 +01:00
Frank Reininghaus
555364c006 If an item is clicked to trigger it, clear the rest of the selection
Note that the clearing is not done on mouse press, but on mouse release.
The reason is that there are situations when multiple items are selected
and pressing the mouse on one of them should not clear the selection
(e.g., drag and drop of multiple items).

BUG: 290854
REVIEW: 103703
FIXED-IN: 4.8.0
(cherry picked from commit 9f711b5f2e)
2012-01-16 20:03:49 +01:00
Peter Penz
a7295033e6 Use new icon for "Show in groups"
This allows adding the "Show in groups" action to the toolbar with
a nice icon.

CCBUG: 290632
2012-01-16 15:39:46 +01:00
Patrick Spendrin
377ce832e1 fix build of tests on windows 2012-01-15 15:49:34 +01:00
Peter Penz
8d7a2c96ea Don't select items if the selection toggle has been disabled 2012-01-15 10:51:46 +01:00
Peter Penz
8306a0fa6c Don't show a expanding-toggle in the Folders Panel if there are no subdirectories
BUG: 290745
FIXED-IN: 4.8.0
2012-01-15 10:41:44 +01:00
Peter Penz
f38a70f5d0 Assure an active view when activating an item
This might not be the case when e.g. having a split view, having enabled the "auto
expand folders" option and dragging an item from the active view to another
folder of the inactive view.
2012-01-14 22:02:23 +01:00
Peter Penz
fcfb636ffe Fix "general settings" issues
If the general settings for the "selection toggle" or "expanding folders during
drag operations" are changed, those changes must be applied to the engine.
2012-01-14 21:46:41 +01:00
Peter Penz
a0115f912a Fix issue when deleting items with the context menu
Thanks to Jekyll Wu for the analyses of the issue!

BUG: 290307
BUG: 269096
BUG: 290954
BUG: 264583
FIXED-IN: 4.8.0
2012-01-14 20:06:05 +01:00
Peter Penz
6d621d299d Fix possible crash in version-control observer
BUG: 291505
FIXED-IN: 4.8.0
2012-01-14 19:28:09 +01:00
Peter Penz
b09986ef27 Fix current-item indicator in combination with the cleanlooks style
Thanks to Christoph Feck for the hint.

BUG: 290536
FIXED-IN: 4.8.0
2012-01-14 11:31:06 +01:00
Peter Penz
d5d65f545a Fix selection issue when expanding a tree
The selection anchor must be reset when changing the current item
to the root of the tree.

BUG: 290832
FIXED-IN: 4.8.0
2012-01-12 07:01:24 +01:00
Peter Penz
6584f06cd1 Prevent accessing an item with an invalid index 2012-01-11 16:15:19 +01:00
Peter Penz
5289e852c1 Fix issue that shift + drag does not move files
BUG: 291103
FIXED-IN: 4.8.0
2012-01-10 17:23:56 +01:00
Peter Penz
9592ffcf9d Use the same icon size for the compact-view like the details-view per default 2012-01-10 17:07:42 +01:00
Jekyll Wu
1375f83168 Merge remote-tracking branch 'origin/KDE/4.8'
Conflicts:
	dolphin/src/main.cpp
2012-01-10 20:09:21 +08:00
Jekyll Wu
f3a38fc51a Middle clicking the 'Home' button should open home folder in a new tab
The general idea is to make it behave consistently with other navigating
buttons.

BUG: 278194
FIXED-IN:4.8.0
REVIEW:103659
2012-01-10 20:06:26 +08:00
Peter Penz
69f68a2349 Prevent generating previews all the time during downloading a large file
When downloading a large file the preview should not be recreated each time
a change-notification has been received. Create the preview after getting
the first file change, but postpone creating the next previews until no change
has been done during a longer period of time.

BUG: 290698
FIXED-IN: 4.8.0
2012-01-09 22:18:24 +01:00
Peter Penz
e73389e209 Prevent generating previews all the time during downloading a large file
When downloading a large file the preview should not be recreated each time
a change-notification has been received. Create the preview after getting
the first file change, but postpone creating the next previews until no change
has been done during a longer period of time.

BUG: 290698
FIXED-IN: 4.8.0
2012-01-09 22:16:17 +01:00
Script Kiddy
662c0e1919 SVN_SILENT made messages (.desktop file) 2012-01-09 08:30:24 +01:00
Peter Penz
582a7c55c9 Revert patch using the native graphicssystem as default
I'm trusting Christoph Feck's advice here. Additionally the smooth scaling
has been activated to fix bug 290865.

BUG: 290865
FIXED-IN: 4.8.0
2012-01-07 18:22:16 +01:00
Peter Penz
fc600ed255 Revert patch using the native graphicssystem as default
I'm trusting Christoph Feck's advice here. Additionally the smooth scaling
has been activated to fix bug 290865.

BUG: 290865
FIXED-IN: 4.8.0
2012-01-07 18:21:21 +01:00
Peter Penz
6f75059bb6 Use the native graphicssystem per default
The scaling of pixmaps is just way too slow with the raster graphicssystem (see KPixmapModifier::scalePixmap()). It is of course still possible to run Dolphin
with the raster graphicssystem, but this has to be done explicitly then.

CCBUG: 290865
2012-01-07 12:37:15 +01:00
Peter Penz
adb78d8b3a Use the native graphicssystem per default
The scaling of pixmaps is just way too slow with the raster graphicssystem (see KPixmapModifier::scalePixmap()). It is of course still possible to run Dolphin
with the raster graphicssystem, but this has to be done explicitly then.

CCBUG: 290865
2012-01-07 12:34:40 +01:00
Peter Penz
636292bfcb Details view: Fix wrong expansion level
The calculation of the root-expansion level had been incorrect which
lead to a wrong indentation on some directories.

BUG: 290757
FIXED-IN: 4.8.0
2012-01-06 18:03:15 +01:00
Peter Penz
21f49d84eb Details view: Fix wrong expansion level
The calculation of the root-expansion level had been incorrect which
lead to a wrong indentation on some directories.

BUG: 290757
FIXED-IN: 4.8.0
2012-01-06 18:02:36 +01:00
Script Kiddy
961fdf1a1c SVN_SILENT made messages (.desktop file) 2012-01-06 08:38:18 +01:00
Peter Penz
642f2804cd Temporary skip 2 unit-tests in KFileItemModel
KFileItemModel::resortAllItems() always emits a itemsMoved() signal since some
time. Before blindly adjusting the tests lets discuss first whether
resortAllItems() should be used in this context.
2012-01-05 21:41:04 +01:00
Peter Penz
209a467aee Temporary skip 2 unit-tests in KFileItemModel
KFileItemModel::resortAllItems() always emits a itemsMoved() signal since some
time. Before blindly adjusting the tests lets discuss first whether
resortAllItems() should be used in this context.
2012-01-05 21:40:30 +01:00
Peter Penz
afc55cc985 Fix issue that an empty directory is shown in the split mode
Root-cause was that the signal KDirLister::completed(KUrl) must be watched
by the model and not KDirLister::completed().

BUG: 290182
FIXED-IN: 4.8.0
2012-01-05 21:25:33 +01:00
Peter Penz
bf806b62c3 Fix issue that an empty directory is shown in the split mode
Root-cause was that the signal KDirLister::completed(KUrl) must be watched
by the model and not KDirLister::completed().

BUG: 290182
FIXED-IN: 4.8.0
2012-01-05 21:24:59 +01:00
Peter Penz
33eea8c929 Folders Panel: Activate folders on single-click
Even if double-click is used as default setting, the folders panel should
open folders with a single-click.

BUG: 289971
FIXED-IN: 4.8.0
2012-01-05 20:44:46 +01:00
Peter Penz
bfaa79b55a Folders Panel: Activate folders on single-click
Even if double-click is used as default setting, the folders panel should
open folders with a single-click.

BUG: 289971
FIXED-IN: 4.8.0
2012-01-05 20:44:05 +01:00
Peter Penz
c8d8556950 Fix style-issues in items when not using Oxygen
Thanks to Jonathan Marten and Christoph Feck for the analyses
and the patch.

Still open: The focus frame in cleanlooks is not drawn.

CCBUG: 290536
2012-01-05 20:18:21 +01:00
Peter Penz
e1173edc1d Fix style-issues in items when not using Oxygen
Thanks to Jonathan Marten and Christoph Feck for the analyses
and the patch.

Still open: The focus frame in cleanlooks is not drawn.

CCBUG: 290536
2012-01-05 20:13:49 +01:00
Script Kiddy
3eb312f8c6 SVN_SILENT made messages (.desktop file) 2012-01-04 09:28:08 +01:00
Script Kiddy
ec0d89f3ef SVN_SILENT made messages (.desktop file) 2012-01-03 16:51:07 +01:00
Peter Penz
7953913c9f Fix inconsistency in selection manager
When a selection has been done with non-linear ranges, it was possible that
the anchor item pointed to an invalid index that resulted into an invalid
selection.

As part of this fix the sorting for DolphinView::selectedItems() has been
disabled (if the caller assumes a sorted selection he must manually adjust it).

BUG: 288908
FIXED-IN: 4.8.0
2011-12-30 00:09:42 +01:00
Peter Penz
acee6d0fc5 Fix inconsistency in selection manager
When a selection has been done with non-linear ranges, it was possible that
the anchor item pointed to an invalid index that resulted into an invalid
selection.

As part of this fix the sorting for DolphinView::selectedItems() has been
disabled (if the caller assumes a sorted selection he must manually adjust it).

BUG: 288908
FIXED-IN: 4.8.0
2011-12-30 00:08:37 +01:00
Script Kiddy
d7a803cae0 SVN_SILENT made messages (.desktop file) 2011-12-29 10:43:55 +01:00
David Faure
dec1a1b29d KDiskFreeSpace already uses KMountPoint internally, we can give it any path. 2011-12-29 09:49:12 +01:00
Peter Penz
3e9d31d293 Fix issue that dragging pictures/videos to Google-Search/YouTube fails
BUG: 289917
BUG: 278236
FIXED-IN: 4.8.0
2011-12-27 15:53:49 +01:00
Peter Penz
3f5d3cfd08 Fix issue that dragging pictures/videos to Google-Search/YouTube fails
BUG: 289917
BUG: 278236
FIXED-IN: 4.8.0
2011-12-27 15:53:23 +01:00
Peter Penz
8b977e91fb Fix group-header clipping in compact mode 2011-12-27 09:11:08 +01:00