Commit graph

20 commits

Author SHA1 Message Date
Amol Godbole e1de6c3492 DolphinRecentTabsMenu: Fix blank text for closed search tab
The recently closed menu adds a blank item when a search tab is closed.
Add the search term and path to the item text.

BUG: 474999
2023-10-03 00:44:55 -05:00
Friedrich W. H. Kossebau ed2d352c42 Add explicit moc includes to sources for moc-covered headers
* speeds up incremental builds as changes to a header will not always
  need the full mocs_compilation.cpp for all the target's headers rebuild,
  while having a moc file sourced into a source file only adds minor
  extra costs, due to small own code and the used headers usually
  already covered by the source file, being for the same class/struct
* seems to not slow down clean builds, due to empty mocs_compilation.cpp
  resulting in those quickly processed, while the minor extra cost of the
  sourced moc files does not outweigh that in summary.
  Measured times actually improved by some percent points.
  (ideally CMake would just skip empty mocs_compilation.cpp & its object
  file one day)
* enables compiler to see all methods of a class in same compilation unit
  to do some sanity checks
* potentially more inlining in general, due to more in the compilation unit
* allows to keep using more forward declarations in the header, as with the
  moc code being sourced into the cpp file there definitions can be ensured
  and often are already for the needs of the normal class methods
2023-07-05 07:59:18 +00:00
Serg Podtynnyi 38c34eeca3 Add clang-format and format code as in Frameworks 2023-02-05 12:45:38 +07:00
Alain Laporte da2bad9c68 Use edit-clear-history icon
More semantically (and visually) appropriate icon
2022-06-28 07:36:01 +02:00
Toni Asensi Esteve 3bde6ba13c Delete some items that were intended to be deleted. Avoid trying to delete items that don't exist
When deleting items of a list, follow a sequence that ensures that the item
that is going to be deleted exists.

Revision: https://invent.kde.org/system/dolphin/-/merge_requests/240
2021-07-17 19:50:52 +02:00
David Hurka fb210d6ec4 Port to new KActionMenu popup mode API
Use KActionMenu and KToolBarPopupAction::setPopupMode()
methods instead of setDelayed() and setStickyMenu().
Are available since KF 5.77 and KF 5.78 respectively,
which is already required by Dolphin.
2021-07-04 15:26:18 +02:00
Alexander Lohnau 97415729c3 Compile with QT_NO_KEYWORDS 2020-10-23 18:23:06 +00:00
Elvis Angelaccio 954e8c4790 Output of licensedigger + manual cleanup afterwards.
Unfortunately licensedigger does not strip the trailing * characters.
While at it, use a common style for all source files.
2020-08-25 17:07:38 +00:00
Roman Inflianskas 48b58f830a Remove unused #include
Summary: I used CLion inspection to hunt all unused #include

Reviewers: #dolphin, elvisangelaccio, markg

Reviewed By: #dolphin, elvisangelaccio, markg

Subscribers: bcooksley, markg, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10985
2018-03-04 21:00:47 +03:00
Kevin Funk a6db5029ac Modernize: Use nullptr everywhere 2017-11-21 10:53:12 +01:00
Artur Puzio 5593c252e8 [CLAZY] Fixed all level 1 and level 2 warnings with small exceptions
REVIEW: 126771
2016-03-16 22:17:37 +01:00
Lukáš Tinkl 1b4572dac9 port Dolphin from KUrl to QUrl
REVIEW: 120688
2014-10-21 21:19:14 +02:00
Montel Laurent 0a6257bce3 Fix includes 2014-10-18 15:00:17 +02:00
Montel Laurent 6f6b1bbb69 Clean includes + port to QMenu 2014-10-10 23:36:36 +02:00
Emmanuel Pescosta d4fb129710 Merge branch 'master' into frameworks
Conflicts:
	dolphin/src/dolphinmainwindow.cpp
	dolphin/src/dolphinmainwindow.h
	dolphin/src/dolphinrecenttabsmenu.cpp
	dolphin/src/dolphinviewcontainer.cpp
	kfind/CMakeLists.txt
2014-08-22 23:17:02 +02:00
Emmanuel Pescosta 62418c58a5 Use DolphinTabPage saveState/restoreState to remember and re-open closed tabs.
REVIEW: 118968
2014-08-13 20:50:36 +02:00
Luca Beltrame de3e2ae40f Merge branch 'master' into frameworks 2014-07-22 15:58:03 +02:00
Arjun AK 9a69506572 make CTRL+SHIFT+T reopen last closed tab
BUG: 336818
FEATURE: 118994
2014-07-22 17:31:49 +05:30
Frank Reininghaus 81b84a1eaf Merge remote-tracking branch 'origin/master' into frameworks
Conflicts:
	dolphin/src/dolphinmainwindow.cpp
	dolphin/src/dolphinmainwindow.h
2014-06-29 20:28:46 +02:00
Emmanuel Pescosta 24823bbfd1 Implemented DolphinRecentTabsMenu to encapsulate the recent
tabs menu related code from DolphinMainWindow in a new class.

The DolphinRecentTabsMenu remembers the tab configuration if a
tab has been closed.

REVIEW: 118805
2014-06-19 22:04:36 +02:00