kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-07-04 17:30:55 +00:00
Code Issues Projects Releases Wiki Activity

DolphinRecentTabsMenu: Fix blank text for closed search tab

Browse Source 
The recently closed menu adds a blank item when a search tab is closed.
Add the search term and path to the item text.

BUG: 474999
This commit is contained in:
Amol Godbole 2023-10-03 00:44:55 -05:00
parent 30227dbcbe
commit e1de6c3492
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/dolphinrecenttabsmenu.cpp
View File

@ -5,12 +5,14 @@
*/
#include "dolphinrecenttabsmenu.h"
#include "search/dolphinquery.h"
#include <KAcceleratorManager>
#include <KLocalizedString>
#include <kio/global.h>
#include <QMenu>
#include <QUrlQuery>
DolphinRecentTabsMenu::DolphinRecentTabsMenu(QObject *parent)
: KActionMenu(QIcon::fromTheme(QStringLiteral("edit-undo")), i18n("Recently Closed Tabs"), parent)
@ -30,7 +32,15 @@ DolphinRecentTabsMenu::DolphinRecentTabsMenu(QObject *parent)
void DolphinRecentTabsMenu::rememberClosedTab(const QUrl &url, const QByteArray &state)
{
QAction *action = new QAction(menu());
action->setText(url.path());
if (DolphinQuery::supportsScheme(url.scheme())) {
const DolphinQuery query = DolphinQuery::fromSearchUrl(url);
action->setText(i18n("Search for %1 in %2", query.text(), query.includeFolder()));
} else if (url.scheme() == QLatin1String("filenamesearch")) {
const QUrlQuery query(url);
action->setText(i18n("Search for %1 in %2", query.queryItemValue(QStringLiteral("search")), query.queryItemValue(QStringLiteral("url"))));
} else {
action->setText(url.path());
}
action->setData(state);
const QString iconName = KIO::iconNameForUrl(url);
action->setIcon(QIcon::fromTheme(iconName));