The crash was caused by a null pointer dereference when, e.g.,
minimizing Dolphin. The root cause was that
KStandardItemListWidget::closeRoleEditor() was called twice: once when
the role editor loses focus, and once again when the window is resized.
After m_roleEditor was set to 0, the second call dereferenced this null
pointer. I think the best solution is to disconnect from the role
editor's signals when the editor is not needed any more by the
KStandardItemListWidget.
BUG: 304524
FIXED-IN: 4.9.1
For top-level roles like "Name" and "Size", the group translation is 0.
In that case, the "group" member of the corresponding RoleInfo struct
must be an empty string. This is expected by the code which generates
Dolphin's menus, which group the top-level roles into a sub menu with
the name "(I18N_EMPTY_MESSAGE)" otherwise. This is a recent regression
caused by 199fabbaa8.
Thanks to Christoph Feck for investigating this issue!
CCBUG: 305228
bar through javascript.
This commit changes how a request to create a new window with all its toolbars hidden
is handled. Namely, the toolbar that contains the address input widget will no longer
be hidden by default. The user can explicitly enable the ability to hide the location
bar by adding the following config option to Konqueror's config file (konquerorrc):
[DisableWindowOpenFeatures]
LocationBar=false
REVIEW: 105749
I overlooked that "actions/" is not part of the icon name. Just
rebuilding and re-running Dolphin did not reveal this issue, it seems
that the old icon "package_utility_time" was still cached somewhere.
I hope that it really works on all distros now.
CCBUG: 304323
The problem with the icon "package_utility_time" that has been used
before was that it is not available on all distros. The new icon
"actions/chronometer" should be available on every KDE install.
Thanks to Elias Probst for suggesting the new icon - I'm not that
familiar with the icons provided by KDE myself.
BUG: 304323
FIXED-IN: 4.9.1
Don't rely on the reported supported mimetypes from Phonon,
Phonon supports more than just video and audio, but if it is
video or audio there's a very good chance Phonon supports it.
(If the mime type isn't in the list returned by Phonon there's
still a good chance it supports it, because mime types are stupid.)
BUG: 252539
FIXED-IN: 4.9.1
(cherry picked from commit 2fb4419de0)
Moreover, make sure that the selection rectangle is large enough to
include the stars.
Patch by Emmanuel Pescosta. Thanks for the patch!
BUG: 302624
FIXED-IN: 4.9.1
REVIEW: 105830
Use QStyle icon sizes instead of hard coding 16 or 32 pixels.
Using styles that follow KDE settings (every KStyle, e.g.
Oxygen) the icon sizes can be configured by the user in
System Settings.
The size for the icon/details view can be later changed
by the user, overriding the defaults. The icon size for the
places panel is not (yet?) configurable separately.
(Not resolving the bug, see comment in review request)
CCBUG: 301959
REVIEW: 105548
(cherry picked from commit 79211f6e48)
This resolves a regression caused by the Places Panel rewrite. There is
a small glitch left when reordering items (dragging below the last or
above the first item only shows the drop indicator when first dragging
out of the item and then back), but I prefer not to fix this glitch
right now because this would require a more intrusive change, and I do
not want to risk regressions because is not much time left to fix them
before 4.9.0 is released.
Thanks to Peter Penz for providing some advice about this issue.
BUG: 302557
FIXED-IN: 4.9.0
(cherry picked from commit f4c9600251)
Without this patch, the name of the parent folder was used for the entry
in the Places Panel. Will backport to the KDE/4.9 branch when the RC2
freeze is over.
Thanks to Daniel Kreuter for the patch!
BUG: 303157
FIXED-IN: 4.9.0
(cherry picked from commit 9940244ddd)
