Commit graph

14624 commits

Author SHA1 Message Date
Script Kiddy 990455cfcf SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=921684
2009-02-05 14:09:41 +00:00
Script Kiddy ff098792e2 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=921220
2009-02-04 16:27:07 +00:00
Shaun Reich 71c30d2590 The Home folder location, when set via loadSettings(), and when set via the 'Use Default Location' button, now will use KUrl::prettyUrl(); Prior to this, saving an address of '/home/user/' would be changed to 'file:///home/user' (on Linux) normally (through applySettings()). However, when the listed methods were called, the text of the line edit would be just '/home/user/'. It will now (basically) be set to 'file:///'... all throughout.
svn path=/trunk/KDE/kdebase/apps/; revision=920943
2009-02-04 03:44:13 +00:00
Shaun Reich fe4648e45b Added const bools for a few settings that were referenced more than once. Otherwise, the fellow coder would probably just think these were taken out of seemingly thin air.
svn path=/trunk/KDE/kdebase/apps/; revision=920920
2009-02-04 01:24:38 +00:00
Friedrich W. H. Kossebau 4bbf2d5ffa make attribute array const, no need to copy data to stack only because of broken gl API (no const used where possible)
svn path=/trunk/KDE/kdebase/apps/; revision=920919
2009-02-04 01:15:51 +00:00
Friedrich W. H. Kossebau 76eda71ff7 make const-to-be arrays (of pointers) const and non-variable
svn path=/trunk/KDE/kdebase/apps/; revision=920918
2009-02-04 01:11:19 +00:00
Peter Penz 72c679d183 Check whether the global single-click/double-click setting has been changed during runtime and assure that the behavior of the view is adjusted.
CCMAIL: predator106@gmail.com
BUG: 175635
BUG: 175280

svn path=/trunk/KDE/kdebase/apps/; revision=920754
2009-02-03 18:40:59 +00:00
Peter Penz 60a4dd44f2 Don't differ between single-click and double-click in the column view, stay consistent with the behavior like the Places Panel or Folders Panel.
svn path=/trunk/KDE/kdebase/apps/; revision=920753
2009-02-03 18:35:19 +00:00
David Faure 8fa502dfee Re-enable handling of Tab (#167135)
svn path=/trunk/KDE/kdebase/apps/; revision=920744
2009-02-03 18:12:40 +00:00
Peter Penz 1351fefdb3 rename the checkbox "Browse through archives" to "Open archives as folder"
CCBUG: 182991

svn path=/trunk/KDE/kdebase/apps/; revision=920733
2009-02-03 17:54:33 +00:00
Peter Penz 6f27876331 SVN_SILENT: updated comment
svn path=/trunk/KDE/kdebase/apps/; revision=920731
2009-02-03 17:49:27 +00:00
Script Kiddy c60ad5ecf1 SVN_SILENT made messages (.desktop file, second try)
svn path=/trunk/KDE/kdebase/apps/; revision=920635
2009-02-03 14:52:58 +00:00
Peter Penz ff23e9327d * no general settings are read -> invoking loadSettings has no effect in restoreDefaults()
* use constants for the defaults, as hardcoding the defaults in 2 methods might be error-prone when changing the defaults in future

CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=920531
2009-02-03 06:24:39 +00:00
Shaun Reich 5b89d5bdc4 String change - Added clarification in the displayed message box for when the settings are applied in the Startup page, and there is an error. This is under the home folder setting. It now says that "the home folder is invalid or does not exist" as opposed to just saying it is invalid. I believe that it was kind of misleading as to what was wrong, so I figured it should give them _some_ hint as to what the problem is.
svn path=/trunk/KDE/kdebase/apps/; revision=920501
2009-02-03 03:20:47 +00:00
Shaun Reich d47292e649 SVN_SILENT Small update to a comment.
svn path=/trunk/KDE/kdebase/apps/; revision=920497
2009-02-03 01:40:30 +00:00
Shaun Reich 3382843542 Both the 'preview size' slider and the 'embed thumbnails in files' settings now restore to defaults when asked to.
svn path=/trunk/KDE/kdebase/apps/; revision=920491
2009-02-03 01:20:53 +00:00
Shaun Reich 5dd81d72dc A few more fixes...mostly cleanups.
*Grouped some statements that it didn't make sense to put after a certain block of code (giving the impression that it had to be after this block).
*There is no need to set the value of the QSpinBox equal to that of the slider, when loading settings... their valueChanges() signals are connected to the opposite one's slot.
*Made a now unused variable be used, it was inconsistent in this code block, two times '1' was used, but other times a var set to '1' would be used.
*Moved some blocks of code from the loadSettings() method, into the constructor, since the loadSettings() method is called more than once, so it's more resource-friendly to do it this way.

svn path=/trunk/KDE/kdebase/apps/; revision=920441
2009-02-02 22:23:06 +00:00
Shaun Reich bc5106e60f We were calling methods within loadSettings() which should have been moved to inside the constructor instead. Examples include setting up a slider's notch-type(bottom or top). Especially significant since loadSettings() gets called more often than the constructor.
svn path=/trunk/KDE/kdebase/apps/; revision=920419
2009-02-02 21:35:37 +00:00
Shaun Reich cf7a0e8f3c SVN_SILENT Fix to avoid accidental doxygen-highlighted header license.
svn path=/trunk/KDE/kdebase/apps/; revision=920402
2009-02-02 20:51:15 +00:00
Shaun Reich 38e209b76e Navigation click type (single/double-click) now gets set to it's default when asked (the default is single-click).
svn path=/trunk/KDE/kdebase/apps/; revision=920400
2009-02-02 20:40:33 +00:00
Shaun Reich 45eb32ba76 Changed group config reference pertaining to the "kcminputrc" file. The Navigation page setting of whether to use single/double click navigation now saves itself properly, instead of insisting on using single-click. :)
P.S. Bear in mind that the setting still does not apply itself until a restart of Dolphin.

CCMAIL: peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=920390
2009-02-02 20:14:42 +00:00
Shaun Reich 23424a0cce Reverted my previous commit(919897), I was incorrect, it looked to work like this, but didn't.
svn path=/trunk/KDE/kdebase/apps/; revision=920374
2009-02-02 19:43:02 +00:00
Script Kiddy 27c4c34316 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=920235
2009-02-02 15:35:50 +00:00
Shaun Reich 786d6ef9b5 Confirmations of the following settings now reset themselves to their defaults:
*Move to Trash
*Delete
These are located in the General page->Context Menu tab of the settings dialog.

svn path=/trunk/KDE/kdebase/apps/; revision=920205
2009-02-02 14:44:25 +00:00
Shaun Reich 8e8adb4625 The "Show 'Delete' Command" checkbox now gets restored to it's default (false).
svn path=/trunk/KDE/kdebase/apps/; revision=919996
2009-02-02 02:38:42 +00:00
Shaun Reich 74aa7ebb52 These radio buttons are paired, when you enable one, you inherently disable the other, so we're just repeating ourselves by doing this manually.
svn path=/trunk/KDE/kdebase/apps/; revision=919995
2009-02-02 02:34:57 +00:00
Simon Paul St James 9d617a4934 Hovering over blank space in a view while dragging would trigger the FolderExpander on the folder represented by the view, which we don't want. Detect and prevent it.
BUG:182618

Shipped! ;)

svn path=/trunk/KDE/kdebase/apps/; revision=919950
2009-02-01 22:03:04 +00:00
Shaun Reich 4a920ca2cb I forgot to change these three tabs to the new method usage also. Effected was the View Modes page.
svn path=/trunk/KDE/kdebase/apps/; revision=919919
2009-02-01 21:01:06 +00:00
Shaun Reich 9b72764ad0 Now when you click the button "Defaults" in the settings dialog, it will push the settings to the UI, then the user can apply, cancel, or modify them from there. Also removed the message box prompt. Use settings->useDefaults(true), then set it back to false after you are done loading settings in the restoreDefaults() method calls. Don't use ->setDefaults() normally, anymore.
svn path=/trunk/KDE/kdebase/apps/; revision=919897
2009-02-01 20:43:26 +00:00
Script Kiddy 8c5a1c044c SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=919783
2009-02-01 16:24:40 +00:00
Peter Penz 11dcd02855 Replace patch for bug 181226 by a different approach, as the previous patch resulted in a changed behavior when using the double-click mode (-> a treeview item had to be pressed twice to show it in the main view).
CCBUG: 172360
CCBUG: 181226

svn path=/trunk/KDE/kdebase/apps/; revision=919648
2009-02-01 14:08:40 +00:00
Script Kiddy 98c92ecea5 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=919234
2009-01-31 15:57:53 +00:00
Peter Penz 717812edcd Postpone the creating of the media object until the play- or stop-button has been pressed. This solves the issue that Dolphin might get blocked during hovering media files. Dolphin still gets blocked when requesting a media object the first time, but for the user this "just" means that after pressing the play-button the first time, that the playing starts a little bit later.
CCMAIL: kretz@kde.org
CCMAIL: kdedevel@etotheipiplusone.com

svn path=/trunk/KDE/kdebase/apps/; revision=919063
2009-01-31 13:04:40 +00:00
Peter Penz d12c0cd3d6 Don't delete and recreate the phonon widget each time the URL changes, use the existing widget instance if possible.
svn path=/trunk/KDE/kdebase/apps/; revision=919058
2009-01-31 12:42:01 +00:00
Peter Penz af387c5510 * move the search button to the end
* use the default search icon instead of the nepomuk icon

svn path=/trunk/KDE/kdebase/apps/; revision=919051
2009-01-31 12:21:52 +00:00
Peter Penz 61cc07b978 Allow to enable/disable the "Expandable Folders" setting of the details-view by the context menu of the header.
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=919035
2009-01-31 11:36:44 +00:00
Peter Penz 6f172a9145 Display correct folder names in tabs, if they contain a '&' character. Thanks to Frank Reininghaus for the patch!
BUG: 181765

svn path=/trunk/KDE/kdebase/apps/; revision=919021
2009-01-31 11:08:08 +00:00
David Faure f84915ba9d Fix porting bug: the help text for actions that will be menuitems should be set with setStatusTip, not with the useless setToolTip!
svn path=/trunk/KDE/kdebase/apps/; revision=918951
2009-01-31 02:43:34 +00:00
Peter Penz 176b6473df SVN_SILENT: just mention what the method does, skip implementation details
svn path=/trunk/KDE/kdebase/apps/; revision=918538
2009-01-30 06:16:13 +00:00
Peter Penz 8dda0d85b5 minor coding style fixes (http://techbase.kde.org/Policies/Kdelibs_Coding_Style):
* use spaces instead of tabs
* correct braces

CCMAIL: predator106@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=918537
2009-01-30 06:13:11 +00:00
Shaun Reich c452f4cee9 The mouse wheel now works on Dolphin's tabs (to switch tabs), like just about every other KDE app.
svn path=/trunk/KDE/kdebase/apps/; revision=918498
2009-01-29 23:44:20 +00:00
Script Kiddy e7b4e5a3b0 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=918487
2009-01-29 23:37:07 +00:00
David Faure fd23e8c1f5 Delay the call to asyncDrop so that the DND finishes before we go into QMenu::exec.
Otherwise the nested event loop will handle mouse move/release events and re-enter Qt's DND code, leading to crashes.
Fix tested by blauzahl (I didn't have the crash myself). Bug 157630.

svn path=/trunk/KDE/kdebase/apps/; revision=918370
2009-01-29 21:51:47 +00:00
David Faure 609dacf78d revert - fixed in klineedit instead.
svn path=/trunk/KDE/kdebase/apps/; revision=917999
2009-01-28 22:47:18 +00:00
Shaun Reich f911308e33 Default size and Preview size sliders, were using wrong signal to notify that settings have changed. The keyboard, when used on the slider, wouldn't enable the apply button, nor clicking to either side of the slider to change it. sliderMoved signal emission changed to valueChanged. Effects all tabs in Settings Dialog->View Modes.
svn path=/trunk/KDE/kdebase/apps/; revision=917972
2009-01-28 21:27:16 +00:00
David Faure 9c95812301 Make Ctrl+E/U/A work in konqueror's own location bar, even when a KAction is defined with that
shortcut (as is the case for Ctrl+U at least). QLineEdit doesn't do ShortcutOverride for those
shortcuts on purpose ("commonly used in apps"), but in konq we definitely want it.

svn path=/trunk/KDE/kdebase/apps/; revision=917960
2009-01-28 21:13:04 +00:00
Script Kiddy af277e1ed8 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=917787
2009-01-28 15:01:35 +00:00
Andrius Štikonas ee3cbe5928 i18n fixes.
svn path=/trunk/KDE/kdebase/apps/; revision=917480
2009-01-27 22:08:51 +00:00
Simon Paul St James 5028daa92e Initial import of Matthias's draft patch for adding video and audio previewing (similar to the file dialog) to Dolphin's metadata panel. Since Phonon is currently in-process only with the memory/ stability issues that come with this, this might have to be disabled by default - we'll see how it goes. Thanks, Matthias!
CCMAIL:kretz@kde.org
CCMAIL:peter.penz@gmx.at

svn path=/trunk/KDE/kdebase/apps/; revision=917389
2009-01-27 19:50:21 +00:00
Shaun Reich 159ba27726 The apply button in the settings dialog now disables itself when settings are applied, as per all of the other KDE applications, added in DolphinSettingsDialog::applySettings(). It was already setup to re-enable on a settings change.
svn path=/trunk/KDE/kdebase/apps/; revision=917168
2009-01-27 01:13:03 +00:00