David Faure
591fde8f4a
Don't crash if parentWidget is 0 (even though I don't recommend setting it to 0, the dirlister mainwindow won't be set if you reparent the widget later on)
...
BUG: 161681
svn path=/trunk/KDE/kdebase/apps/; revision=916972
2009-01-26 15:45:39 +00:00
Simon Paul St James
248ce7c57a
Refactor the folder expansion system. Main effect: instead of having a list of m_expandedViews which cannot yet be deleted, we more accurately identify the current source of the drag operation if any and store only this for later deletion.
...
This also fixes folder-expansion not working in Column view.
svn path=/trunk/KDE/kdebase/apps/; revision=916701
2009-01-25 19:46:08 +00:00
Simon Paul St James
5b8a817a73
In rare circumstances (a very narrow viewport is a necessary, but not sufficient, condition) DolphinDetailsView::resizeColumns() is called with an empty model so that sizeHintForColumn(...) returns -1 and so the name column ultimately has width -1. Detect and prevent this.
...
svn path=/trunk/KDE/kdebase/apps/; revision=915781
2009-01-23 18:55:08 +00:00
Simon Paul St James
5b5f0c9d7e
Two KFilePreviewGenerator's operating on the same KDirModel can lead to infinite loops of preview generation. If view is not delete'd (e.g. as a result of a FolderExpander), then m_previewGenerator won't be either: delete it manually to prevent having two active at once.
...
svn path=/trunk/KDE/kdebase/apps/; revision=914799
2009-01-21 19:43:41 +00:00
Sebastian Trueg
02781d747d
Only actually change the resource if tags were changed.
...
svn path=/trunk/KDE/kdebase/apps/; revision=914234
2009-01-20 17:41:56 +00:00
Simon Paul St James
9aa43f8bae
Update the KPart host's status bar info when selection changes.
...
svn path=/trunk/KDE/kdebase/apps/; revision=913713
2009-01-19 19:11:38 +00:00
Peter Penz
41dd38c07c
don't use any spacing between the search button and the input field
...
svn path=/trunk/KDE/kdebase/apps/; revision=913589
2009-01-19 15:02:09 +00:00
David Faure
056b6855d3
Fix lack of error handling in RMB/Move To... (e.g. when src is root-owned) because the parent for KonqOperations
...
was the popupmenu, which gets deleted before the job finishes.
svn path=/trunk/KDE/kdebase/apps/; revision=913576
2009-01-19 14:33:10 +00:00
Peter Penz
d85a6ec6dd
Use a custom SearchWidget instead directly using a KLineEdit. Currently the DolphinSearchWidget acts as "playground" to test some ideas. If it works well it might be a good idea moving this widget as KSearchBox (?) to kdelibs, so that it can be used by the file dialog or other applications.
...
svn path=/trunk/KDE/kdebase/apps/; revision=913572
2009-01-19 14:25:08 +00:00
Peter Penz
be1298d9aa
Provide a search box for the nepomuksearch:/ KIO slave. This is just an initial prototype to get some feedback, the search box and the URL navigator still need some love for this usecase...
...
CCMAIL: sebastian@trueg.de
svn path=/trunk/KDE/kdebase/apps/; revision=913451
2009-01-19 13:17:33 +00:00
Peter Penz
ed7d5e466f
use correct icon
...
svn path=/trunk/KDE/kdebase/apps/; revision=913415
2009-01-19 11:12:24 +00:00
Peter Penz
514fe2be7e
added settings module 'General' that can be used by Konqueror
...
svn path=/trunk/KDE/kdebase/apps/; revision=913414
2009-01-19 11:11:11 +00:00
Peter Penz
a038b894db
* enable the apply button when settings have been changed
...
* restore default settings correctly
svn path=/trunk/KDE/kdebase/apps/; revision=913412
2009-01-19 11:10:04 +00:00
Peter Penz
0772ebc3aa
added settings module for 'Navigation', that can be used by Konqueror
...
svn path=/trunk/KDE/kdebase/apps/; revision=913405
2009-01-19 10:39:11 +00:00
Peter Penz
d522c6701d
hide the tooltips when a key is pressed (thanks to Shaun Reich for the initial patch)
...
CCMAIL: predator106@gmail.com
svn path=/trunk/KDE/kdebase/apps/; revision=913383
2009-01-19 08:57:35 +00:00
Harald Sitter
920307602b
Fix Dolphin's desktop file. The additional quotation of %u made dolphin be started with an empty (but existing) location value which made it fall back to XDG's document path as of KDE 4.2. Without
...
quotation it doesn't get that empty value and starts using it's configured default location.
BUG: 169016
svn path=/trunk/KDE/kdebase/apps/; revision=912654
2009-01-17 23:07:46 +00:00
Peter Penz
8acb68ed28
Relayout of the settings dialog, so that all Dolphin KPart relevant settings can be made available in Konqueror's settings dialog too. Further cleanups and layout fixes are required and will be done during the next week.
...
svn path=/trunk/KDE/kdebase/apps/; revision=912587
2009-01-17 18:42:06 +00:00
David Faure
9e6b85cd6e
Remove useless code, replaced with slotRedirection.
...
svn path=/trunk/KDE/kdebase/apps/; revision=912124
2009-01-16 18:47:40 +00:00
David Faure
f56446a61a
Repair redirections in DolphinPart, it used to notify of redirections by connecting to urlChanged,
...
but iirc there were recent changes which make dolphinview emit redirection instead of urlChanged in that case
Makes me wonder if urlChanged is still useful for anything?
CCMAIL: peter.penz@gmx.at
svn path=/trunk/KDE/kdebase/apps/; revision=911974
2009-01-16 13:21:33 +00:00
Peter Penz
185f35da3a
Pressing "Enter" in the folders panel should open the folder in the main view. Thanks to Darío Andrés for the patch!
...
BUG: 172360
svn path=/trunk/KDE/kdebase/apps/; revision=911855
2009-01-16 10:28:25 +00:00
Peter Penz
6d6ac58d3f
provide icons for "Places", "Folders", "Information" and "Terminal" actions, so that they can be added to the toolbar
...
BUG: 180847
svn path=/trunk/KDE/kdebase/apps/; revision=911845
2009-01-16 09:54:55 +00:00
Peter Penz
24b3fb6f6c
cleanup sort order, so that it is easier later to split the files into several CMakeLists.txt
...
svn path=/trunk/KDE/kdebase/apps/; revision=911094
2009-01-14 20:22:17 +00:00
Peter Penz
f37ecd6ecf
Cleanup panel related class names: The terms "sidebar"/"sidebarpage" are relicts from the KDE 3 version of Dolphin and are called "Panels" in the KDE 4 version of Dolphin. Yes, renaming classes may take more than 1 year ;-)
...
svn path=/trunk/KDE/kdebase/apps/; revision=911089
2009-01-14 20:14:36 +00:00
Peter Penz
307285e963
Group classes into folders, Dolphin is too big in the meantime for having a flat directory hierarchy. dolphin/src/CMakeLists.txt will be cleaned up later.
...
svn path=/trunk/KDE/kdebase/apps/; revision=911065
2009-01-14 19:26:23 +00:00
Peter Penz
86d9c40ab7
prevent that the user can open more than one instance of the settings dialog
...
svn path=/trunk/KDE/kdebase/apps/; revision=910588
2009-01-13 18:06:15 +00:00
Stefan Monov
942778cb2a
someone forgot to move the comment along with the code ;)
...
svn path=/trunk/KDE/kdebase/apps/; revision=909814
2009-01-12 10:11:30 +00:00
Peter Penz
d15ff33059
SVN_SILENT: fixed indentation (was a mix of 1, 2 or 4 spaces...)
...
svn path=/trunk/KDE/kdebase/apps/; revision=909451
2009-01-11 16:35:07 +00:00
Peter Penz
6d2904ec48
add action "Close Tab" to the file menu, so that users get the chance to discover the key shortcut
...
svn path=/trunk/KDE/kdebase/apps/; revision=909450
2009-01-11 16:28:42 +00:00
Peter Penz
db5ee5f2a6
raise() and activateWindow() are not needed in this case
...
svn path=/trunk/KDE/kdebase/apps/; revision=908812
2009-01-10 14:27:07 +00:00
Peter Penz
e931b21216
there is no reason that the settings dialog is modal...
...
BUG: 179757
svn path=/trunk/KDE/kdebase/apps/; revision=908577
2009-01-09 22:56:24 +00:00
David Faure
723db9be83
same optimization as in 907877 but for the info sidebar's preview.
...
svn path=/trunk/KDE/kdebase/apps/; revision=907878
2009-01-08 20:51:03 +00:00
David Faure
b44364bd11
Small optimization found while having debug output in kfileitem: pass the KFileItem rather than the URL,
...
so that previewjob doesn't have to determine the item's mimetype again.
svn path=/trunk/KDE/kdebase/apps/; revision=907877
2009-01-08 20:46:10 +00:00
Peter Penz
d4173fa3f1
version update
...
svn path=/trunk/KDE/kdebase/apps/; revision=907874
2009-01-08 20:42:09 +00:00
David Faure
72f99574b4
don't complain about
...
KDirModel::indexForUrl: KUrl("") not found
every time the selection changes
svn path=/trunk/KDE/kdebase/apps/; revision=907756
2009-01-08 18:00:56 +00:00
Laurent Montel
054a5eca04
Fix compile with enable final
...
svn path=/trunk/KDE/kdebase/apps/; revision=907022
2009-01-07 12:27:38 +00:00
Laurent Montel
c907d6cd6b
Not necessary
...
svn path=/trunk/KDE/kdebase/apps/; revision=907018
2009-01-07 12:22:36 +00:00
Script Kiddy
580da51e01
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=906580
2009-01-06 12:52:00 +00:00
Peter Penz
c11baf1ad5
fixed issue that the zoom slider tooltip showed the previous size when changing the slider with the mouse
...
svn path=/trunk/KDE/kdebase/apps/; revision=906188
2009-01-05 18:41:06 +00:00
Peter Penz
b2db9bd9ed
QAbstractItemView::scrollTo() may get called by QListView::keyPressEvent(), so m_enableScrollTo (which is checked in DolphinIconsView::scrollTo()) must be enabled before. This fixes the issue that the autoscrolling does not work if exactly one item is selected and an invisible item should get focused because of a key press.
...
BUG: 179049
svn path=/trunk/KDE/kdebase/apps/; revision=906179
2009-01-05 18:21:34 +00:00
Peter Penz
59ac1d10ae
Only expand the tree view if it has an enabled 'itemsExpandable' property. If this is not the case, the folder will get opened like in the icon view by exchanging the whole content.
...
CCBUG: 178630
svn path=/trunk/KDE/kdebase/apps/; revision=905632
2009-01-04 18:35:32 +00:00
Peter Penz
291c9219a2
SVN_SILENT: minor coding style cleanups
...
svn path=/trunk/KDE/kdebase/apps/; revision=905631
2009-01-04 18:31:59 +00:00
Peter Penz
2872b35f4b
Fixed issue that in combination with the "automatically open folders during drag operations" the details view is not drawn correctly in the following case: Drag an item in the icons view to a folder which uses the details view.
...
Thanks to Simon St. James for the patch!
CCBUG: 178630
svn path=/trunk/KDE/kdebase/apps/; revision=905627
2009-01-04 18:26:43 +00:00
Peter Penz
6f38e24dbb
Don't set the mouse button state to NoButton, this is invalid e. g. during a drag operation. The mouse button state will be updated anyhow on each item-click. This fixes the regression that the feature "automatically open folders during drag operations" did not work anymore after one level.
...
Thanks to Simon St. James for the good analyzes!
BUG: 178630
svn path=/trunk/KDE/kdebase/apps/; revision=905622
2009-01-04 18:19:48 +00:00
Peter Penz
74f73dd2af
SVN_SILENT: minor coding style cleanups
...
svn path=/trunk/KDE/kdebase/apps/; revision=905620
2009-01-04 18:14:26 +00:00
Script Kiddy
fbd7cb02a5
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=905486
2009-01-04 13:22:16 +00:00
Simon Paul St James
e896fc8e11
contentsPos turned out to be a little broken - it would always return (0,0), except in a very unusual set of circumstances where it returned ... "different" values, causing very odd behaviour with the elastic band :) Remove it.
...
svn path=/trunk/KDE/kdebase/apps/; revision=904995
2009-01-03 16:00:21 +00:00
Peter Penz
64059e5083
don't cache the preview of the information sidebar, as this restricts the maximum size to 256 x 256 pixels
...
svn path=/trunk/KDE/kdebase/apps/; revision=904639
2009-01-02 17:26:12 +00:00
Script Kiddy
c6dbe9a31d
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=904551
2009-01-02 13:30:12 +00:00
Peter Penz
bac6ebe5d3
Instead of increasing the grid spacing, increase the item size, so that there is more space for the text.
...
svn path=/trunk/KDE/kdebase/apps/; revision=904408
2009-01-02 09:04:16 +00:00
Laurent Montel
da089e957c
not necessary
...
svn path=/trunk/KDE/kdebase/apps/; revision=904391
2009-01-02 08:00:53 +00:00