Commit graph

3737 commits

Author SHA1 Message Date
Peter Penz
355b2c4fb6 Prevent accessing an item with an invalid index 2012-01-11 16:14:19 +01:00
Peter Penz
5289e852c1 Fix issue that shift + drag does not move files
BUG: 291103
FIXED-IN: 4.8.0
2012-01-10 17:23:56 +01:00
Peter Penz
4792037b00 Fix issue that shift + drag does not move files
BUG: 291103
FIXED-IN: 4.8.0
2012-01-10 17:23:29 +01:00
Peter Penz
9592ffcf9d Use the same icon size for the compact-view like the details-view per default 2012-01-10 17:07:42 +01:00
Peter Penz
481eafc0c0 Use the same icon size for the compact-view like the details-view per default 2012-01-10 17:06:40 +01:00
Script Kiddy
8debdbafd8 SVN_SILENT made messages (.desktop file) 2012-01-10 15:50:18 +01:00
Jekyll Wu
1375f83168 Merge remote-tracking branch 'origin/KDE/4.8'
Conflicts:
	dolphin/src/main.cpp
2012-01-10 20:09:21 +08:00
Jekyll Wu
f3a38fc51a Middle clicking the 'Home' button should open home folder in a new tab
The general idea is to make it behave consistently with other navigating
buttons.

BUG: 278194
FIXED-IN:4.8.0
REVIEW:103659
2012-01-10 20:06:26 +08:00
Peter Penz
69f68a2349 Prevent generating previews all the time during downloading a large file
When downloading a large file the preview should not be recreated each time
a change-notification has been received. Create the preview after getting
the first file change, but postpone creating the next previews until no change
has been done during a longer period of time.

BUG: 290698
FIXED-IN: 4.8.0
2012-01-09 22:18:24 +01:00
Peter Penz
e73389e209 Prevent generating previews all the time during downloading a large file
When downloading a large file the preview should not be recreated each time
a change-notification has been received. Create the preview after getting
the first file change, but postpone creating the next previews until no change
has been done during a longer period of time.

BUG: 290698
FIXED-IN: 4.8.0
2012-01-09 22:16:17 +01:00
Script Kiddy
662c0e1919 SVN_SILENT made messages (.desktop file) 2012-01-09 08:30:24 +01:00
Peter Penz
582a7c55c9 Revert patch using the native graphicssystem as default
I'm trusting Christoph Feck's advice here. Additionally the smooth scaling
has been activated to fix bug 290865.

BUG: 290865
FIXED-IN: 4.8.0
2012-01-07 18:22:16 +01:00
Peter Penz
fc600ed255 Revert patch using the native graphicssystem as default
I'm trusting Christoph Feck's advice here. Additionally the smooth scaling
has been activated to fix bug 290865.

BUG: 290865
FIXED-IN: 4.8.0
2012-01-07 18:21:21 +01:00
Peter Penz
6f75059bb6 Use the native graphicssystem per default
The scaling of pixmaps is just way too slow with the raster graphicssystem (see KPixmapModifier::scalePixmap()). It is of course still possible to run Dolphin
with the raster graphicssystem, but this has to be done explicitly then.

CCBUG: 290865
2012-01-07 12:37:15 +01:00
Peter Penz
adb78d8b3a Use the native graphicssystem per default
The scaling of pixmaps is just way too slow with the raster graphicssystem (see KPixmapModifier::scalePixmap()). It is of course still possible to run Dolphin
with the raster graphicssystem, but this has to be done explicitly then.

CCBUG: 290865
2012-01-07 12:34:40 +01:00
Peter Penz
636292bfcb Details view: Fix wrong expansion level
The calculation of the root-expansion level had been incorrect which
lead to a wrong indentation on some directories.

BUG: 290757
FIXED-IN: 4.8.0
2012-01-06 18:03:15 +01:00
Peter Penz
21f49d84eb Details view: Fix wrong expansion level
The calculation of the root-expansion level had been incorrect which
lead to a wrong indentation on some directories.

BUG: 290757
FIXED-IN: 4.8.0
2012-01-06 18:02:36 +01:00
Script Kiddy
961fdf1a1c SVN_SILENT made messages (.desktop file) 2012-01-06 08:38:18 +01:00
Peter Penz
642f2804cd Temporary skip 2 unit-tests in KFileItemModel
KFileItemModel::resortAllItems() always emits a itemsMoved() signal since some
time. Before blindly adjusting the tests lets discuss first whether
resortAllItems() should be used in this context.
2012-01-05 21:41:04 +01:00
Peter Penz
209a467aee Temporary skip 2 unit-tests in KFileItemModel
KFileItemModel::resortAllItems() always emits a itemsMoved() signal since some
time. Before blindly adjusting the tests lets discuss first whether
resortAllItems() should be used in this context.
2012-01-05 21:40:30 +01:00
Peter Penz
afc55cc985 Fix issue that an empty directory is shown in the split mode
Root-cause was that the signal KDirLister::completed(KUrl) must be watched
by the model and not KDirLister::completed().

BUG: 290182
FIXED-IN: 4.8.0
2012-01-05 21:25:33 +01:00
Peter Penz
bf806b62c3 Fix issue that an empty directory is shown in the split mode
Root-cause was that the signal KDirLister::completed(KUrl) must be watched
by the model and not KDirLister::completed().

BUG: 290182
FIXED-IN: 4.8.0
2012-01-05 21:24:59 +01:00
Peter Penz
33eea8c929 Folders Panel: Activate folders on single-click
Even if double-click is used as default setting, the folders panel should
open folders with a single-click.

BUG: 289971
FIXED-IN: 4.8.0
2012-01-05 20:44:46 +01:00
Peter Penz
bfaa79b55a Folders Panel: Activate folders on single-click
Even if double-click is used as default setting, the folders panel should
open folders with a single-click.

BUG: 289971
FIXED-IN: 4.8.0
2012-01-05 20:44:05 +01:00
Peter Penz
c8d8556950 Fix style-issues in items when not using Oxygen
Thanks to Jonathan Marten and Christoph Feck for the analyses
and the patch.

Still open: The focus frame in cleanlooks is not drawn.

CCBUG: 290536
2012-01-05 20:18:21 +01:00
Peter Penz
e1173edc1d Fix style-issues in items when not using Oxygen
Thanks to Jonathan Marten and Christoph Feck for the analyses
and the patch.

Still open: The focus frame in cleanlooks is not drawn.

CCBUG: 290536
2012-01-05 20:13:49 +01:00
Script Kiddy
3eb312f8c6 SVN_SILENT made messages (.desktop file) 2012-01-04 09:28:08 +01:00
Script Kiddy
ec0d89f3ef SVN_SILENT made messages (.desktop file) 2012-01-03 16:51:07 +01:00
Peter Penz
7953913c9f Fix inconsistency in selection manager
When a selection has been done with non-linear ranges, it was possible that
the anchor item pointed to an invalid index that resulted into an invalid
selection.

As part of this fix the sorting for DolphinView::selectedItems() has been
disabled (if the caller assumes a sorted selection he must manually adjust it).

BUG: 288908
FIXED-IN: 4.8.0
2011-12-30 00:09:42 +01:00
Peter Penz
acee6d0fc5 Fix inconsistency in selection manager
When a selection has been done with non-linear ranges, it was possible that
the anchor item pointed to an invalid index that resulted into an invalid
selection.

As part of this fix the sorting for DolphinView::selectedItems() has been
disabled (if the caller assumes a sorted selection he must manually adjust it).

BUG: 288908
FIXED-IN: 4.8.0
2011-12-30 00:08:37 +01:00
Script Kiddy
d7a803cae0 SVN_SILENT made messages (.desktop file) 2011-12-29 10:43:55 +01:00
David Faure
dec1a1b29d KDiskFreeSpace already uses KMountPoint internally, we can give it any path. 2011-12-29 09:49:12 +01:00
Peter Penz
3e9d31d293 Fix issue that dragging pictures/videos to Google-Search/YouTube fails
BUG: 289917
BUG: 278236
FIXED-IN: 4.8.0
2011-12-27 15:53:49 +01:00
Peter Penz
3f5d3cfd08 Fix issue that dragging pictures/videos to Google-Search/YouTube fails
BUG: 289917
BUG: 278236
FIXED-IN: 4.8.0
2011-12-27 15:53:23 +01:00
Peter Penz
8b977e91fb Fix group-header clipping in compact mode 2011-12-27 09:11:08 +01:00
Peter Penz
56f8ca24cc Fix group-header clipping in compact mode 2011-12-27 09:10:27 +01:00
Peter Penz
7be14d0cde Fix icon alignment issue in the details view
BUG: 289889
FIXED-IN: 4.8.0
2011-12-27 08:34:15 +01:00
Peter Penz
0fa4b713ae Fix icon alignment issue in the details view
BUG: 289889
FIXED-IN: 4.8.0
2011-12-27 08:33:42 +01:00
Peter Penz
8403383926 Minor cleanup: Rename m_keyboardAnchorXPos to m_keyboardAnchorPos 2011-12-26 22:44:26 +01:00
Peter Penz
ba2c3e89f9 Minor cleanup: Rename m_keyboardAnchorXPos to m_keyboardAnchorPos 2011-12-26 22:43:20 +01:00
Peter Penz
2e2a6ae24c Improve item offset scrolling
Don't check whether the m_layoutTimer is active: Changing the
item offset must always trigger a synchronous layout, otherwise
the smooth-scrolling might get jerky.
2011-12-26 22:30:15 +01:00
Peter Penz
c33c54be7d Improve item offset scrolling
Don't check whether the m_layoutTimer is active: Changing the
item offset must always trigger a synchronous layout, otherwise
the smooth-scrolling might get jerky.
2011-12-26 22:29:44 +01:00
Peter Penz
118fe89449 Fix keyboard issues when groups are enabled
When groups are enabled in Dolphin the key-up and key-down keys did not behave
consistent in comparison to traditional views or like done in editors.

CCBUG: 261995
CCBUG: 262038
2011-12-26 22:22:50 +01:00
Peter Penz
83c5692f5e Fix keyboard issues when groups are enabled
When groups are enabled in Dolphin the key-up and key-down keys did not behave
consistent in comparison to traditional views or like done in editors.

CCBUG: 261995
CCBUG: 262038
2011-12-26 22:22:04 +01:00
Peter Penz
4dc5714016 Fix grouping issue
When switching to a group that is not shown currently, the group headers
won't be updated. The root-cause was that the m_groups-cache must be reset
when the roles have been changed.

CCBUG: 289654
2011-12-25 22:38:34 +01:00
Peter Penz
6212ac6053 Fix grouping issue
When switching to a group that is not shown currently, the group headers
won't be updated. The root-cause was that the m_groups-cache must be reset
when the roles have been changed.

CCBUG: 289654
2011-12-25 22:37:44 +01:00
Peter Penz
ee26791cee Fix wrong grouping of types
- Uninitialized types count as one group
- Let the receiver of the signal itemsMoved() decide whether unmoved items
  really result in an unchanged visual appearance. This might e.g. be the case
  if the grouping is turned on and the group-names change although the items
  themselves have not changed their position.

BUG: 289654
FIXED-IN: 4.8.0
2011-12-25 11:39:46 +01:00
Peter Penz
a237f42ee3 Fix wrong grouping of types
- Uninitialized types count as one group
- Let the receiver of the signal itemsMoved() decide whether unmoved items
  really result in an unchanged visual appearance. This might e.g. be the case
  if the grouping is turned on and the group-names change although the items
  themselves have not changed their position.

BUG: 289654
FIXED-IN: 4.8.0
2011-12-25 11:39:17 +01:00
Peter Penz
00b0bfcd01 Fix sort-issue for trees
If a protocol like fish is used, the sorting of sub-trees was wrong. The root
cause was a wrong comparing of URLs where the protocol was not initialized.

BUG: 289697
FIXED-IN: 4.8.0
2011-12-24 14:16:10 +01:00
Peter Penz
f07315deb0 Fix sort-issue for trees
If a protocol like fish is used, the sorting of sub-trees was wrong. The root
cause was a wrong comparing of URLs where the protocol was not initialized.

BUG: 289697
FIXED-IN: 4.8.0
2011-12-24 14:15:21 +01:00