Commit graph

4174 commits

Author SHA1 Message Date
Frank Reininghaus 96672c166f Only select a created item and make it 'current' in the active view
The 'make the new item the current one in all views' issue has been
around for quite some time, the unexpected selection was a recent
regression caused by commit b25059e803.

Thanks to Jaime Torres for finding the regression early and for testing
this patch!

BUG: 310219
FIXED-IN: 4.9.4
2012-11-18 16:22:52 +01:00
Frank Reininghaus c73bf691c6 Update Dolphin version to 2.1.80 2012-11-12 21:32:04 +01:00
Dawit Alemayehu b85d46b838 Merge remote-tracking branch 'origin/KDE/4.9' 2012-11-10 16:28:36 -05:00
Emmanuel Pescosta ce1bdf40cf Fix Bug 217575 - Auto select pasted files doesn't select all files if some have been skipped
BUG: 217575
REVIEW: 107237
FIXED-IN: 4.9.4
2012-11-09 14:52:32 +01:00
Emmanuel Pescosta 9aacd610a3 Fix Bug 309760 - Crash while inline-renaming a file and apply change with return-key
BUG: 309760
FIXED-IN: 4.9.4
2012-11-09 12:10:36 +01:00
Frank Reininghaus 15faff457d Merge remote-tracking branch 'origin/KDE/4.9' 2012-11-05 22:12:45 +01:00
Frank Reininghaus c0559a2a1d Prevent crashes caused by nested event loops run when renaming inline
When renaming inline and starting a drag or invoking the context menu,
a nested event loop will be run. If the role editor loses focus and
emits roleEditingFinished(), we must prevent that deleteLater() is
called because this would delete the role editor inside a nested event
loop which is run from one of its own functions. We would get a crash
when returning from that event loop otherwise.

BUG: 308018
BUG: 309421
FIXED-IN: 4.9.4
2012-11-05 22:03:52 +01:00
Frank Reininghaus 07721cf764 Do not use a hardcoded size for the buttons in the Information panel
Thanks to Kai Uwe Broulok and Jekyll Wu for the investigation!

BUG: 309498
FIXED-IN: 4.9.4
2012-11-04 14:39:49 +01:00
Frank Reininghaus c6eb4866d8 Use the standard sizes from KIconLoader, rather than hardcoded sizes. 2012-11-04 10:33:49 +01:00
Frank Reininghaus 6f8060fc6d Add an "Icon Size" submenu to the context menu of the Places Panel
FEATURE: 307475
FIXED-IN: 4.10.0
CCBUG: 301959
2012-11-01 00:58:32 +01:00
Alex Fiestas 951dbd6d67 Removed customm setText for mtp devices and check for kio_mtp
We are already checking if kio_mtp is installed when we build the
predicate so we don't need to check if it is installed again.

Also, the fix for "Showing the product as a name for some kind of
massive storage" will have to be delayed to 4.9.4, so removing this.
2012-11-01 00:28:18 +01:00
Frank Reininghaus 9d6feb556d Do not show an incorrect file name after a failed rename operation
BUG: 303742
FIXED-IN: 4.9.3
2012-10-31 23:06:39 +01:00
Frank Reininghaus bc72aeeb8f Only store the HomeUrl in dolphinrc if it is not the user's home folder
This fixes the problem that copying the dolphinrc from another user
results in Dolphin starting up in a folder that might wither not be
accessible or not exist at all.

BUG: 308569
FIXED-IN: 4.9.3
2012-10-31 22:48:59 +01:00
Emmanuel Pescosta 32569ebedf Fix Bug 309338 - flood of error boxes while renaming a folder in the folder panel
BUG: 309338
FIXED-IN: 4.9.3
REVIEW: 107070
2012-10-31 22:43:21 +01:00
Emmanuel Pescosta b4998a7cd4 Fix Bug 279333 - Panels can be moved even if locked
BUG: 279333
FIXED-IN: 4.9.3
REVIEW: 107135
2012-10-30 23:10:43 +01:00
Frank Reininghaus 1353c92cce Fix some indentation issues 2012-10-30 08:25:21 +01:00
Frank Reininghaus 70aac0f1e6 Remove workaround for bug 304986 which is not needed in master
Commit ea6a7c09a0 added a workaround for
bug 304986 (high CPU usage because KFileItemModelRolesUpdater requests
previews for the same files over and over again after, e.g., a rename
operation). The KDE/4.10 branch of kdelibs contains the real fix for
this issue (b8f64ca3f4b6311519c21046031d66d9d0a570c6), so the workaround
can be removed.
2012-10-30 07:29:44 +01:00
Frank Reininghaus 1d9d83b434 Merge remote-tracking branch 'origin/KDE/4.9' 2012-10-30 07:26:30 +01:00
Emmanuel Pescosta c503452d56 Fix Bug 153984 - Clicking cancel on the authentication dialog for fish/sftp/ftp kioslave gets dolphin stuck on "Loading folder"
BUG: 153984
REVIEW: 107116
2012-10-29 20:54:53 +01:00
Emmanuel Pescosta 726cd768c9 Fix wrong function call in KFileItemModelSortAlgorithm::sequentialSort (Bug introduced in commit 429218eaf2) 2012-10-28 20:59:55 +01:00
Emmanuel Pescosta ecdb0c3f58 Extended/Completed Frank's commit 7ca682fe90.
* Implemented Rename-Inline-Option in Settings Dialog
* Re-enable renaming items with the rename dialog in Folderview-Panel

BUG: 306705
REVIEW: 107072
2012-10-28 20:12:04 +01:00
Emmanuel Pescosta b4800d794c Implemented multithreading in KFileItemModelSortAlgorithm. Use as many threads as possible.
Thanks to Frank Reininghaus for all his suggestions.

REVIEW: 107025
2012-10-28 17:58:06 +01:00
Frank Reininghaus 37a54c053e Workaround for failed comparison of items in KFileItemModelRolesUpdater
The real fix is in the KDE/4.10 branch of kdelibs
(commit b8f64ca3f4b6311519c21046031d66d9d0a570c6). We work around the
problem that the KFileItem that a preview has been requested for is
different from the KFileItems in the sets m_pendingVisibleItems and
m_pendingInvisibleItems by refreshing those sets when we detect that
the bug has been triggered.

BUG: 304986
FIXED-IN: 4.9.3
2012-10-27 09:48:51 +02:00
Christoph Feck c1bc83dfdb Merge remote-tracking branch 'origin/KDE/4.9' 2012-10-26 01:58:50 +02:00
Christoph Feck 282f5cb869 Fix color role of tree view arrows
BUG: 307734
FIXED-IN: 4.9.3
REVIEW: 107031
2012-10-26 01:52:20 +02:00
Emmanuel Pescosta b6396ca721 Use QPixmapCache for KStandardItemListWidget::pixmapForIcon(const QString& name, int size) -> Avoid KIcon loading and rescaleing
REVIEW: 107039
2012-10-25 19:53:53 +02:00
Alex Fiestas 996fe25208 Show MTP devices in case support for it is installed
Basically adds a conditional that in case that mtp kioslave is installed
devices with MTP are added to the predicated.
REVIEW: 106651
(cherry picked from commit a09a237950)
2012-10-24 01:22:31 +02:00
Alex Fiestas 434a6cf0a7 Show MTP devices in case support for it is installed
Basically adds a conditional that in case that mtp kioslave is installed
devices with MTP are added to the predicated.
REVIEW: 106651
2012-10-24 01:21:02 +02:00
Simeon Bird 04dabe84b2 Fix race condition and deadlock in the version plugin
when listing directories is slow.

BUG: 302264
FIXED-IN: 4.9.3
2012-10-19 21:06:49 -04:00
Simeon Bird 4f6a2780ee Fix race condition and deadlock in the version plugin
when listing directories is slow.

BUG: 302264
FIXED-IN: 4.9.3
2012-10-19 21:05:54 -04:00
Weng Xuetian 1c6d0c316a use better icon for timeline:/ in places
REVIEW: 106874
2012-10-16 07:55:00 -04:00
Pino Toscano e428f431bb look also for soprano 2012-10-16 10:14:56 +02:00
Emmanuel Pescosta a9b04801db Port Dolphin from Nepomuk to Nepomuk2 according to the Nepomuk2Port mini guide on techbase - http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port
REVIEW: 106825
2012-10-15 21:46:59 +02:00
Pino Toscano c239ae19de Merge remote-tracking branch 'origin/KDE/4.9' 2012-10-13 09:27:54 +02:00
Amol Godbole 67cae55f9d Use not only Alt+Return, but also Alt+Enter as shortcut for "Properties"
BUG: 307603
REVIEW: 106753
FIXED-IN: 4.9.3
2012-10-07 19:39:59 +02:00
Dawit Alemayehu bc66254304 Merge branch '4.9' 2012-10-03 15:09:58 -04:00
Frank Reininghaus 2277ccaf23 Fix the hidden "EnlargeSmallPreviews" option
This option, introduced in 99e4eb0f3a, did
not work any more since 2069c20021.

CCBUG: 307522
2012-10-03 10:14:20 +02:00
Frank Reininghaus 0e49df9214 Find out the main window by calling the parent widget's window() member
KFileItemModel calls the dir lister's setMainWindow() method to make
sure that the dir lister caches authentication data. However, the method
used to determine the main window (qApp->activeWindow()) is not
guaranteed to yield the DolphinMainWindow or the KonqMainWindow. In
particular, if "Split View" is enabled in Dolphin's settings dialog, the
active window is the dialog, and when it is closed, any later access to
the stored pointer leads to a crash.

A better method is to verify that the model's parent is a QWidget and
then use this widget's window(). I had to make a small modification in
DolphinMainWindow to make sure that it also works correctly when the
view is split (the new view container had been created with a 0 parent
previously).

I tested it in Dolphin and Konqueror and verified that the "main window"
passed to the dir lister is really the application's main window.

BUG: 306459
FIXED-IN: 4.9.3
2012-09-29 19:53:14 +02:00
Dawit Alemayehu 65b7e3b785 Redo the fix for CTRL+Tab not working when using Dolphin's filemanagement part
in Konqueror. The original fix, commit 4f7ed2b, prevents drag and drop from
working correctly.

CCBUG: 302329
REVIEW: 106569
2012-09-28 14:01:21 -04:00
Dawit Alemayehu b7a8327c30 Merge branch '4.9' 2012-09-27 17:48:56 -04:00
Vishesh Handa 9b01d1bcc1 Dolphin Places: Only show file results in Nepomuk Queries
Dolphin is a file manager, and shouldn't be concerned with non-file
resources like notes, contacts and other stuff.

Use FileQuery instead of Query.

This also results in a faster queries. With File Queries Nepomuk can
perform some internal optimizations.

BUG: 306029
REVIEW: 106274

Cherry-picked from 6892d39d29
2012-09-28 02:37:35 +05:30
Emmanuel Pescosta 814611ca36 Some speed improvements in KFileItemModelRolesUpdater:
- Use QSet.erase() instead of QSet.remove() => no expensive Rehashing
- Get rid of += in sortAndResolvePendingRoles()
- Some other small changes

REVIEW: 106577
2012-09-27 18:47:55 +02:00
Frank Reininghaus 831251d0f3 Add a new config option for the icon size in the Places Panel
To change the icon size in the Places Panel to, e.g., 60 pixels, add
the following lines to $KDEHOME/share/config/dolphinrc :

[PlacesPanel]
IconSize=60

A value of -1 means that the standard "Small" size should be used
(which has been the default before this commit).

It is planned to add an "Icon Size" submenu to the context menu of the
Places Panel in KDE 4.10, but we cannot do this in the 4.9 branch
because of the string freeze.

FIXED-IN: 4.9.2
BUG: 301959
2012-09-27 08:12:02 +02:00
Emmanuel Pescosta 63561edb45 Fix a Bug in KFileItemModelRolesUpdate::setEnabledPlugins.
Changes were never overtaken because of a wrong comparison.

FIXED-IN: 4.9.2
2012-09-26 17:36:51 +02:00
Dawit Alemayehu 7cef34939d Fixed CTRL+Tab not working when using Dolphin's filemanagement part in Konqueror.
BUG: 302329
FIXED-IN: 4.9.2
REVIEW: 106569
2012-09-26 10:16:44 -04:00
Amandeep Singh 509464cce9 Adding license header in kitemlistviewaccessible
Added the license header in kitemlistviewaccessible.*
Accessibility headers not included when QT_NO_ACCESSIBILITY defined
Removed unnecessary debug statement
2012-09-26 04:36:31 +05:30
Frank Reininghaus a5d8edb8c2 Fix coding style and unnecessary complexity in KItemListViewAccessible
CCMAIL: aman.dedman@gmail.com
CCMAIL: gladhorn@kde.org
2012-09-25 22:01:03 +02:00
Emmanuel Pescosta c330be5f5c Fixes Bug 305783 - dragging a file over a directory #c4
does not expand the dir => Bug discovered: When you drag a
     item onto a folder-view-item and then move it away
     instantly before the autoactivation event is triggered
     (After 750ms), the folder will be opened anyway.

BUG: 305783
REVIEW: 106381
FIXED-IN: 4.9.2
(cherry picked from commit 9ab8bcd6aa)
2012-09-25 17:06:34 +02:00
Frederik Gladhorn c914273feb Do not include role name in acc name, add desc.
The role is already known. Including it in the
accName means a screen reader will read
"zoom slider slider".
2012-09-25 12:50:06 +02:00
Amandeep Singh c08a4794ff Removing layouter from public, adding TableModelChanged update
REVIEW : 106555
2012-09-25 04:01:48 +05:30