kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-09-19 00:11:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Bug 309338 - flood of error boxes while renaming a folder in the folder panel

Browse source 
BUG: 309338
FIXED-IN: 4.9.3
REVIEW: 107070
This commit is contained in:
Emmanuel Pescosta 2012-10-31 22:43:21 +01:00
parent b4998a7cd4
commit 32569ebedf
2 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/kitemviews/kitemlistview.cpp
View file

@ -1429,12 +1429,16 @@ void KItemListView::slotGeometryOfGroupHeaderParentChanged()
void KItemListView::slotRoleEditingCanceled(int index, const QByteArray& role, const QVariant& value)
{
disconnectRoleEditingSignals(index);
emit roleEditingCanceled(index, role, value);
m_editingRole = false;
}
void KItemListView::slotRoleEditingFinished(int index, const QByteArray& role, const QVariant& value)
{
disconnectRoleEditingSignals(index);
emit roleEditingFinished(index, role, value);
m_editingRole = false;
}
@ -2505,6 +2509,17 @@ bool KItemListView::hasSiblingSuccessor(int index) const
return hasSuccessor;
}
void KItemListView::disconnectRoleEditingSignals(int index)
{
KItemListWidget* widget = m_visibleItems.value(index);
if (!widget) {
return;
}
widget->disconnect(SIGNAL(roleEditingCanceled(int,QByteArray,QVariant)), this);
widget->disconnect(SIGNAL(roleEditingFinished(int,QByteArray,QVariant)), this);
}
int KItemListView::calculateAutoScrollingIncrement(int pos, int range, int oldInc)
{
int inc = 0;

7
src/kitemviews/kitemlistview.h
View file

@ -662,6 +662,13 @@ private:
*/
bool hasSiblingSuccessor(int index) const;
/**
* Helper method for slotRoleEditingCanceled() and slotRoleEditingFinished().
* Disconnects the two Signals "roleEditingCanceled" and
* "roleEditingFinished"
*/
void disconnectRoleEditingSignals(int index);
/**
* Helper function for triggerAutoScrolling().
* @param pos Logical position of the mouse relative to the range.