Commit graph

1332 commits

Author SHA1 Message Date
Stefan Monov
3dc1043b73 SVN_SILENT trivial code simplification. hope you don't mind peter.
svn path=/trunk/KDE/kdebase/apps/; revision=779275
2008-02-25 19:12:58 +00:00
Peter Penz
eb7294fa10 minor cleanup: no need to create a slot which just invokes another method, just use the other method as slot
svn path=/trunk/KDE/kdebase/apps/; revision=778423
2008-02-23 15:48:56 +00:00
Rafael Fernández López
90625552ea Much better with the last report details :)
CCBUG: 158266

svn path=/trunk/KDE/kdebase/apps/; revision=778366
2008-02-23 14:21:57 +00:00
Peter Penz
3db4843c35 fixed issue that when renaming "Open office.org writer documentation.pdf" that only "Open office" is selected and ".org writer documentation" is handled as extension
BUG: 158228

svn path=/trunk/KDE/kdebase/apps/; revision=778329
2008-02-23 11:59:57 +00:00
Script Kiddy
eaefe4250c SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=778131
2008-02-22 16:21:46 +00:00
Peter Penz
7a2f5990ee KDE 4.1 requires Qt4.4 -> remove the #ifdefs...
svn path=/trunk/KDE/kdebase/apps/; revision=778095
2008-02-22 13:56:16 +00:00
Peter Penz
1abc518e7a SVN_SILENT: updated comment with the Qt-bugtracker ID
svn path=/trunk/KDE/kdebase/apps/; revision=778039
2008-02-22 10:08:11 +00:00
Peter Penz
d7321c1d9a Fixed wrong comments. Discussed with David Faure: installing an event filter works for the icons-view and details-view, but not for the column-view which uses QListView child widgets internally... We decided to leave it as it is.
svn path=/trunk/KDE/kdebase/apps/; revision=777838
2008-02-21 18:45:22 +00:00
Peter Penz
e086d709d8 stay consistent with the QListView behavior: changed the current index also changes the selection
svn path=/trunk/KDE/kdebase/apps/; revision=777817
2008-02-21 17:34:14 +00:00
Peter Penz
518372394d * Install an event-filter for the view implementations. Whenever a view implementation gets the focus, it should request it's activation.
* Let the metadata widget only get the focus by clicking.

* Tried to install a similar filter for the wheel-event code duplication in the view-implementations, but the event filter is invoked _after_ the view implementation gets the wheel event... -> added a note the the 3 implementations as hint.

svn path=/trunk/KDE/kdebase/apps/; revision=777757
2008-02-21 14:01:40 +00:00
Peter Penz
b34ed68daf don't let the selection toggle steal the keyboard focus of the view
svn path=/trunk/KDE/kdebase/apps/; revision=777738
2008-02-21 12:53:56 +00:00
Peter Penz
188754a3e5 Let the DolphinController be aware on which QAbstractItemView instance he is working. This allows to connect signals from the view implementations (icons view, details view, column view) directly to the slots of the DolphinController without a helper slot.
svn path=/trunk/KDE/kdebase/apps/; revision=777737
2008-02-21 12:49:11 +00:00
Peter Penz
e287058acb Prevent code duplication by moving the duplications into the DolphinController.
Maybe it might be a good idea to let the DolphinController be aware also about his QAbstractItemView -> it might be possible to directly connect signals of the dolphin view implementations with the controller. I'll check this...

(I did not backport this cleanup as I think it has too many changes to be handled as bugfix)

CCMAIL: faure@kde.org 
CCMAIL: edulix@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=777719
2008-02-21 11:56:31 +00:00
Eduardo Robles Elvira
c735913801 Bugfix: Currently, if you open dolphin, select a bunch of files, and right click and
select Open With > whatever, all the files are opened. Which is the right 
thing. However, if you hit enter to open those selected files, no file is 
opened. Currently, the file is only opened if there's only *one* file 
selected. The attached patch fixes this problem.


svn path=/trunk/KDE/kdebase/apps/; revision=777695
2008-02-21 09:55:08 +00:00
Script Kiddy
ea5e9196b2 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=777485
2008-02-20 18:43:33 +00:00
Christian Ehrlicher
652194f729 LIB_INSTALL_DIR -> INSTALL_TARGETS_DEFAULT_ARGS
svn path=/trunk/KDE/kdebase/apps/; revision=776849
2008-02-18 21:51:54 +00:00
Script Kiddy
c75a5de752 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=776784
2008-02-18 20:27:57 +00:00
Bill Egert
ff32f4c1c4 No longer use Obsolete Member for QWidget:
topLevelWidget() => window() 

svn path=/trunk/KDE/kdebase/apps/; revision=776408
2008-02-18 01:06:50 +00:00
Peter Penz
51cbeaf512 * if the system font is changed during Dolphin is open, take care to update the used font of all views too (assuming that the user selected "system font" as font)
* store the font weight instead of a bool property "isBold"

Thanks to Rafael for the patch!

CCMAIL: ereslibre@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=776188
2008-02-17 15:50:06 +00:00
Peter Penz
98497a639a let F6 also select the whole text of the URL navigator to stay consistent with Konqueror and Firefox
BUG: 157589

svn path=/trunk/KDE/kdebase/apps/; revision=775977
2008-02-16 22:05:34 +00:00
Script Kiddy
e4a77559f5 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=775970
2008-02-16 21:43:04 +00:00
Peter Penz
9ff4e1f5bf update the selection-toggle (+/-) when the selection has been changed "outside" by the rubberband or e. g. "Select All"
svn path=/trunk/KDE/kdebase/apps/; revision=775828
2008-02-16 18:53:28 +00:00
Peter Penz
9cc43beb59 Bypassed a bug in QTreeView::mouseMoveEvent() (see comment in code). Submitted a bug-report to Trolltech, bug tracker ID is still pending (will add the ID into the code as soon as I get it).
svn path=/trunk/KDE/kdebase/apps/; revision=775736
2008-02-16 14:37:13 +00:00
Peter Penz
67f36d71e7 Provide an option for the details view to expand folders (= tree view), as this is required for Konqueror to get back this functionality from KDE 3. It is possible in Dolphin to enable this option too, but it is set to false per default.
BUG: 155571

svn path=/trunk/KDE/kdebase/apps/; revision=775621
2008-02-16 13:16:59 +00:00
Peter Penz
0706655eab SVN_SILENT: coding style fix (m_metadataWidget -> m_metaDataWidget)
svn path=/trunk/KDE/kdebase/apps/; revision=775612
2008-02-16 12:42:48 +00:00
Peter Penz
790ecfeacf fix possible crash, as MetaDataWidget::metaDataAvailable() can change during runtime
BUG: 157915

svn path=/trunk/KDE/kdebase/apps/; revision=775610
2008-02-16 12:40:38 +00:00
Peter Penz
f70b85b4ca Initially I thought it's better not having code as default value inside dolphin_generalsettings.kcfg. But the check for an empty home URL in DolphinMainWindow::init() must also be done when invoking GeneralSettings::setDefaults() in StartupSettingsPage, otherwise the home URL would get empty... Using QDir::homePath() as default-value inside the *.kcfg file prevents such issues.
CCMAIL: michael.a.oshea@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=775494
2008-02-15 23:13:47 +00:00
Peter Penz
d38de66f4b Currently when the general font of KDE has been changed, the used fonts for the view in Dolphin have not been changed.
This has been fixed by differing between a "Use system font" setting (= default) or a "Use custom font" setting.

TODO: if the general font of KDE is changed during Dolphin is open, no update is done yet

CCMAIL: ereslibre@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=775487
2008-02-15 22:51:23 +00:00
Peter Penz
8f975fec46 David says: "PixmapViewer::setSizeHint should call updateGeometry() instead of all those layout hacks :)" - and as always David was right :-)
CCMAIL: faure@kde.org

svn path=/trunk/KDE/kdebase/apps/; revision=775421
2008-02-15 19:40:27 +00:00
Peter Penz
5bac7f6bde don't connect to a non-existent slot (the code for updateCutItems() is now part of the IconManager)
svn path=/trunk/KDE/kdebase/apps/; revision=775418
2008-02-15 19:32:14 +00:00
Robert Knight
12c6facfce Fix flicker when resizing the central view area in Dolphin. Only applicable with Qt 4.4 with alien widgets enabled. Any widgets passed to KDirLister::setMainWindow() become native widgets because of a call to QWidget::winId() inside KIO. This fix passes the top level Dolphin window to setMainWindow() (which is already a native window) instead of the item view widget.
svn path=/trunk/KDE/kdebase/apps/; revision=775396
2008-02-15 18:18:21 +00:00
David Faure
3d4e6938f5 Add unit test for #149736 (an old bug where a javascript handler closes the window on click - and crashed konqueror again in kde 4)
(the fix is r775367 in kdelibs)
(side node: kapp->setTopWidget call removed since it doesn't care for the icon anymore, only for some startupid stuff)

svn path=/trunk/KDE/kdebase/apps/; revision=775373
2008-02-15 17:01:03 +00:00
Script Kiddy
91944f8182 SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=775353
2008-02-15 15:48:52 +00:00
Script Kiddy
67404bd051 SVN_SILENT made messages (.desktop file)
svn path=/branches/KDE/4.0/kdebase/apps/; revision=775258
2008-02-15 10:07:26 +00:00
Peter Penz
613a132a36 Bypass a temporary (?) regression (?) with the current Qt 4.4 beta version: it seems like QLayout::activate()/update() don't do a relayout anymore if the sizehint of a sub widget has been changed. I'll check this again with Qt 4.4.0.
svn path=/trunk/KDE/kdebase/apps/; revision=775119
2008-02-14 22:57:00 +00:00
Peter Penz
227ebb98eb display an error message if the the user tries to set an invalid home URL in the settings dialog
svn path=/trunk/KDE/kdebase/apps/; revision=775098
2008-02-14 21:35:57 +00:00
Peter Penz
e43bc5a6f6 minor code cleanup
svn path=/trunk/KDE/kdebase/apps/; revision=775094
2008-02-14 21:25:36 +00:00
Peter Penz
bf76805629 backport: fixed issue that the item height does not match to the number of lines in the default setup of Dolphin
svn path=/branches/KDE/4.0/kdebase/apps/; revision=775067
2008-02-14 20:29:29 +00:00
Peter Penz
f260f7b544 fixed issue that the item height does not match to the number of lines in the default setup of Dolphin
svn path=/trunk/KDE/kdebase/apps/; revision=775065
2008-02-14 20:26:11 +00:00
Peter Penz
57e2cd9ae9 ~ is no useful home folder in a Windows environment (thanks to Michael O'Shea for the patch!)
BUG: 156463
CCMAIL: michael.a.oshea@gmail.com

svn path=/trunk/KDE/kdebase/apps/; revision=775056
2008-02-14 20:11:51 +00:00
Script Kiddy
731a32414f SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=774936
2008-02-14 13:04:07 +00:00
Script Kiddy
82a1824ad2 SVN_SILENT made messages (.desktop file)
svn path=/branches/KDE/4.0/kdebase/apps/; revision=774850
2008-02-14 08:26:29 +00:00
David Faure
a8a050952d Provide the "sort by" actions in dolphinpart (konqueror); share and simplify the code by connecting to the actiongroup's signal.
svn path=/trunk/KDE/kdebase/apps/; revision=774699
2008-02-13 20:52:21 +00:00
David Faure
a26be08664 Provide the "sort by" actions in dolphinpart (konqueror); share and simplify the code by connecting to the actiongroup's signal.
svn path=/branches/KDE/4.0/kdebase/apps/; revision=774697
2008-02-13 20:51:00 +00:00
David Faure
87ac707062 --deprecated
svn path=/trunk/KDE/kdebase/apps/; revision=774649
2008-02-13 18:49:30 +00:00
David Faure
4bdbe2b0ac --deprecated
svn path=/branches/KDE/4.0/kdebase/apps/; revision=774648
2008-02-13 18:48:58 +00:00
David Faure
804a196700 Provide the dolphinpart view modes (Icons, Details, Columns) in konqueror's View Modes menu.
(this is done using a Q_PROPERTY in the dolphin part and a signal; the available view modes for creating the menu in the first place are listed in dolphinpart.desktop)
Konqueror: cleaned up the old (complex) handling of view modes as N toolbar buttons from M services grouped by library (240 lines less!).
Dolphin: moved view mode handling to DolphinViewActionHandler, removes duplication between part and mainwindow.

svn path=/trunk/KDE/kdebase/apps/; revision=774646
2008-02-13 18:45:20 +00:00
Script Kiddy
9a8f75e93c SVN_SILENT made messages (.desktop file)
svn path=/trunk/KDE/kdebase/apps/; revision=774640
2008-02-13 18:39:24 +00:00
David Faure
905277aac4 Provide the dolphinpart view modes (Icons, Details, Columns) in konqueror's View Modes menu.
(this is done using a Q_PROPERTY in the dolphin part and a signal; the available view modes for creating the menu in the first place are listed in dolphinpart.desktop)
Konqueror: cleaned up the old (complex) handling of view modes as N toolbar buttons from M services grouped by library.
Dolphin: moved view mode handling to DolphinViewActionHandler, removes duplication between part and mainwindow.
BUG: 157424

svn path=/branches/KDE/4.0/kdebase/apps/; revision=774632
2008-02-13 18:07:34 +00:00
Script Kiddy
bfb1ec7e3a SVN_SILENT made messages (.desktop file, second try)
svn path=/trunk/KDE/kdebase/apps/; revision=774169
2008-02-12 16:54:30 +00:00