Commit graph

5603 commits

Author SHA1 Message Date
Roman Inflianskas
0c9343d614 Fix some compile warnings
Reviewers: markg, elvisangelaccio

Reviewed By: markg, elvisangelaccio

Subscribers: chehrlic, rkflx, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10995
2018-03-10 18:07:47 +03:00
Kai Uwe Broulik
8c1455f96f Fix build without Baloo
That include IS used
2018-03-07 08:55:04 +01:00
Elvis Angelaccio
2523442d4d Revert "Fix some compile warnings"
This reverts commit 533f050855.

D10995 has not been approved.
2018-03-05 21:56:15 +01:00
Roman Inflianskas
48b58f830a Remove unused #include
Summary: I used CLion inspection to hunt all unused #include

Reviewers: #dolphin, elvisangelaccio, markg

Reviewed By: #dolphin, elvisangelaccio, markg

Subscribers: bcooksley, markg, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10985
2018-03-04 21:00:47 +03:00
Roman Inflianskas
533f050855 Fix some compile warnings
Reviewers: #dolphin, markg

Reviewed By: markg

Subscribers: elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10995
2018-03-04 10:27:31 +03:00
Roman Inflianskas
848abc5922 Remove unused #include
Summary: I used CLion inspection to hunt all unused #include

Reviewers: #dolphin, elvisangelaccio, markg

Reviewed By: #dolphin, elvisangelaccio, markg

Subscribers: markg, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10985
2018-03-03 17:08:01 +03:00
Roman Inflianskas
32bd8efc7f Modernize the syntax of shortcuts
Reviewers: #dolphin, markg

Reviewed By: markg

Subscribers: markg, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D10986
2018-03-03 16:44:29 +03:00
Roman Inflianskas
436ad965e9 Add an option to confirm trash emptying into settings
Summary:
Add an option to confirm trash emptying into settings.

BUG: 340572

Reviewers: #dolphin, ngraham, markg

Reviewed By: #dolphin, ngraham, markg

Subscribers: markg, ngraham, rkflx, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D10968
2018-03-03 08:46:55 +03:00
Roman Inflianskas
bf0d259ae5 Add default shortcut "/" for opening filter panel
Summary:
Add default shortcut "/" for opening filter panel.

FEATURE: 156381

Reviewers: #dolphin, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: ngraham, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D10961
2018-03-03 08:38:03 +03:00
l10n daemon script
e46421bfee SVN_SILENT made messages (.desktop file) - always resolve ours
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-03-03 05:23:49 +01:00
Nathaniel Graham
b95cc59091 Also use standard keyboard shortcut for "show/hide hidden files"
Summary:
Use Ctrl+H as another keyboard shortcut to show and hide hidden files, as it is already the standard used in other GTK-based Linux file managers (Nautilus, Nemo, Caja, Thunar, Pantheon Files). This doesn't replace any existing shortcuts, so existing KDE users' muscle memory is retained.

FEATURE: 390527
FIXED-IN: KDE Applications 17.12.3

Test Plan:
- Ctrl+H now shows and hides hidden files
- Alt+. still works to do the same
- F8 still works to do the same
- Toolbar button still changes state appropriately when any of the three shortcuts are used

Reviewers: #dolphin, elvisangelaccio

Reviewed By: elvisangelaccio

Subscribers: emateli, elvisangelaccio

Differential Revision: https://phabricator.kde.org/D10558
2018-02-18 15:02:07 -07:00
Kai Uwe Broulik
ae67f99195 [Information Panel] Adjust painting icons for high dpi scaling
Instead of creating our own KIconLoader (which takes ~5ms here) just use QIcon::fromTheme which already does everything right.

BUG: 390488

Differential Revision: https://phabricator.kde.org/D10532
2018-02-15 13:37:08 +01:00
Marjio Mustac
9a7569a82a Add icons to Edit menu
Summary:
Since Breeze offers such a great palette of action icons I thought we should make use of them which make things also more consistent with other applications.

Before:
{F5711158}

After:
{F5711159}

Test Plan:
Show menubar
Icons are shown in Edit menu

Reviewers: #dolphin, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: ngraham

Differential Revision: https://phabricator.kde.org/D10503
2018-02-14 07:43:38 -07:00
Elvis Angelaccio
5f57256a2f Merge branch 'Applications/17.12' 2018-02-13 23:20:49 +01:00
Robert Hoffmann
a618383df3 Fix resetting "View Modes" preferences to defaults
Summary:
Removed call to settings.readConfig() in ViewSettingsTab::loadSettings(),
because it overwrites default settings with user settings even if called
from ViewSettingsTab::restoreDefaultSettings().

Test Plan:
Settings -> Configure Dolphin -> View Modes:
Choose "Custom Font", "Choose...": other font settings than preselected;
alter "Icon Size" slider positions;
click OK; OK;
note modified text font next to icons, icon sizes

Settings -> Configure Dolphin -> View Modes:
Click "Defaults"
check "Font" is reset to "System Font";
check "Icon Size" slider positions are reset to default positions;
click OK
check text font next to icons, icon sizes are reset to defaults

Subscribers: ltoscano, ngraham, elvisangelaccio, michaelh, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D10190
2018-02-13 23:12:44 +01:00
Elvis Angelaccio
e136d8cfeb Fix Windows build
kill() is not available on Windows. Now that we build TerminalPanel
everywhere (see 87e8d0ba), we need to #ifdef this call.
2018-02-11 23:01:17 +01:00
Elvis Angelaccio
3dcfb75362 Fix typo
GIT_SILENT
2018-02-11 22:59:29 +01:00
Elvis Angelaccio
87e8d0ba5f Build TerminalPanel also on Windows
Summary:
terminalpanel.cpp *should* compile on Windows, so there is no reason to
remove it from the build and use tons of #ifdefs in dolphinmainwindow.

We still keep the terminal panel disabled on Windows
(i.e. the two remaining #ifndef Q_OS_WIN in dolphinmainwindow),
because it is probably not functional.

But at least we won't break the Windows CI every time
someone touches the terminal panel code (see e.g. 2e942237c9).

Test Plan: Builds on Linux, someone on Windows should test this patch if possible.

Reviewers: #dolphin, #craft

Differential Revision: https://phabricator.kde.org/D10006
2018-02-10 19:40:15 +01:00
Jaime Torres
9fbf7a0b62 Faster drag&drop in directories with thousands of files
Summary:
The check is called when the mouse is moved in a drag&drop operation.

Dragging all files in a directory with 3000 files under callgrind,
moving the mouse to the other panel and then canceling, doing it twice,
callgrind shows that the method urlListMatchesUrl is called around
200 times, spending around 9,30% of the cpu in those calls.
Applying the patch, callgrind tells it uses now 0.31% of the cpu in 1208 calls.

CCBUG: 342056

Reviewers: #dolphin, elvisangelaccio, markg

Reviewed By: #dolphin, elvisangelaccio, markg

Subscribers: markg, anthonyfieroni, michaelh, elvisangelaccio, ngraham

Differential Revision: https://phabricator.kde.org/D10085
2018-02-05 19:25:44 +01:00
Kai Uwe Broulik
20d57ab488 [KStandardItemListWidget] Adjust painting rating to device pixel ratio
Differential Revision: https://phabricator.kde.org/D10324
2018-02-05 16:27:58 +01:00
Elvis Angelaccio
ecbab34510 Fix all krazy #include warnings
- "include own header first line"
- "put config.h in angle brackets line"
- "do not include QtModule/QtClass line"

`QElapsedTimer` was implicitly included by
kfileitemmodelsortalgorithm.h, now we need to explicitly include it in
kfileitemmodel.cpp.

We also need to explicitly link to `Qt5::Concurrent`, otherwise we
cannot `#include <QtConcurrentRun>`.
2018-02-04 11:38:50 +01:00
Elvis Angelaccio
219e40cff8 Use qplatformdefs wrappers
As recommended by krazy and as kio does.
2018-02-04 11:13:34 +01:00
Elvis Angelaccio
56b132fff0 Drop dead code
Spotted by clazy (-Wclazy-const-signal-or-slot).

This was added in abf17941f7, but it became dead code after the KF5 port
(possibly after c725848709).
2018-02-03 23:34:45 +01:00
Elvis Angelaccio
a90daf82b6 Fix -Wunused-result warnings 2018-02-03 22:34:24 +01:00
Elvis Angelaccio
bf1081a824 Fix all 'explicit constructor' krazy warnings 2018-02-03 22:21:30 +01:00
Elvis Angelaccio
cef4d96cc6 Port QSignalSpy to new signal syntax
More compile-time safety. Tests still pass.

This also fixes a krazy warning about "normalised signal/slot
signatures".
2018-02-03 20:46:08 +01:00
Elvis Angelaccio
4709626a9b Use new KStandardAction slot syntax
This was probably forgotten from commit 3bfdf0d2.
2018-02-03 20:30:37 +01:00
Elvis Angelaccio
4112c38605 Fix typo spotted by krazy
GIT_SILENT
2018-02-03 19:59:40 +01:00
Elvis Angelaccio
e7e35a528a Add newline at the end of kitemmodelbase.cpp
As recommended by krazy.

GIT_SILENT
2018-02-03 19:42:50 +01:00
Albert Astals Cid
ee5736bc06 GIT_SILENT Upgrade KDE Applications version to 17.12.2. 2018-02-03 00:38:57 +01:00
Nathaniel Graham
0dd0b65bf0 Merge branch 'Applications/17.12' 2018-01-30 17:06:43 -07:00
Nathaniel Graham
108e10ca15 Let the terminal panel dock to any part of the window
Summary:
BUG: 362593

Just what it says: Let the terminal panel sit on the left or right side of the window.

Test Plan:
Tested in KDE Neon:
- Opened terminal panel, unlocked widgets, and tried to drag it to the right or left side of the window: I can
- Put terminal panel on right side, quit Dolphin and opened Dolphin again: terminal panel appears on the right as expected
- Put terminal panel on right side, closed terminal panel, quit Dolphin, opened Dolphin, and opened the terminal panel again: terminal panel appears on the right as expected
- Removed dolphinrc file and opened terminal panel: appears on the bottom

{F5682428}

Reviewers: #dolphin

Subscribers: elvisangelaccio, anthonyfieroni, cfeck

Differential Revision: https://phabricator.kde.org/D10189
2018-01-30 17:06:20 -07:00
Nathaniel Graham
58f8b515b8 Let the terminal panel sit on the left or right side of the window
Summary: Just what it says: Let the terminal panel sit on the left or right side of the window.

Test Plan: Tested in KDE Neon. Works great!

Reviewers: #dolphin

Differential Revision: https://phabricator.kde.org/D10189
2018-01-29 17:06:06 -07:00
Marco Martin
0b130dd57e base scrolling on the smallest item
Summary:
CCBUG: 386379

after recent highdpi patches on scrolling that delegated it
completely to the scrollbar, based upon the scrollbar singleStep
setted to the tallest of the items in the view.
tough this makes scrolling way too fast, and on folders where just
few filenames are longer than most we can get a single scrolling
step almost double the number of lines configured in the
mouse kcm.
Using the shortest item instead of the tallest mitigates this problem
making it a bit more usable

Test Plan:
tested on different folders in different view modes both with
mouse and touchpad

Reviewers: #dolphin, broulik, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10102
2018-01-29 11:54:12 +01:00
Elvis Angelaccio
7caef6d251 Port away from deprecated QStyle::SH_Widget_Animate
Summary:
Use the new QStyle::SH_Widget_Animation_Duration instead,
which allows us to not manually hardcode the duration.
We still use 1 if animations are disabled,
otherwise the scroll would not work at all.

See also D5883 for some background.

Test Plan: Played with different values in the Animation tab of the Breeze config dialog.

Reviewers: #dolphin, broulik

Reviewed By: broulik

Subscribers: broulik

Differential Revision: https://phabricator.kde.org/D10005
2018-01-27 17:40:59 +01:00
Chinmoy Ranjan Pradhan
c5eb4e3116 Use BatchRenameJob to rename multiple files in Dolphin
Summary:
Use KIO::BatchRenameJob in Dolphin::RenameDialog to rename multiple files.
With this viewing progress of rename operation and undo is possible.

See D9103 and D9107.

Reviewers: #dolphin, elvisangelaccio

Subscribers: elvisangelaccio, ngraham, broulik

Differential Revision: https://phabricator.kde.org/D9836
2018-01-27 17:21:30 +05:30
Elvis Angelaccio
add821885d Bump minimum KF5 version
This should have been part of D9333.
2018-01-27 11:24:10 +01:00
Renato Araujo Oliveira Filho
a8a3fa51a0 Fix place item edit after creation
Summary:
Make sure that the place can be edited after the creation.

Depends on D9333

BUG: 389147

Test Plan:
Create an item in dolphin places panel, make sure that you
can rename it

Reviewers: #dolphin, ngraham

Reviewed By: ngraham

Subscribers: michaelh, elvisangelaccio, lbeltrame, ngraham, #dolphin

Differential Revision: https://phabricator.kde.org/D9985
2018-01-26 11:14:30 -03:00
Renato Araujo Oliveira Filho
3bf68fd714 Make sure that old URLs do not appear duplicated in places model
Summary:
BUG: 389401

KIO model now provides Baloo URLs; we need to remove the old ones
created by Dolphin places model

BUG: 387888
Depends on D9332

Test Plan: unit test

Reviewers: mwolff, #dolphin, ngraham, elvisangelaccio

Reviewed By: #dolphin, ngraham, elvisangelaccio

Subscribers: elvisangelaccio, broulik, ervin, ngraham, #dolphin

Differential Revision: https://phabricator.kde.org/D9333
2018-01-26 11:07:59 -03:00
Julian Schraner
ea6a2424fb Add option to sort for original date
Summary:
Takes the original date a photo was taken out of the data provided by Baloo & makes it available to the user

FEATURE: 303645

{F5671033}

Test Plan:
- Works with a batch of time-tagged photos
- Can be hidden/shown/sorted like any other property

Reviewers: #dolphin, ngraham, elvisangelaccio

Reviewed By: #dolphin, ngraham, elvisangelaccio

Subscribers: elvisangelaccio, ngraham

Differential Revision: https://phabricator.kde.org/D10059
2018-01-23 16:33:30 -07:00
Andreas Krutzler
bba44ae907 Fix renamed file reclaims focus
Summary:
After renaming a file and then selecting another file immediately the just selected file stays selected.

BUG: 388555

Test Plan:
Steps to reproduce:
$ mkdir /tmp/test
$ cd /tmp/test
$ touch a.tmp b.tmp
$ dolphin /tmp/test

In dolphin:
* select a.tmp
* <F2>
* type aaa
* select b.tmp immediately

Expected result:
* a.tmp renamed to aaa.tmp
* b.tmp stays selected, aaa.tmp stays unselected

Reviewers: ngraham, michaelh, #dolphin, elvisangelaccio

Reviewed By: ngraham, michaelh, #dolphin, elvisangelaccio

Subscribers: emateli, elvisangelaccio, #dolphin

Differential Revision: https://phabricator.kde.org/D9711
2018-01-21 13:43:30 -07:00
Elvis Angelaccio
6cf74d2fdd Don't show 'Open Terminal' on Windows
We already disable the TerminalPanel on Windows, we should do the same
with the 'Open Terminal' action for consistency.
2018-01-21 12:15:07 +01:00
Luca Beltrame
d55b0875ff Revert "Ignore baloo urls created from new KIO model"
This reverts commit 9d3a019445.

Causes breakage in Dolphin in master. The proper fix is in D9333.

CCBUG: 389147
2018-01-19 13:27:52 +01:00
Adrián Chaves (Gallaecio)
2e942237c9 Exclude m_terminalPanel references when built on Windows
Fixes an issue reported by elvisangelaccio at https://phabricator.kde.org/D9955
2018-01-18 20:30:59 +01:00
Adrián Chaves Fernández (Gallaecio)
4e40fe810d Set the focus to the active view, after leaving the terminal panel
Summary:
BUG: 298467

Set the focus to the active view, after leaving the terminal panel.

This is a fork of the patch at https://git.reviewboard.kde.org/r/116118/ by @emmanuelp which should fix the issue with the original patch reported by Frank Reininghaus.

Test Plan: Works for me.

Reviewers: #dolphin, emmanuelp, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: ngraham, emmanuelp

Differential Revision: https://phabricator.kde.org/D9955
2018-01-18 18:51:27 +01:00
Luca Beltrame
1a6b3c0a2b Merge remote-tracking branch 'origin/Applications/17.12'
Conflicts:
	CMakeLists.txt [versions]
	src/panels/places/placesitemmodel.cpp
2018-01-18 09:09:49 +01:00
Michael Heidelbach
64d2fd2981 Folderspanel's context-menu option "Limit to Home Directory" is always visible
Summary:
Applied suggested changes to [[ https://phabricator.kde.org/D9662 | D9662 ]]
  - Enum instead of bool
  - Use QStringLiteral

Test Plan: Visual inspection

Reviewers: ngraham, elvisangelaccio, #dolphin

Reviewed By: ngraham, #dolphin

Subscribers: #dolphin

Tags: #dolphin, #kde_applications

Differential Revision: https://phabricator.kde.org/D9911
2018-01-18 08:56:43 +01:00
Michael Heidelbach
3cb3d58fbf folderspanel context-menu option "Limit to Home Directory" should be always visible
Summary:
Only by chance I discovered that this option is visible but only when inside home. Before that I always edited dolphinrc to reenable it.
I think it's less confusing to always show it but toggle its enabled state

Test Plan:
compile and run
show folderspanel context-menu in different places

Reviewers: #dolphin, emmanuelp, ngraham

Reviewed By: #dolphin, ngraham

Subscribers: elvisangelaccio

Tags: #dolphin, #kde_applications

Differential Revision: https://phabricator.kde.org/D9662
2018-01-14 10:54:46 -07:00
Kai Uwe Broulik
dedb612764 Explicitly pass iconNameForUrl when dropping places entry
Differential Revision: https://phabricator.kde.org/D9609
2018-01-11 16:08:39 +01:00
Kai Uwe Broulik
bdcf12026d [KStandardItemListWidget] Don't paint overlay outside view for devicePixelRatio > 1
Translate the position by devicePixelRatio

REVIEW: 129084
2018-01-11 12:01:23 +01:00