kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 01:40:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix resetting "View Modes" preferences to defaults

Browse source 
Summary:
Removed call to settings.readConfig() in ViewSettingsTab::loadSettings(),
because it overwrites default settings with user settings even if called
from ViewSettingsTab::restoreDefaultSettings().

Test Plan:
Settings -> Configure Dolphin -> View Modes:
Choose "Custom Font", "Choose...": other font settings than preselected;
alter "Icon Size" slider positions;
click OK; OK;
note modified text font next to icons, icon sizes

Settings -> Configure Dolphin -> View Modes:
Click "Defaults"
check "Font" is reset to "System Font";
check "Icon Size" slider positions are reset to default positions;
click OK
check text font next to icons, icon sizes are reset to defaults

Subscribers: ltoscano, ngraham, elvisangelaccio, michaelh, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D10190
This commit is contained in:
Robert Hoffmann 2018-02-13 23:12:44 +01:00 committed by Elvis Angelaccio
parent ee5736bc06
commit a618383df3
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/settings/viewmodes/viewsettingstab.cpp
View file

@ -232,8 +232,7 @@ void ViewSettingsTab::loadSettings()
break;
}
ViewModeSettings settings(viewMode());
settings.readConfig();
const ViewModeSettings settings(viewMode());
const QSize iconSize(settings.iconSize(), settings.iconSize());
m_defaultSizeSlider->setValue(ZoomLevelInfo::zoomLevelForIconSize(iconSize));