Script Kiddy
3619edf41a
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=828584
2008-07-06 05:35:58 +00:00
David Faure
60ac42c048
Don't connect multiple times to the selectionChanged signal, otherwise the slot will be called as many times as we entered a directory...
...
svn path=/trunk/KDE/kdebase/apps/; revision=828216
2008-07-04 22:26:05 +00:00
David Faure
9078232033
re-enable, fix came in quickly after all
...
svn path=/trunk/KDE/kdebase/apps/; revision=828101
2008-07-04 17:16:56 +00:00
Sebastian Trueg
f7f7f460e2
Forgot to commit new method
...
svn path=/trunk/KDE/kdebase/apps/; revision=828091
2008-07-04 16:58:55 +00:00
David Faure
d611a7e35a
quick fix for compilation
...
svn path=/trunk/KDE/kdebase/apps/; revision=828090
2008-07-04 16:49:20 +00:00
Sebastian Trueg
90019a84c6
Do not show an ugly confusing message to users but simple open the tagging widget on mouse click
...
svn path=/trunk/KDE/kdebase/apps/; revision=828078
2008-07-04 15:26:39 +00:00
Script Kiddy
8b64b18ae7
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=827249
2008-07-02 13:27:02 +00:00
Peter Penz
3da35b5c1c
fixed wrong logic for showing the space info: if the progress bar is shown, the space info may never be shown
...
svn path=/trunk/KDE/kdebase/apps/; revision=826897
2008-07-01 19:08:17 +00:00
Script Kiddy
2f0c966c30
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=826707
2008-07-01 06:52:44 +00:00
Peter Penz
fbfcbd5b95
* use existing KFileItem also for the selection instead of creating a new KFileItem from the URL
...
* don't invoke fileItem() if a multiple selection is provided
svn path=/trunk/KDE/kdebase/apps/; revision=826393
2008-06-30 17:12:03 +00:00
Peter Penz
3bc3ca1458
Move the "Find File..." action from DolphinMainWindow to DolphinViewActionHandler, so that is used in DolphinPart and hence also in Konqueror. Thanks to Bram for the patch!
...
CCMAIL: bramschoenmakers@kde.nl
CCMAIL: faure@kde.org
svn path=/trunk/KDE/kdebase/apps/; revision=826383
2008-06-30 16:37:08 +00:00
Peter Penz
823b033ab7
dispatch the preview queue immediately before resuming the preview generation
...
svn path=/trunk/KDE/kdebase/apps/; revision=826230
2008-06-30 06:31:28 +00:00
Peter Penz
9226a063b0
when moving the visible items to the front of the list, take care not to reverse the order
...
svn path=/trunk/KDE/kdebase/apps/; revision=826161
2008-06-29 22:25:02 +00:00
Peter Penz
dbe0566f43
Use fast image transformation like Gwenview. This increases the performance of applyImageFrame() by a factor of >2.
...
Hmm, previews don't look so smooth as before, but even when having a 2 GHz CPU a bilinear scaling of 1000 previews just takes too much time.
svn path=/trunk/KDE/kdebase/apps/; revision=826128
2008-06-29 21:54:41 +00:00
Peter Penz
4cf8450bc4
The check whether there is a cut-selection when receiving a preview consumes 12 % (!) of the runtime in addToPreviewQueue(). The check is now done only once before starting the preview generation and when the clipboard data has been changed.
...
svn path=/trunk/KDE/kdebase/apps/; revision=826126
2008-06-29 21:40:07 +00:00
Peter Penz
1f3607bdc1
Move the block for resizing the preview, applying an item effect + border to the slot where the preview has been received. This reduces the blocking of the GUI for the following usecase:
...
- folder with 1000 items
- ~30 items are visible
Old approach:
- Show the 30 items as soon as possible.
- Receive preview and add it to the queue. This is done asynchronously 970 times (no UI blocking).
- Iterate through 970 items, resize, apply item effect + border and apply the preview to the model (-> blocking of UI thread for more than 3 seconds).
New approach:
- Show the 30 items as soon as possible.
- Receive preview, resize it, apply item effect + border and add it to the queue. This is done asynchronously 970 times (no UI blocking).
- Iterate through 970 items and apply the preview to the model (-> UI thread is blocked only very short).
svn path=/trunk/KDE/kdebase/apps/; revision=826109
2008-06-29 21:04:43 +00:00
Script Kiddy
fdd06835fc
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=826056
2008-06-29 19:06:43 +00:00
Peter Penz
4af0c48f05
Internal cleanup: Make it easier getting the correct file item that should be used for showing the meta information (it depends on the current selection and whether the file item is already available).
...
CCMAIL: sebastian@trueg.de
svn path=/trunk/KDE/kdebase/apps/; revision=825996
2008-06-29 17:08:49 +00:00
Peter Penz
85b0ed6a63
Don't grey out an invalid preview immediately, but with a small timeout. This prevents a flickering if the new preview can be generated within a small timeframe.
...
BUG: 165317
svn path=/trunk/KDE/kdebase/apps/; revision=825942
2008-06-29 16:42:59 +00:00
Peter Penz
5372176640
SVN_SILENT: Renamed m_timer to m_infoTimer and slotTimeout() to slotInfoTimeout(), as preperation for a new timer that prevents a flickering of outdated previews.
...
svn path=/trunk/KDE/kdebase/apps/; revision=825916
2008-06-29 16:24:09 +00:00
Peter Penz
b5de4d8ffb
Don't disable the "Properties" action when no file is selected, just use the current folder as source. TODO: the code in DolphinPart::slotProperties() and DolphinMainWindow::properties() is quite similar -> move to DolphinViewActionHandler?
...
CCMAIL: faure@kde.org
BUG: 165311
svn path=/trunk/KDE/kdebase/apps/; revision=825846
2008-06-29 13:54:52 +00:00
Peter Penz
cb32d720d1
provide Ctrl+T as alternative shortcut to Ctrl+Shift+N for "New Tab" like Konqueror
...
BUG: 165309
svn path=/trunk/KDE/kdebase/apps/; revision=825833
2008-06-29 13:36:53 +00:00
Urs Wolfer
8677eafd24
Improve mouse middle click path paste behavior: first check selection clipboard, after 'real' clipboard. Before setting new URL, check if it is a path. This prevents a crash. Behavior is now similar to Konqueror KDE 3.
...
Reviewed by Peter Penz.
svn path=/trunk/KDE/kdebase/apps/; revision=825771
2008-06-29 10:59:24 +00:00
Peter Penz
c446e29bc3
Don't check for "kompare" each time 2 items are selected (thanks to Andreas Scherf). As Albert Astals Cid pointed out it might be nicer to use a menu plugin instead of hardcoding "kompare" (> KDE 4.1).
...
CCMAIL: scherfa@arcor.de
svn path=/trunk/KDE/kdebase/apps/; revision=825587
2008-06-28 18:42:51 +00:00
Peter Penz
15979f49c0
Also allow to use the selection toggle when double click is used. This allows to select/deselect files without CTRL key.
...
BUG: 165115
svn path=/trunk/KDE/kdebase/apps/; revision=825325
2008-06-27 20:20:33 +00:00
Peter Penz
4e4c8d01e3
SVN_SILENT: fix documentation typo
...
svn path=/trunk/KDE/kdebase/apps/; revision=825319
2008-06-27 20:05:15 +00:00
Peter Penz
d96712f50e
tried to simplify the logic to decide whether the information panel should show the information for one file or for a multiple selection
...
CCMAIL: sebastian@trueg.de
svn path=/trunk/KDE/kdebase/apps/; revision=825317
2008-06-27 20:01:04 +00:00
Peter Penz
3a6ee0eee8
Avoid blocking of the GUI when creating previews for invisible items. The blocking part is a relayout, that has been done each time a group of previews have been received.
...
Now only for the visible items a relayout is done as soon as possible, for the previews of invisible items this is postponed until all previews have been generated.
svn path=/trunk/KDE/kdebase/apps/; revision=825304
2008-06-27 19:36:44 +00:00
Sebastian Trueg
868d2c946a
It is hard to understand which is the actual selected item here: m_selection, m_fileItem, or m_shownUrl. Anyway, now the descision for the metadata uses the exact same algo as for the name and preview and it works.
...
svn path=/trunk/KDE/kdebase/apps/; revision=825279
2008-06-27 18:34:52 +00:00
Peter Penz
d6cddc8c7d
Assure that the file capabilities are respected when opening the context menu for the Folder Panel (= treeview). Disable actions that cannot be executed.
...
svn path=/trunk/KDE/kdebase/apps/; revision=824950
2008-06-26 22:34:40 +00:00
Peter Penz
f067201e9f
respect the inline-renaming setting also for the Folder Panel (= treeview)
...
svn path=/trunk/KDE/kdebase/apps/; revision=824946
2008-06-26 22:23:09 +00:00
Peter Penz
71634554cf
assure that the tooltip never exceeds the desktop area
...
BUG: 161895
svn path=/trunk/KDE/kdebase/apps/; revision=824927
2008-06-26 21:41:13 +00:00
Sebastian Trueg
5be4abc3a8
Properly handle setting of an empty tag list.
...
BUG: 164705
svn path=/trunk/KDE/kdebase/apps/; revision=824616
2008-06-26 11:06:44 +00:00
Dirk Mueller
6861a87683
fix linking
...
svn path=/trunk/KDE/kdebase/apps/; revision=824530
2008-06-26 01:29:37 +00:00
Script Kiddy
554a3b1dc2
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=824402
2008-06-25 17:27:50 +00:00
Peter Penz
0df5527c21
fixed issue that CTRL + mouseclick did not work anymore in the details view
...
BUG: 164693
svn path=/trunk/KDE/kdebase/apps/; revision=824372
2008-06-25 17:04:12 +00:00
Peter Penz
fa9da5cbaf
faster + nicer (thanks to André Wöbbeking for the hint)
...
svn path=/trunk/KDE/kdebase/apps/; revision=824312
2008-06-25 16:29:16 +00:00
Peter Penz
65e72704e3
remember old setting of the uniformItemSizes property and restore it again (thanks to Rafael for the hint)
...
CCMAIL: ereslibre@kde.org
svn path=/trunk/KDE/kdebase/apps/; revision=824128
2008-06-24 23:38:52 +00:00
Peter Penz
dcf7529688
Performance improvement when showing previews inside directories having several 1000 items: temporary block the expensive layouting inside QListView until a block of previews has been applied.
...
CCMAIL: fredrik@kde.org
CCMAIL: faure@kde.org
CCMAIL: ereslibre@kde.org
svn path=/trunk/KDE/kdebase/apps/; revision=824118
2008-06-24 23:01:21 +00:00
Script Kiddy
f56394e276
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=823977
2008-06-24 14:18:37 +00:00
Script Kiddy
2d57408d22
SVN_SILENT made messages (.desktop file)
...
svn path=/trunk/KDE/kdebase/apps/; revision=822978
2008-06-22 10:35:45 +00:00
Peter Penz
30cb4c1ef2
Assure that the keyboard focus stays inside the view when replacing the view implementation, otherwise when having a split view the other view gets the focus and will activate itself.
...
BUG: 164468
svn path=/trunk/KDE/kdebase/apps/; revision=822367
2008-06-19 22:43:10 +00:00
Laurent Montel
71a6ab3c9b
Fix mem leak
...
svn path=/trunk/KDE/kdebase/apps/; revision=822130
2008-06-19 09:37:49 +00:00
Script Kiddy
1af667f6fd
SVN_SILENT made messages (.desktop file, second try)
...
svn path=/trunk/KDE/kdebase/apps/; revision=822007
2008-06-18 21:37:23 +00:00
Peter Penz
afe18732f2
KFileItem::url() returns per value, not per reference
...
svn path=/trunk/KDE/kdebase/apps/; revision=822003
2008-06-18 21:23:06 +00:00
Peter Penz
4f3e1b0c24
the method dropUrls(KUrl::List, KUrl) was never used as slot and is invoked only once -> moved to caller
...
svn path=/trunk/KDE/kdebase/apps/; revision=822000
2008-06-18 21:19:46 +00:00
Peter Penz
84376acc84
it's assured that when requesting a context menu that the column is marked as active
...
svn path=/trunk/KDE/kdebase/apps/; revision=821938
2008-06-18 20:01:25 +00:00
Peter Penz
5b541d04e5
SVN_SILENT: removed unnecessary includes
...
svn path=/trunk/KDE/kdebase/apps/; revision=821923
2008-06-18 19:52:15 +00:00
Peter Penz
b8a4e0fac2
Assure that when requesting the context menu for the column-view, that the correct items are used.
...
TODO for 4.2: get rid of those 'if (isColumnViewActive())' special cases and provide a generic model which also works with the way the column view is implemented
BUG: 164146
svn path=/trunk/KDE/kdebase/apps/; revision=821903
2008-06-18 19:34:03 +00:00
James Richard Tyrer
91607d4c4d
Correcting icon name from "view_icon" to "view-icon"
...
svn path=/trunk/KDE/kdebase/apps/; revision=821583
2008-06-17 21:29:51 +00:00