kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-08-22 01:40:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dolphinview] Disconnect modelChanged when destructing

Browse source 
Deleting DolphinView deletes KItemListContainer, which deletes
KItemListController, which emits modelChanged, which causes a
signal delivery to the already destroyed DolphinView

This is never good, and in Qt6 causes an assert
(https://codereview.qt-project.org/c/qt/qtbase/+/381860).

Co-authored-by: Nicolas Fella <nicolas.fella@gmx.de>
This commit is contained in:
Felix Ernst 2022-09-15 14:15:31 +02:00
parent 8ff021ca69
commit 3dd49a8539
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/views/dolphinview.cpp
View file

@ -235,6 +235,7 @@ DolphinView::DolphinView(const QUrl& url, QWidget* parent) :
DolphinView::~DolphinView()
{
disconnect(m_container->controller(), &KItemListController::modelChanged, this, &DolphinView::slotModelChanged);
}
QUrl DolphinView::url() const