From 3dd49a85396a47f943c722047d44212b8d1600ee Mon Sep 17 00:00:00 2001 From: Felix Ernst Date: Thu, 15 Sep 2022 14:15:31 +0200 Subject: [PATCH] [dolphinview] Disconnect modelChanged when destructing Deleting DolphinView deletes KItemListContainer, which deletes KItemListController, which emits modelChanged, which causes a signal delivery to the already destroyed DolphinView This is never good, and in Qt6 causes an assert (https://codereview.qt-project.org/c/qt/qtbase/+/381860). Co-authored-by: Nicolas Fella --- src/views/dolphinview.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/views/dolphinview.cpp b/src/views/dolphinview.cpp index a00d485c85..ea2956924b 100644 --- a/src/views/dolphinview.cpp +++ b/src/views/dolphinview.cpp @@ -235,6 +235,7 @@ DolphinView::DolphinView(const QUrl& url, QWidget* parent) : DolphinView::~DolphinView() { + disconnect(m_container->controller(), &KItemListController::modelChanged, this, &DolphinView::slotModelChanged); } QUrl DolphinView::url() const