kde/dolphin
kde/dolphin
1
0
Fork 0
mirror of https://invent.kde.org/system/dolphin synced 2024-10-05 16:19:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed build-time deprecation warning about KStandardGuiItem::yes()

Browse source 
While building dolphin, a warning comes up about KStandardGuiItem::yes()
being deprecated, and that another action verb should be using instead.
This commit fixes the warning by replacing KStandardGuiItem::yes() with
a KGuiItem constructor in the file src/views/dolphinview.cpp. 

The icon for the "Rename and Hide" button has also been changed from a 
check mark (dialog-ok) to an eye with a cross (view-hidden) to make the 
button look more unique and grab the attention of the user.
This commit is contained in:
Shivodit Gill 2022-11-25 10:58:07 +00:00 committed by Felix Ernst
parent a7c63f7af7
commit 1c22a23d90
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/views/dolphinview.cpp
View file

@ -1906,8 +1906,7 @@ void DolphinView::slotRoleEditingFinished(int index, const QByteArray& role, con
#ifndef Q_OS_WIN
//Confirm hiding file/directory by renaming inline
if (!hiddenFilesShown() && newName.startsWith(QLatin1Char('.')) && !oldItem.name().startsWith(QLatin1Char('.'))) {
KGuiItem yesGuiItem(KStandardGuiItem::yes());
yesGuiItem.setText(i18nc("@action:button", "Rename and Hide"));
KGuiItem yesGuiItem(i18nc("@action:button", "Rename and Hide"), QStringLiteral("view-hidden"));
#if KWIDGETSADDONS_VERSION >= QT_VERSION_CHECK(5, 100, 0)
const auto code = KMessageBox::questionTwoActions(this,