Commit graph

8 commits

Author SHA1 Message Date
Alexander Larsson 039cc3aaff Make Go to CD burner a command
2003-05-05  Alexander Larsson  <alexl@redhat.com>

	* src/nautilus-shell-ui.xml:
	Make Go to CD burner a command

	* src/nautilus-window-menus.c (nautilus_window_initialize_menus_part_1):
	Hide Go to CD burner if burn: not availible.

	* docs/style-guide.html:
	Clarify the change. We still have to declare variables at the
	beginning of a block.
2003-05-05 09:55:59 +00:00
Alexander Larsson 76b51b4e24 Remove the all-declarations-on-top rule.
2003-04-30  Alexander Larsson  <alexl@redhat.com>

	* docs/style-guide.html:
	Remove the all-declarations-on-top rule.
2003-04-30 16:22:54 +00:00
Darin Adler 31c20fa038 Updated bugzilla.eazel.com references to refer to the
corresponding bugzilla.gnome.org bug. Also updated my
	email address.
2001-09-15 19:18:15 +00:00
Darin Adler 47b25905a0 Some FIXME cleanup.
* components/help/converters/gnome-db2html2/sect-elements.c:
	(sect_article_end_element), (sect_inlinegraphic_start_element):
	* components/help/converters/gnome-db2html2/toc-elements.c:
	(toc_sect_end_element):
	* components/mozilla/mozilla-events.cpp:
	* components/mozilla/nautilus-mozilla-content-view.c:
	(make_full_uri_from_relative), (eazel_services_scheme_translate):
	* components/music/nautilus-music-view.c:
	(nautilus_music_view_initialize),
	(music_view_set_selected_song_title), (reset_playtime),
	(play_status_display), (slider_moved_callback),
	(add_play_controls):
	* components/notes/nautilus-notes.c: (notes_load_metainfo):
	* components/services/install/lib/eazel-install-logic.c:
	(eazel_install_check_for_file_conflicts),
	(eazel_install_do_transaction_all_files_check),
	(eazel_install_prune_packages_helper),
	(eazel_install_check_existing_packages):
	* libnautilus-extensions/nautilus-string.c: (nautilus_strcmp),
	(nautilus_strcasecmp), (nautilus_strcmp_case_breaks_ties),
	(nautilus_strcoll), (nautilus_str_is_equal),
	(nautilus_istr_is_equal), (nautilus_strcmp_compare_func),
	(nautilus_strcoll_compare_func),
	(nautilus_strcasecmp_compare_func):
	* src/file-manager/fm-directory-view.c: (open_location):
	* src/nautilus-first-time-druid.c: (make_anti_aliased_label),
	(make_hbox_user_level_radio_button), (set_up_user_level_page):
	Added bug numbers to FIXMEs. At one point Josh made some bugs for
	FIXMEs but never got around to checking in the bug numbers in the
	source code. And I wrote one bug report.

	* components/music/nautilus-music-view.c:
	(nautilus_music_view_initialize): Removed a fixed FIXME. Also got
	rid of a hard-coded constant and took excess spaces out of some
	string constants.

	* components/services/install/lib/eazel-install-object.c:
	(eazel_install_emit_dependency_check_default): Changed a FIXME
	into a non-FIXME comment, now the the bug is fixed.

	* components/services/install/lib/eazel-package-system-rpm3.c:
	(rpm_packagedata_fill_from_file): Removed an incorrect bug number
	from a FIXME.

	* components/services/install/nautilus-view/nautilus-service-install-view.h:
	* components/services/install/nautilus-view/nautilus-service-install-view.c:
	(nautilus_service_install_installing): Removed the FIXME from a
	comment that's about how a bug was fixed.

	* components/services/trilobite/libtrilobite/trilobite-md5-tools.h:
	* components/services/trilobite/libtrilobite/trilobite-md5-tools.c:
	* docs/style-guide.html:
	Removed FIXME and corrected misunderstanding about whether use of
	the guchar typedef is recommended in Nautilus coding style.

	* libnautilus-extensions/nautilus-gdk-font-extensions.h:
	* libnautilus-extensions/nautilus-gdk-font-extensions.c:
	Removed misguided use of const in here. Gdk and Gtk object types
	just aren't suitable for const, and you end up doing type casts
	that defeat the purpose.

	* src/nautilus-window-manage-views.c: (load_underway_callback):
	Remove a FIXME for a fixed bug.
2001-01-05 02:03:34 +00:00
Darin Adler 292a29b61f Wrote a script to check for files that forget to include <config.h> and
* check-config-h.pl: Wrote a script to check for files that forget
	to include <config.h> and optionally edit to add it.

        * src/nautilus-zoom-control.c (set_zoom_level): Fixed the bug
	number in a FIXME.

        * docs/style-guide.html: Added one more tip.

        * check-FIXME.pl: Use my newfound Perl knowledge to spruce it up.

        * components/help/converters/gnome-db2html2/gdb3html.c:
        * components/help/converters/gnome-db2html2/sect-elements.c:
        * components/help/converters/gnome-db2html2/sect-preparse.c:
        * components/help/converters/gnome-db2html2/toc-elements.c:
        * components/help/converters/gnome-info2html2/html.c:
        * components/help/converters/gnome-info2html2/main.c:
        * components/help/converters/gnome-info2html2/parse.c:
        * components/help/converters/gnome-info2html2/utils.c:
        * components/help/converters/gnome-man2html2/gnome-man2html.c:
        * components/help/hyperbola-filefmt.c:
        * components/help/hyperbola-nav-index.c:
        * components/help/hyperbola-nav-search.c:
        * components/help/hyperbola-nav-tree.c:
        * components/html/glibwww-callbacks.c:
        * components/html/glibwww-init.c:
        * components/html/glibwww-trans.c:
        * components/html/gnome-dialogs.c:
        * components/html/ntl-web-browser.c:
        * components/services/install/eazel-install-metadata.c:
        * components/services/install/eazel-install-protocols.c:
        * components/services/install/eazel-install-rpm-glue.c:
        * components/services/install/eazel-install-tests.c:
        * components/services/install/eazel-install-utils.c:
        * components/services/install/eazel-install-xml-package-list.c:
        * components/services/install/eazel-install.c:
        * components/services/install/helixcode-install-utils.c:
        * components/services/startup/eazel-register.c:
        * components/websearch/ntl-web-search.c:
        * helper-utilities/authenticate/nautilus-authenticate-fork.c:
        * helper-utilities/authenticate/nautilus-authenticate-pam.c:
        * helper-utilities/authenticate/nautilus-authenticate.c:
        * libnautilus-extensions/nautilus-bonobo-extensions.c:
        * libnautilus-extensions/nautilus-file-utilities.c:
        * libnautilus-extensions/nautilus-glib-extensions.c:
        * libnautilus-extensions/nautilus-link.c:
        * libnautilus-extensions/nautilus-mime-type.c:
        * libnautilus-extensions/nautilus-undo-transaction.c:
        * librsvg/art_rgba.c:
        * librsvg/art_rgba_svp.c:
        * librsvg/rsvg-bpath-util.c:
        * librsvg/rsvg-path.c:
        * librsvg/rsvg.c:
        * librsvg/test-rsvg.c:
        * nautilus-widgets/nautilus-caption-table.c:
        * nautilus-widgets/nautilus-password-dialog.c:
        * nautilus-widgets/nautilus-preferences-box.c:
        * nautilus-widgets/nautilus-preferences-dialog.c:
        * nautilus-widgets/nautilus-preferences-group.c:
        * nautilus-widgets/nautilus-preferences-item.c:
        * nautilus-widgets/nautilus-preferences-pane.c:
        * nautilus-widgets/nautilus-radio-button-group.c:
        * nautilus-widgets/test-nautilus-widgets.c:
        * nautilus-widgets/test-preferences.c:
        * src/file-manager/desktop-item.c:
        * src/file-manager/desktop-layout.c:
        * src/file-manager/desktop-menu.c:
        * src/nautilus-bookmarks-window.c:
        * src/nautilus-gconf.c:
	* src/nautilus-window-menus.c:
        * src/nautilus-window-toolbars.c:
	* src/nautilus-zoom-control.c
        * src/nautilus-zoomable-frame-svr.c:
        * src/ntl-app.c:
        * src/ntl-content-view.c:
        * src/ntl-main.c:
        * src/ntl-meta-view.c:
        * src/ntl-miniicon.c:
        * src/ntl-uri-map.c:
        * src/ntl-view-frame-svr.c:
        * src/ntl-view.c:
        * src/ntl-window-state.c:
	Added includes of <config.h>.
2000-05-02 00:50:32 +00:00
Darin Adler 5ef2bdcff5 Some style guide updates. 2000-03-25 02:38:49 +00:00
Darin Adler 4f2240f04d Some of the underlying work to prepare for emblems on the icons.
* style-guide.html: Some minor updates to the style guide,
	including rules about headers.

	* libnautilus/nautilus-icon-factory.h,
	libnautilus/nautilus-icon-factory.c:
	(nautilus_icon_factory_get_emblem_icons_for_file),
	(nautilus_scalable_icon_get), (nautilus_icon_factor_clear),
	(nautilus_icon_factory_load_file),
	(nautilus_gdk_pixbuf_composite_corner),
	(nautilus_icon_factor_load_icon), (nautilus_scalable_icon_hash),
	(nautilus_scalable_icon_equal),
	(nautilus_icon_factory_get_icon_for_file), (load_specific_image):
	Added interface for getting emblem icons for a file, and got rid
	of the symbolic-link overlay that was previously built into the
	icon.

	* libnautilus/gnome-icon-container.c (update_icon):
	Get pixbufs for all emblems and pass into the icon object.

	* libnautilus/nautilus-icons-controller.c
	(nautius_icons_controller_get_icon_image):
	src/file-manager/fm-icons-controller.h,
	src/file-manager/fm-icons-controller.c
	(fm_icons_controller_get_icon_image): Return a list of emblem
	images along with the main image.

	* libnautilus/nautilus-icons-view-icon-item.h,
	libnautilus/nautilus-icons-view-icon-item.c
	(nautilus_icons_view_icon_item_set_emblems),
	(nautilus_icons_view_icon_item_destroy): Keep a list of emblem
	pixbufs in each icon. We don't draw them quite yet.

	* libnautilus/gdk-extensions.h, libnautilus/gdk-extensions.c:
	(nautilus_gdk_pixbuf_list_ref), (nautilus_gdk_pixbuf_list_unref),
	(nautilus_gdk_pixbuf_list_free): Convenience functions for
	manipulating lists of GdkPixbuf objects.

	* libnautilus/nautilus-directory.h,
	libnautilus/nautilus-directory.c: (nautilus_file_list_ref),
	(nautilus_file_list_unref), (nautilus_file_list_free): Convenience
	functions for manipulating lists of NautilusFile objects. Also got
	rid of NautilusFileList typedef.

	* libnautilus/nautilus-icon-factory.h,
	libnautilus/nautilus-icon-factory.h:
	(nautilus_scalable_icon_list_free): Convenience function for
	manipulating lists of NautilusScalableIcon objects.

	* libnautilus/nautilus-glib-extensions.h,
	libnautilus/nautilus-glib-extensions.c: (nautilus_g_list_equal):
	Function to compare two GLists to see if they are
	identical. Particularly useful with lists of reference-counted
	objects.

	* src/file-manager/fm-directory-view-icons.c
	(fm_directory_view_icons_destroy),
	(add_icon_if_already_positioned),
	(fm_directory_view_icons_append_selection_context_menu_items),
	(display_icons_not_already_positioned),
	(fm_direectory_view_icons_get_selection):
	src/file-manager/fm-directory-view-list.c
	(fm_directory_view_list_get_selection):
	src/file-manager/fm-directory-view.c (display_selection_info),
	(display_pending_files), (add_files_cb), (open_in_new_window_cb),
	(fm_directory_view_real_append_selection_context_menu_items): Got
	rid of use of NautilusFileList typedef, corrected ref. counting of
	files in the lists by using new calls.

	* src/nautilus-bookmarklist.c, src/nautilus-bookmarks-menu.c,
	src/nautilus-index-tabs.c,
	src/file-manager/fm-directory-view-icons.c,
	src/file-manager/fm-directory-view.c,
	src/file-manager/fm-icons-controller.c: A bit of reformatting.
2000-02-24 00:54:57 +00:00
Ramiro Estrugo f46e40d037 Added styleguide. 2000-02-15 20:55:05 +00:00