The background of the window paned is not set to be transparent, which
may cause it to become opaque when changing themes. This commit sets its
background color in the style sheet.
https://bugzilla.gnome.org/show_bug.cgi?id=765687
trash_retrieve_files_to_restore_thread() calls abs() with an argument of
type long, whereas abs() accepts ints. This commit fixes that by
replacing the call with the ABS macro, which is type-agnostic.
https://bugzilla.gnome.org/show_bug.cgi?id=769526
gettext has been continuously improving, up to a point where intltool
can be deprecated in favor of it. This commit ports the project files to
use upstream gettext.
https://bugzilla.gnome.org/show_bug.cgi?id=769362
The problem is that in the function canvas_container_set_workarea the screen width
and height are in "application pixels" while the workarea ones are in "device
pixels" so when the scaling is > 1, the margins are not properly setted.
We need to scale-down the workarea geometries to "application pixels".
https://bugzilla.gnome.org/show_bug.cgi?id=769302
gnome-common has been deprecated for quite some time now and using
upstream autoconf-archive macros is now recommended. This commit makes
changes to the project files as per the GNOME migration guide.
https://bugzilla.gnome.org/show_bug.cgi?id=769362
When copying, moving or linking files, original sources and their destinations
are stored in an information structure used for undoing the operation. The
sources and destinations were appended at the end of a list. Due to append
taking linear time, these file operations would have a resulting quadratic
complexity depending on the number of files. When operating on thousands of
files, this would lead to a significant decrease in speed. In order to fix
this, the sources and destinations are stored in a queue that allows appending
in constant time.
https://bugzilla.gnome.org/show_bug.cgi?id=757747
update_scripts_menu() and update_templates_menu() do not unref the
directories after calling nautilus_directory_get_by_uri(), which results
in leaks. This commit fixes that by adding calls to
nautilus_directory_unref().
https://bugzilla.gnome.org/show_bug.cgi?id=769182
The current implementation leaks the NautilusFileUndoManager instance,
because the code does not unref it anywhere. This commit adds a _new()
function to the undo manager and makes NautilusApplication manage its
lifetime.
https://bugzilla.gnome.org/show_bug.cgi?id=769082
Currently, the icon info caches are cleared in quit_mainloop(), which
does not get invoked as of GLib 2.32, thus resulting in NautilusIconInfo
leaks. This commit moves the cache clearing call to shutdown().
https://bugzilla.gnome.org/show_bug.cgi?id=769134
window-slot binds with query-editor via a property, which results in
nautilus_query_editor_set_location() being called on construction and
location changes. That function in turn calls
update_information_label(), which takes a ref on the file, but does not
release it. This can result in a crash with remote bookmarks when
connecting/disconnecting or switching back and forth.
This commit fixes that by adding an unref to update_information_label().
https://bugzilla.gnome.org/show_bug.cgi?id=768987
Starting with GTK+ 3.21, Nautilus is constantly reporting
underallocations happening in the path bar. That is chiefly caused by
some assumptions made in the code (i.e. both slider buttons are of the
same width, which is untrue, due to the “linked” style class).
This commit corrects those assumptions by using widths of both slider
buttons in allocation calculations.
https://bugzilla.gnome.org/show_bug.cgi?id=768916
g_file_is_native() should be enough to decide whether the file is local.
Checking if g_file_get_path() returns a native path lets us know if the
directory is possibly made available by use of FUSE and there is
nautilus_directory_is_local_or_fuse() for that.
https://bugzilla.gnome.org/show_bug.cgi?id=768733
The condition when cancelling the dialog was always true, and therefore
always setting the apply_to_all.
It was harmless due to the dialog being canceled anyway.
Thanks to Michael McConville to create the original patch.
The build fails on systems with GLib versions older than 2.49.1. That is
due to changes in GtkPlacesView, which require new symbols. This commit
bumps the version requirement in configure.ac to inform the user during
the configure phase.
Due to the floating bar being in an overlay, it can obscure the content
under it.
We were planning to remove it and use an action bar. But it's taking
long, so in the meantime we can improve this situations hiding the
floating bar when hovered.
On the way I improved the handling of the spinner, which was failing
to be shown on certain situations.
Patch based on Nelson Benitez, thanks!
https://bugzilla.gnome.org/show_bug.cgi?id=651293
