nautilus_desktop_window_composited_changed function will do nothing
if we use initial value from GdkScreen because of early return:
if (window->details->composited == composited)
return;
Change back initial value to TRUE to make sure that background will
be setup if screen is not composited.
https://bugzilla.gnome.org/show_bug.cgi?id=769360
Currently, the transfer info of an operation is only modified if it is
successful, resulting in a confusing reflection in the UI. Treating
skipped operations as completed and displaying them as such feels more
natural, as they are technically completed (i.e. nothing has been done).
This commit changes the behavior as such.
https://bugzilla.gnome.org/show_bug.cgi?id=769383
There are a couple of problems with the status string during file
duplication:
1. The status string is constructed by calling ngettext()
with the index of the file plus one.
2. nautilus_progress_info_take_status() is called with the total count
of files plus one.
These two combined result in funky status strings (e.g. “duplicating 3
file in X”).
This commit fixes both of those problems.
https://bugzilla.gnome.org/show_bug.cgi?id=769997
set_up_scripts_directory_global() currently uses the POSIX file
interface, which is inconsistent with the rest of the code. This commit
rewrites the parts of the function to use the GFile API.
https://bugzilla.gnome.org/show_bug.cgi?id=769602
Both the delete and copy operations in Nautilus deal with deleting files
recursively. Each operation has its own implementation of the same
functionality, mixed with specific logic, like error reporting through dialogs.
In order to remove duplicated code, extract delete logic to a separate function
which can be used by both operations.
Implement a function for deleting files recursively which reports errors and
success through an user provided callback.
https://bugzilla.gnome.org/show_bug.cgi?id=770109
The rename file popover and the new folder dialog share common logic for
validating file names entered by the user. The control logic was implemented
with a simple structure in files-view. Besides common logic, the structure also
held parameters specific to only one of the operations. Another problem is that
the current implementation does not allow flexibility in obtaining the file name
from the widgets and displaying error messages.
In order to fix this, reimplement the structure as an abstract class and create
two subclasses for the "Rename" and "New Folder" widgets.
https://bugzilla.gnome.org/show_bug.cgi?id=769336
Currently, the copyright notice includes a range of dates of which the
end year is 2014, which is not current. This commit changes the end year
to 2016.
https://bugzilla.gnome.org/show_bug.cgi?id=769917
At least GNOME Flashback session with Metacity still can be used
without compositing manager. Since transparency is not available
nautilus currently draw black background.
Fix it by checking if compositing manager is running and if it is
not then get background surface from root window and draw it on
nautilus desktop window.
https://bugzilla.gnome.org/show_bug.cgi?id=769360
Automatic resource registration appears to not work properly with the
static libgd variant, which causes warnings. That can be worked around
by linking against libgd dynamically.
https://bugzilla.gnome.org/show_bug.cgi?id=770121
Instead of using a themed icon.
This is necessary for flatpak Nautilus properly.
Patch made mostly by Mathieu Bridon and help of Patrick Griffis.
Thanks a lot!
The background of the window paned is not set to be transparent, which
may cause it to become opaque when changing themes. This commit sets its
background color in the style sheet.
https://bugzilla.gnome.org/show_bug.cgi?id=765687
trash_retrieve_files_to_restore_thread() calls abs() with an argument of
type long, whereas abs() accepts ints. This commit fixes that by
replacing the call with the ABS macro, which is type-agnostic.
https://bugzilla.gnome.org/show_bug.cgi?id=769526
gettext has been continuously improving, up to a point where intltool
can be deprecated in favor of it. This commit ports the project files to
use upstream gettext.
https://bugzilla.gnome.org/show_bug.cgi?id=769362