This reverts commit 543f5ae369.
When this feature was originally proposed, the use cases when <Ctrl><F>
is required because "just typing" doesn't do the trick were not
considered. Two such cases are searching for a ~ (tilde) and pasting
text to search with <Ctrl><V>. Both are now impractical because the
filter popover steals the focus.
Furthermore, we have a few inconsistent state bugs related to this.
Instead of shipping version 3.30 with these regressions and bugs, let's
withdraw this change.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/597
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/570
And closes https://gitlab.gnome.org/GNOME/nautilus/issues/571
Glade has been used to change the .ui definition of the Preference
dialog in commit f2061e9409
It has removed the "border-width" property, resulting in a 2px
padding being added around the notebook widget, which wasn not
intended and looks bad.
This issue will be gone in GTK+4, but we need to explicitly set
this style property to 0px in the meantime.
Do it in the code instead, where Glade cannot erase it.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/563
We are clearing &priv->extensions_background_menu when we actually
want to set priv->templates_menu. This looks like an edition overight
from 544c1cca56
Fix it. Also, remove != NULL guards because g_clear_object
already handles that case (doing nothing, as per documentation).
These actions are applying to the selected files, not the current folder.
Also, if fixed to apply to the current location, they overlap with
"Add to Bookmarks" in intent, making it hard for a person to decide.
Since we can't Star all location, favor "Add to Bookmarks" for now.
https://gitlab.gnome.org/GNOME/nautilus/issues/552
Currently the pathbar in trash shows a slash instead of
the trash icon at the start.
It could cause a misunderstanding of where users are now.
To fix this issue, it shows the icon.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/567
Currently back_button, forward_button and app_button (hamburger button)
are not accessible via keyboard.
This commit fixes this changing the property `can_focus` from False to
True for the above mentioned buttons.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/569
Pathbar context menus for non-current location were reimplemented as
popovers in commit ce3a5c721f
However, since then, we listen to GtkWidget::button-press-event"
instead of GtkButton::clicked. However, despite its name, the later
is emited whenever the GtkButton is activated, including using the
keyboard. As a result, we lost the ability to change location with
the keyboard.
Reversely, we gained the (undesirable) ability to change location
whenever a mouse button is pressed, even if that gesture would not
be handled by GtkButton. Example: when dragging to move the window.
Instead, partially revert these changes and use a GtkGesture to
popup context menus, like we already do for middle click.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/568 and https://gitlab.gnome.org/GNOME/nautilus/issues/588
