We need to move away from using eel and port most functionalities
inside nautilus.
Replaced the usage of eel_show_warning_dialog() with the show_dialog()
alternative.
https://gitlab.gnome.org/GNOME/nautilus/issues/331
Accessible name-changed events should not be emitted during the
initial load of the icon container. They should only be emitted when
a user-triggered action such as renaming the file causes the change.
This event is being emitted when the editable_text property is being
set. During the initial load the value is null, so check for that
condition and only emit the event when the original value is non-null.
Accessible children-changed events should not be emitted during the
initial load of the icon container. They should only be emitted when
a user-triggered action (creation of file, copying an item) causes
an item to be added.
User-triggered actions result in nautilus_canvas_container_layout_now
being called, so set a flag there so that we can distinguish the two
types of additions in the accessible icon-added callback.
Accessible children-changed events should not be emitted during the
initial load of the icon container. They should only be emitted when
a user-triggered action (creation of file, copying an item) causes
an item to be added.
User-triggered actions result in nautilus_canvas_container_layout_now
being called, so set a flag there so that we can distinguish the two
types of additions in the accessible icon-added callback.
We need to move away from using eel and port most functionalities
inside nautilus.
Replaced the usage of eel_show_warning_dialog() with the show_dialog()
alternative.
https://gitlab.gnome.org/GNOME/nautilus/issues/331
This might not be the case when handling archive files, in fact we were
freeing the list and assigning it to a new value for non-archive files,
but in case of archives the list was just freed and the invalid pointer
kept around, potentially causing a later crash.
Currently, when looping over icon sizes, each icon is copied to
$MESON_BUILD_ROOT/@appid@.png, meaning that the file is overwritten on
every iteration. This commit fixes that by copying to a subdirectory
under the build root and installing from there.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/364
Recently we have been seeing that gsettings doesn't work inside the
Flatpak build of Nautilus.
In 3f6cd2feb2
we gave full host access to Nautilus, so I expected that no more
--filesystem permission would be necessary.
For some reason... we still need to put that. Although it looks like a
bug somewhere.
For now, let's just explicitly allow access the desrt folder.
The selected icon views captions show up in a wrong order below
files (e.g. third, first, second option instead of first, second,
third).
This is unintuitive and not intended.
This patch fixes the issue by changing the ordering of the captions.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/343
The use new views preference checkbox does not update the view.
In order for it to take effect, one needs to toggle view.
This behaviour is not intended, and this should work same as
for other checkbox preferences.
We're fixing this by recreating the view whenever the preference box
is ticked/unticked.
Closes https://gitlab.gnome.org/GNOME/nautilus/issues/278
While selection is important for the content in the view or the current
path bar location, it doesn't seem to be so important for the sidebar,
since it's used more like a shortcut place to quickly navigate to
important places.
Also, the sidebar is more about showing the current state selected, and
not a selection of items.
To address both points seems to make sense to make the "selected" color
be less prominent than blue, and instead give a neutral gray.
This works gives the sidebar selected item a gray color.
The path bar would be looking better having a lighter design, and at the
same time a bit more colorful.
Ideally we would implement the new pathbar with animations, new styling,
etc. But that requires proper responsive design support and animation
support, which won't happen soon.
The relevant mockups are at https://wiki.gnome.org/Design/OS/Breadcrumbs
Partial work by Nikita Churaev at !145, modified styling by Lapo
Calamandrei.
Closes: #281
File utilities operations need to be tested thoroughly everytime
we make changes to make sure they're fine to use further.
This patch introduces an unit test file for the
nautilus_file_selection_equal.
In some cases (particularly when no I/O is performed, e.g. opening
other-locations:/// directly), the FDO FileManager1 object
OpenLocations property is set before the connection is made. This commit
makes the code defer doing that until then.
NAUTILUS_PREFERENCES_FILE_THUMBNAIL_LIMIT really uses MiB as its unit,
not MB as we multiply its value by 1024*1024 (MEGA_TO_BASE_RATE) in
thumbnail_limit_changed_callback(). This commit changes
MEGA_TO_BASE_RATE and its maximum value so that it shows a number using
MB unit as advertised.
Creating and destroying the controller each time we want to rename
something results in not being able to pop down the popover, which leads
to an inconsistent look.
The “containing-directory” in the file name widget controller parent
class needed to be made non-construct-only, as otherwise it would be
impossible to reuse the same controller.
Fixes https://gitlab.gnome.org/GNOME/nautilus/issues/260
This was due to size differences between bold and regular labels. The
problems was that invisible widgets always return 0 when their size is
requested and Nautilus tried to request the width a regular label would
take from an invisible bold label with the same text. This patch fixes
this by showing the label before measuring it and hiding it afterwards.
We were always showing the starred item in the sidebar, with an empty
state in the resulting view if no starred file was present.
This is usually what we want for regular items. However, in 3.28 the
feature is not working as good as we expected for those not using
the tracker directories as heavily as other users.
In order to prevent being too annoying, we can hide the sidebar item if
no starred files are present, while still providing the context menu
to be able to use the feature.
This can be reverted once we are able to star any file, once tracker has
the required API to star a file and have a sync callback for its result.
Closes: https://gitlab.gnome.org/GNOME/nautilus/issues/338
